[pull] main from MetaMask:main#440
Merged
Merged
Conversation
<!-- CURSOR_SUMMARY --> > [!NOTE] > Broad localization update for the German locale with corrected translations, consistency improvements, and new strings across major surfaces. > > - Large pass on `locales/languages/de.json`: translates previously English strings, fixes wording, and standardizes terminology (e.g., gas/fees, slippage, price impact, labels/buttons) > - Adds/updates keys for features including Perps trading (mid price, errors/tooltips, order flows), Predict (disclaimer, actions), Staking/TRON messages, mUSD/Rewards, Swaps/Bridge flows, Notifications, Settings, and MetaMask Card onboarding/verification flows > - Introduces new `ota_update_modal` strings > - Numerous minor copy adjustments to alerts, dialogs, lists, and sorting labels for clarity and consistency > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit efbf94d. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This reverts the changes from PR #24178 that added automatic tracking of remote feature flags to user traits via addTraitsToUser. Automatic Github revert not available for this PR. Reverted changes: - Removed useEffect hook that called addTraitsToUser with rawFeatureFlags - Removed useMetrics import and addTraitsToUser usage - Removed related unit tests for feature flag user traits tracking ## Related Reverts #24178 ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Reverts #24178 ## **Manual testing steps** Identify calls should be sent to Segment server again. ## **Screenshots/Recordings** NA ### **Before** NA ### **After** NA ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Reverts automatic syncing of remote feature flags to user traits. > > - Removes `useMetrics` import and the `useEffect` that called `addTraitsToUser(rawFeatureFlags)` in `FeatureFlagOverrideContext.tsx` > - Deletes related unit tests and mocks in `FeatureFlagOverrideContext.test.tsx` for bulk/add-on-change trait updates > - Keeps feature flag override functionality (set/remove/clear) intact > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 27ec9cd. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Enhances the gas fee sponsorship user experience by updating the tooltip message of "network fee" when the transaction is gas fees sponsored. ### Problem The tooltip message of "network fee" when the transaction is gas fees sponsored is not enough explicit for send transactions. ### Solution Implement a workaround that updates the tooltip message for gas fees sponsored. ## **Changelog** CHANGELOG entry: fixed gas fees sponsored tooltip message ## **Related issues** Fixes: null ## **Manual testing steps** 1. Go to the send page. 2. Send token to an address on a chain eligible of gas fees sponsored. 3. The "network fee" tooltip message should be explicit. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> <img width="400" height="596" alt="ext send msg" src="https://github.com/user-attachments/assets/cac1c17d-0453-46b2-8106-89884fe1e15a" /> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [X] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [X] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Refines tooltip copy for sponsored network fees to be transaction-agnostic. > > - Updates `network_fee_info_content_sponsored` in multiple locale JSONs to use "transact" instead of "swap" for clarity across send and other flows > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 7db6f5b. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )