[pull] main from MetaMask:main#563
Merged
Merged
Conversation
## **Description** Phase 3 analytics migration (Batch 3-13): migrate Network Management's components and hooks from `useMetrics` to the new analytics system (`useAnalytics`). **Reason**: Deprecate MetaMetrics in favour of the shared analytics utility and AnalyticsController. **Changes**: `ManageNetworks`, `NetworkMultiSelector`, `NetworkManager`, and `MultiRpcModal` now use `useAnalytics` from `app/components/hooks/useAnalytics/useAnalytics` and import `MetaMetricsEvents` from `app/core/Analytics`; test mocks updated to mock `useAnalytics` instead of `useMetrics`. ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/MCWP-302 (Batch 3-13) ## **Manual testing steps** ```gherkin Feature: Network Management analytics Scenario: user triggers a network management flow event Given app is open and user is in a network management flow When user performs an action that triggers analytics (e.g. switch network, open network manager, accept multi-RPC modal) Then the event is tracked on Mixpanel ``` ## **Screenshots/Recordings** N/A – analytics migration, no UI change. ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk UI refactor that only swaps analytics plumbing; primary risk is missing/misnamed events if the new `useAnalytics` hook or `MetaMetricsEvents` import differs from the old `useMetrics` behavior. > > **Overview** > Switches Network Management UI surfaces (e.g., `ManageNetworks`, `NetworkManager`, `NetworkMultiSelector`, and `MultiRpcModal`) from `useMetrics` to the shared `useAnalytics` hook while keeping existing event tracking calls (`trackEvent`/`createEventBuilder`). > > Updates unit tests to mock `useAnalytics` instead of `useMetrics`, and adjusts event constant imports/expectations to use `MetaMetricsEvents` from `core/Analytics/MetaMetrics.events` where applicable. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 3c6fb53. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )