Skip to content

[pull] main from MetaMask:main#627

Merged
pull[bot] merged 1 commit intoReality2byte:mainfrom
MetaMask:main
Mar 25, 2026
Merged

[pull] main from MetaMask:main#627
pull[bot] merged 1 commit intoReality2byte:mainfrom
MetaMask:main

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented Mar 25, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
* Migrates SRP selection and SRP input UI from legacy patterns to the
MetaMask design system and Tailwind.
* Jira: https://consensyssoftware.atlassian.net/browse/TO-601
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: Select SRP and SRP input (design system migration)

  Scenario: User opens Select SRP from a flow that shows the bottom sheet
    Given the user is on a screen that opens the Select SRP bottom sheet
    When the user opens the bottom sheet and views the SRP list
    Then the list and header layout look correct and the sheet dismisses as before

  Scenario: User sees the SRP list with multiple keyrings
    Given the user has multiple SRPs and the SRP list is visible
    When the user scrolls the list and selects an item
    Then items render and interact as before

  Scenario: User enters a secret recovery phrase in SrpInput
    Given the user is on import or SRP entry using SrpInput
    When the user focuses the field, types text, and triggers error or disabled states if applicable
    Then borders, padding, and accessories (if any) match design and validation still works

```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**
<img width="313" height="634" alt="Screenshot 2026-03-20 at 1 09 48 PM"
src="https://github.com/user-attachments/assets/017f3c79-4170-46b7-87ca-b1c063f57fdb"
/>
<img width="308" height="630" alt="Screenshot 2026-03-20 at 1 12 58 PM"
src="https://github.com/user-attachments/assets/f4f245e1-c311-48c1-b067-26a6af737998"
/>


<!-- [screenshots/recordings] -->

### **After**
<img width="311" height="630" alt="Screenshot 2026-03-20 at 12 47 19 PM"
src="https://github.com/user-attachments/assets/9a12715f-2a56-4918-990d-c1bf8bf38708"
/>
<img width="310" height="633" alt="Screenshot 2026-03-20 at 12 52 40 PM"
src="https://github.com/user-attachments/assets/6a5a5852-c519-46c3-8c56-c74e7e073a12"
/>

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk UI refactor that swaps legacy `StyleSheet`/`View` styling for
design-system `Box` + Tailwind classes, with no changes to SRP selection
flow or analytics behavior.
> 
> **Overview**
> Migrates SRP-related UI (`SRPList`, `SelectSRPBottomSheet`, and
`SrpInput`) from legacy `useStyles`/`StyleSheet` patterns to
design-system `Box` components and Tailwind-based styling.
> 
> Removes the dedicated `SRPList.styles.ts` and `SelectSRP/styles.ts`
files, updates container/layout styling (including max-height handling
and bottom-sheet spacing), and updates the `SrpInput` snapshot to
reflect the new style composition.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
61562eb. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@pull pull Bot locked and limited conversation to collaborators Mar 25, 2026
@pull pull Bot added the ⤵️ pull label Mar 25, 2026
@pull pull Bot merged commit 0c163c9 into Reality2byte:main Mar 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant