From 4de08013811bcaee8d3a9f6bc0321dec95c4d549 Mon Sep 17 00:00:00 2001 From: Brian August Nguyen Date: Thu, 26 Mar 2026 17:26:23 -0700 Subject: [PATCH] chore: add candlestick icon to component library (#27961) ## **Description** This PR adds the candlestick icon to the component-library ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/DSYS-656 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** ### **Before** ### **After** https://github.com/user-attachments/assets/510bd10b-0729-4d20-ab0e-44fdec07ed8f ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- > [!NOTE] > **Low Risk** > Low risk: adds a new SVG asset and wires it into the generated icon enum/mapping, with no changes to runtime logic beyond selecting an additional icon name. > > **Overview** > Adds a new `Candlestick` icon to the component library by introducing `assets/candlestick.svg`, extending `IconName` with `Candlestick`, and wiring the new asset into `assetByIconName`. > > Also includes minor import/mapping reordering in the generated icon asset/type files (e.g., `Search`, `MetamaskFoxOutline`) with no functional behavior change. > > Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0cd4fb79c53f456ce7bd13f27c94483baf3245d6. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot). --- .../components/Icons/Icon/Icon.assets.ts | 10 ++++++---- .../components/Icons/Icon/Icon.types.ts | 5 +++-- .../components/Icons/Icon/assets/candlestick.svg | 1 + 3 files changed, 10 insertions(+), 6 deletions(-) create mode 100644 app/component-library/components/Icons/Icon/assets/candlestick.svg diff --git a/app/component-library/components/Icons/Icon/Icon.assets.ts b/app/component-library/components/Icons/Icon/Icon.assets.ts index a6eae2d7aeb..1a8c7cc14e5 100644 --- a/app/component-library/components/Icons/Icon/Icon.assets.ts +++ b/app/component-library/components/Icons/Icon/Icon.assets.ts @@ -47,6 +47,7 @@ import calendarSVG from './assets/calendar.svg'; import callSVG from './assets/call.svg'; import cameraSVG from './assets/camera.svg'; import campaignSVG from './assets/campaign.svg'; +import candlestickSVG from './assets/candlestick.svg'; import cardposSVG from './assets/card-pos.svg'; import cardSVG from './assets/card.svg'; import cashSVG from './assets/cash.svg'; @@ -152,8 +153,8 @@ import mapSVG from './assets/map.svg'; import menuSVG from './assets/menu.svg'; import messagequestionSVG from './assets/message-question.svg'; import messagesSVG from './assets/messages.svg'; -import metamaskfoxoutlineSVG from './assets/metamask-fox-outline.svg'; import metamaskfoxfilledSVG from './assets/metamask-fox-filled.svg'; +import metamaskfoxoutlineSVG from './assets/metamask-fox-outline.svg'; import micSVG from './assets/mic.svg'; import minusboldSVG from './assets/minus-bold.svg'; import minussquareSVG from './assets/minus-square.svg'; @@ -197,8 +198,8 @@ import savingSVG from './assets/saving.svg'; import scanbarcodeSVG from './assets/scan-barcode.svg'; import scanfocusSVG from './assets/scan-focus.svg'; import scanSVG from './assets/scan.svg'; -import searchSVG from './assets/search.svg'; import searchfilledSVG from './assets/search-filled.svg'; +import searchSVG from './assets/search.svg'; import securityalertSVG from './assets/security-alert.svg'; import securitycrossSVG from './assets/security-cross.svg'; import securitykeySVG from './assets/security-key.svg'; @@ -329,6 +330,7 @@ export const assetByIconName: AssetByIconName = { [IconName.Call]: callSVG, [IconName.Camera]: cameraSVG, [IconName.Campaign]: campaignSVG, + [IconName.Candlestick]: candlestickSVG, [IconName.CardPos]: cardposSVG, [IconName.Card]: cardSVG, [IconName.Cash]: cashSVG, @@ -434,8 +436,8 @@ export const assetByIconName: AssetByIconName = { [IconName.Menu]: menuSVG, [IconName.MessageQuestion]: messagequestionSVG, [IconName.Messages]: messagesSVG, - [IconName.MetamaskFoxOutline]: metamaskfoxoutlineSVG, [IconName.MetamaskFoxFilled]: metamaskfoxfilledSVG, + [IconName.MetamaskFoxOutline]: metamaskfoxoutlineSVG, [IconName.Mic]: micSVG, [IconName.MinusBold]: minusboldSVG, [IconName.MinusSquare]: minussquareSVG, @@ -479,8 +481,8 @@ export const assetByIconName: AssetByIconName = { [IconName.ScanBarcode]: scanbarcodeSVG, [IconName.ScanFocus]: scanfocusSVG, [IconName.Scan]: scanSVG, - [IconName.Search]: searchSVG, [IconName.SearchFilled]: searchfilledSVG, + [IconName.Search]: searchSVG, [IconName.SecurityAlert]: securityalertSVG, [IconName.SecurityCross]: securitycrossSVG, [IconName.SecurityKey]: securitykeySVG, diff --git a/app/component-library/components/Icons/Icon/Icon.types.ts b/app/component-library/components/Icons/Icon/Icon.types.ts index 4b8970bcc2b..b289b1210a1 100644 --- a/app/component-library/components/Icons/Icon/Icon.types.ts +++ b/app/component-library/components/Icons/Icon/Icon.types.ts @@ -117,6 +117,7 @@ export enum IconName { Call = 'Call', Camera = 'Camera', Campaign = 'Campaign', + Candlestick = 'Candlestick', CardPos = 'CardPos', Card = 'Card', Cash = 'Cash', @@ -222,8 +223,8 @@ export enum IconName { Menu = 'Menu', MessageQuestion = 'MessageQuestion', Messages = 'Messages', - MetamaskFoxOutline = 'MetamaskFoxOutline', MetamaskFoxFilled = 'MetamaskFoxFilled', + MetamaskFoxOutline = 'MetamaskFoxOutline', Mic = 'Mic', MinusBold = 'MinusBold', MinusSquare = 'MinusSquare', @@ -267,8 +268,8 @@ export enum IconName { ScanBarcode = 'ScanBarcode', ScanFocus = 'ScanFocus', Scan = 'Scan', - Search = 'Search', SearchFilled = 'SearchFilled', + Search = 'Search', SecurityAlert = 'SecurityAlert', SecurityCross = 'SecurityCross', SecurityKey = 'SecurityKey', diff --git a/app/component-library/components/Icons/Icon/assets/candlestick.svg b/app/component-library/components/Icons/Icon/assets/candlestick.svg new file mode 100644 index 00000000000..2f304740783 --- /dev/null +++ b/app/component-library/components/Icons/Icon/assets/candlestick.svg @@ -0,0 +1 @@ + \ No newline at end of file