[pull] main from MetaMask:main#778
Merged
Merged
Conversation
…tings [GE-244] (#30440) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Simplifies notifications onboarding by removing the OptIn screen/stack entirely (routes, navigation registration, hooks, and tests) and updating callers (e.g., AccountsMenu, BasicFunctionalityModal) to go directly to Routes.NOTIFICATIONS.VIEW / notification settings. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/GE-244 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> <img width="1080" height="2271" alt="Screenshot_20260513-160021" src="https://github.com/user-attachments/assets/81d1bcc7-12b5-4e2b-ad88-fe778edfaa30" /> ### **After** <img width="1179" height="2556" alt="Simulator Screenshot - iPhone 15 Pro - 2026-05-21 at 11 25 05" src="https://github.com/user-attachments/assets/f43f46cc-2481-4752-9d57-e8de0fdb500f" /> <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes notifications navigation and onboarding by removing the dedicated `OptIn` screens/routes and adjusting entry points to show a disabled-state prompt with a CTA to settings. Moderate risk due to altered navigation paths and deleted E2E/page-object coverage, though changes are contained to notifications UI/routing. > > **Overview** > Simplifies notifications onboarding by **removing the `OptIn` screen/stack entirely** (routes, navigation registration, hooks, and tests) and updating callers (e.g., `AccountsMenu`, `BasicFunctionalityModal`) to go directly to `Routes.NOTIFICATIONS.VIEW` / notification settings. > > Updates `NotificationsView` to render a new `DisabledNotifications` empty-state when notifications are turned off, with a CTA that navigates to `Routes.SETTINGS.NOTIFICATIONS`, and adds new strings and selector test IDs to support this UI. > > Cleans up related tests and test infrastructure (route constant expectations, navigator registration tests, removed notifications opt-in page object and smoke spec) and modernizes the existing notifications empty component to use the design system components/variants. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 74225e7. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
## **Description** The SDK-V2 `ConnectionRegistry` catches errors in `handleMwpDeeplink` and `handleConnectDeeplink` and routes them through a local `logger` (`app/core/SDKConnectV2/services/logger.ts`) that just prefixes and calls `console.error`. The app's Sentry init (`app/util/sentry/utils.ts`) only wires up `dedupeIntegration` and `extraErrorDataIntegration` — there's no `captureConsoleIntegration` — so those errors (including the well-known `\"Failed to handle connect deeplink\"` string) are silently dropped and never reach Sentry in production. The only existing signal for these failures is the `failure_reason` property on the `REMOTE_CONNECTION_REQUEST_FAILED` MetaMetrics event, which is useful for aggregate counts but provides no stack trace, no breadcrumbs, and no context. This PR wires both deeplink-entry catch sites to `Logger.error` from `app/util/Logger`, which already calls `captureException` inside a Sentry scope, respects the metrics opt-in, and supports tags/context. The existing `logger.error` console output is kept so local debugging is unchanged (and `Logger.error` is a no-op in `__DEV__` anyway). ### What's reported - **Tags** (searchable in Sentry): - \`feature: 'mm-connect'\` — intentionally uses the public-facing product name even though the directory/class still use the older \`SDKConnectV2\` nomenclature. There's an inline comment in the code making this explicit; the internal naming needs to migrate but tagging Sentry with the public name now avoids renaming dashboards/alerts later. - \`operation: 'handle_mwp_deeplink'\` | \`'handle_connect_deeplink'\` - **Context** (\`mwp_deeplink\`): - \`url\` (redacted via \`redactUrl\` — query/fragment stripped) - For \`handle_connect_deeplink\`: \`dapp_url\`, \`dapp_name\`, \`sdk_version\`, \`sdk_platform\` (when the connection request parsed successfully; gracefully \`undefined\` when parse failed) Scope is intentionally limited to the two deeplink-entry catches — the most user-impactful failures, triggered directly by an incoming deeplink. The other \`console.error\`-only sites in the registry (\`initialize\`, \`evictIfAtCapacity\`, \`reconnectAll\`, \`handleSimpleDeeplink\` 'not found' log) can be addressed in a follow-up if useful. ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: Companion PR (provides the QA test surface): [feat(playground): add MWP deeplink failure repro panel](MetaMask/connect-monorepo#300). ## **Manual testing steps** > Easiest way to exercise every branch reproducibly: use the companion playground PR linked above. It adds a collapsible *QA: MWP deeplink failure repros* card with one tappable deeplink per failure branch. Without that PR you can still test by manually constructing deeplinks (URLs documented in the playground PR description and table). ### Setup 1. Install a debug build of this PR's branch on a real device (Sentry is disabled in E2E / when \`MM_SENTRY_DSN\` is missing — see \`app/util/sentry/utils.ts\` \`setupSentry\`). 2. Accept the metrics opt-in during onboarding (Sentry \`captureException\` only fires when \`METRICS_OPT_IN === AGREED\`). 3. From a desktop browser, deploy or run the [playground branch from connect-monorepo PR #300](MetaMask/connect-monorepo#300) and open it on the device's mobile browser. Expand the *QA: MWP deeplink failure repros* section. ### Feature: SDK-V2 deeplink failure observability Scenario: parse failure produces a Sentry event with gracefully missing dapp metadata Given the device is set up per the Setup steps above When the user taps the *Tap on mobile* button on the *Payload is not valid JSON* row Then the MetaMask Mobile app opens and shows a *Connection failed* toast And a \`REMOTE_CONNECTION_REQUEST_FAILED\` MetaMetrics event fires with \`failure_reason\` containing \`SyntaxError\` or similar JSON parse text And a Sentry event is captured with: - tag \`feature: mm-connect\` - tag \`operation: handle_connect_deeplink\` - context \`mwp_deeplink.url\` ending in \`[REDACTED]\` - context \`mwp_deeplink.dapp_url\`, \`dapp_name\`, \`sdk_version\`, \`sdk_platform\` all \`undefined\` (because parsing failed before \`connReq\` was assigned) Scenario: handshake failure produces a Sentry event with full dapp/sdk context Given the device is set up per the Setup steps above When the user taps the *Tap on mobile* button on the *Control: well-formed connect deeplink* row Then the deeplink parses successfully (the dapp metadata is well-formed) but the relay handshake will time out / fail because no wallet is on the other end of the fake session id And a Sentry event is captured with: - tag \`feature: mm-connect\` - tag \`operation: handle_connect_deeplink\` - context \`mwp_deeplink.dapp_url: \"https://playground.metamask.io\"\` - context \`mwp_deeplink.dapp_name: \"MMC Playground (QA Repro)\"\` - context \`mwp_deeplink.sdk_version: \"0.0.0-qa-repro\"\` - context \`mwp_deeplink.sdk_platform: \"JavaScript\"\` Scenario: each remaining failure branch is observable Given the device is set up per the Setup steps above When the user taps each of the remaining rows (*No payload param*, *Payload parses but is not a ConnectionRequest*, *sessionRequest.id is not a UUID*, *dapp.url claims to be an internal origin*, *c=1 flag but plain payload*, *Payload over 1MB*) Then each one produces both a \`REMOTE_CONNECTION_REQUEST_FAILED\` MetaMetrics event and a Sentry event tagged \`feature: mm-connect\`, \`operation: handle_connect_deeplink\` Scenario (regression): existing deeplink flow is unchanged Given the device has an existing persisted MWP connection from a real dapp When the user re-opens the dapp and triggers the *resume connection* flow (simple deeplink with \`?id=…\`) Then nothing in the connection flow has changed; no new Sentry events are emitted unless the inner flow actually throws ### Verifying in Sentry In the project Sentry dashboard: 1. Filter by \`feature:mm-connect\` → only the new events from this PR should appear. 2. Filter by \`operation:handle_connect_deeplink\` vs \`handle_mwp_deeplink\` to separate the connect-flow failures from the wrapper-dispatch failures. 3. On any event, the *Additional Data* panel should show the \`mwp_deeplink\` context block with the redacted URL and dapp/sdk fields. ## **Screenshots/Recordings** N/A — observability-only change, no user-visible UI difference. ### **Before** Failures in MWP deeplink dispatch logged only to the device console; no Sentry event. ### **After** Failures captured in Sentry with searchable tags and dapp/sdk context. Existing console.error preserved for local debugging. ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.
In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->
## **Description**
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry:
## **Related issues**
Fixes:
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.
Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
#### Performance checks (if applicable)
- [ ] I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example
For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).
## **Pre-merge reviewer checklist**
<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Low functional risk since this only changes a test, but it reduces CI
coverage by skipping a BuildQuote payment-selection interaction that
could mask regressions.
>
> **Overview**
> Marks the `opens the V2 PaymentSelectionModal when tapping the payment
pill` test in `BuildQuote.view.test.tsx` as skipped, effectively
disabling that UI interaction assertion in the V2 unified-buy BuildQuote
test suite.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
e413f07. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com> Co-authored-by: Laurel <153323700+i18nlaurel@users.noreply.github.com>
## **Description**
Fixes several World Cup Predict UI issues:
1. Corrects the World Cup footer icon used in the main feed banner.
2. Removes client-side sorting for World Cup stage tab markets so
feature flag list ordering is preserved.
3. Fixes the active Live tab label/dot colors without changing the
active tab background behavior for other tabs.
4. Optimizes the bundled World Cup banner asset size and aligns the
default banner aspect ratio.
## **Changelog**
CHANGELOG entry: null
## **Related issues**
Fixes: PRED-897
## **Manual testing steps**
```gherkin
Feature: Predict World Cup UI polish
Scenario: user views the World Cup Predict screen
Given the Predict World Cup feature flag is enabled
When user opens the World Cup Predict screen
Then the World Cup tabs render with the correct active and inactive colors
And the Live tab label and pulsing dot remain readable when selected
And the World Cup banner renders with the correct icon and aspect ratio
```
## **Screenshots/Recordings**
### **Before**
N/A
### **After**
N/A
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
#### Performance checks (if applicable)
- [ ] I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example
For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
## Test plan
```bash
yarn jest app/components/UI/Predict/views/PredictWorldCup/PredictWorldCup.test.tsx app/components/UI/Predict/components/PredictWorldCupMainFeedBanner/PredictWorldCupMainFeedBanner.test.tsx app/components/UI/Predict/queries/worldCup.test.ts app/components/UI/Predict/hooks/usePredictWorldCup.test.ts app/components/UI/Predict/utils/worldCup.test.ts --runInBand
```
Result: 5 test suites passed, 50 tests passed.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Low risk UI/query behavior tweaks; main functional change is removing
client-side sorting for stage markets, which could change stage tab
ordering but is limited to World Cup Predict screens.
>
> **Overview**
> Polishes the World Cup Predict UI by updating the main-feed banner’s
default image aspect ratio (now `360/177`) and explicitly sizing the
banner arrow icon.
>
> Adjusts World Cup stage market fetching to **stop client-side
start-time sorting**, preserving the API/flag-provided ordering;
corresponding tests are updated for the new expected order.
>
> Refactors tab rendering to a dedicated `WorldCupTabButton` and fixes
*Live* tab label/dot readability when active by rendering it under an
inverted design-system theme while keeping existing active-background
behavior.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
0e6ccea. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
## Version Bump After Release This PR bumps the main branch version from 7.79.0 to 7.80.0 after cutting the release branch. created manually as the automation was broken CHANGELOG entry: null Co-authored-by: Cursor <cursoragent@cursor.com>
## **Description**
Updates the Predict World Cup main feed banner image asset.
## **Changelog**
CHANGELOG entry: null
## **Related issues**
Fixes: PRED-907
## **Manual testing steps**
```gherkin
Feature: Predict World Cup banner
Scenario: user views the Predict main feed banner
Given the app is running with Predict available
When user navigates to the Predict experience
Then the updated World Cup banner image is displayed
```
## **Screenshots/Recordings**
N/A - image asset update only.
### **Before**
N/A
### **After**
<img width="350" alt="Simulator Screenshot - mm-blue - 2026-05-21 at 14
17 10"
src="https://github.com/user-attachments/assets/d91aa215-d23a-43c2-a47a-b12500678ee9"
/>
## **Pre-merge author checklist**
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
#### Performance checks (if applicable)
- [ ] I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example
For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Low risk: appears to be an image asset swap for the Predict World Cup
main feed banner with no functional logic changes.
>
> **Overview**
> Updates the Predict World Cup main feed banner to use a refreshed
image asset (visual-only change) so users see the new banner in the
Predict main feed.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
b069da1. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Introduces a step-by-step onboarding experience on the Money home screen, replacing the previous static `MoneyOnboardingCard` with a generic `StepperCard` component backed by Redux state. **Key changes:** - **`StepperCard` + `SegmentedProgressBar`** — new reusable components that render a multi-step card with a visual progress bar, image slot, title/description, and primary/secondary CTAs. Designed to be product-agnostic; driven entirely by the caller via `steps[]` + `currentStep` props. - **Redux stepper state** — `SET_ONBOARDING_STEPPER_STEP` action + reducer keyed by `stepperId`, so multiple independent steppers can coexist without new Redux fields per product. - **`useMoneyOnboardingStep`** — thin hook that reads/writes the Money stepper step from Redux, exposing `currentStep` and `incrementStep`. - **`MoneyConfirmationScreenStack` split** — the Money confirmation screens are now registered as a separate `MoneyConfirmationScreenStack` in `MainNavigator` to prevent the bottom tab bar from rendering on Money confirmation screens. - **Added Money onboarding stepper reset to developer options** — The Money onboarding stepper state can now be reset in the developer options. - ## **Changelog** CHANGELOG entry: refactored the Money onboarding stepper; created generic StepperCard and SegmentedProgressBar component ## **Related issues** Fixes: - [MUSD-795: [Mobile] Build the Money Account home screen onboarding stepper — all states](https://consensyssoftware.atlassian.net/browse/MUSD-795) - [MUSD-820: Money Home onboarding stepper polish](https://consensyssoftware.atlassian.net/browse/MUSD-820) ## **Manual testing steps** ```gherkin Feature: Money home onboarding stepper Scenario: New user sees step 1 (Fund your account) Given the user has a Money account with zero balance And the user has not previously completed onboarding When the user opens the Money tab Then the StepperCard is visible showing step 1 of 2 And the segmented progress bar shows 1 segment filled Scenario: Step auto-advances when balance is detected Given the user has a Money account with a non-zero mUSD balance When the user opens the Money tab Then step 1 is automatically skipped And the StepperCard shows the next "get card"/"link card" step Scenario: User completes all onboarding steps Given the user is on the final stepper step When the user presses the primary CTA Then the StepperCard disappears And the Money earnings section is shown without extra top padding Scenario: Add money sheet opens from confirmation route Given the user taps "Add money" Then the Add money screen opens without the bottom tab bar visible ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** ### **After** https://www.loom.com/share/22884085e9184bb899772e3b7dbd7b34 ## **Pre-merge author checklist** <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [x] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [x] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- Generated with the help of the pr-description AI skill --> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Medium risk due to new persisted Redux state and navigation stack restructuring for Money (including a new confirmations root), which could impact onboarding visibility/progress and Money flow routing if miswired. > > **Overview** > Replaces the Money home’s static onboarding card with a **Redux-backed multi-step stepper** that can auto-advance based on account balance and card-link status, and introduces reusable `StepperCard`/`SegmentedProgressBar` components to render step-based onboarding with primary/secondary CTAs. > > Adds generic onboarding stepper persistence via `onboardingStepperProgress` (keyed by `stepperId`) plus `setOnboardingStepperStep` and `useOnboardingStep`, including a dev option to reset Money’s stepper progress. > > Refactors Money navigation by splitting out a dedicated `Routes.MONEY.CONFIRMATIONS_ROOT` + `MoneyConfirmationScreenStack` (no bottom tab bar) and updates Money deposit/withdraw confirmation routing accordingly; includes associated test updates and copy changes for the new stepper strings. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 1a07b56. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Matthew Grainger <Matt561@users.noreply.github.com>
…ppear against pure black (#30411) ## **Description** Part of an ongoing initiative to audit all app flows against pure black dark mode. Pure black is currently behind the `MM_PURE_BLACK_PREVIEW` feature flag (off by default) and is not yet user-facing — this work is being done ahead of the design-tokens package bump that will make pure black the default dark theme. When the flag is enabled, `background.default` and `background.alternative` are both overridden to `#000000`, causing bottom sheet and action sheet surfaces to become invisible against the pure black screen background. This PR fixes the affected surfaces by replacing those tokens with `background.section` (`#1c1d1f`), which is intentionally not overridden by the flag and provides the correct elevated surface appearance per the Figma spec. Components updated: - `TradeWalletActions` — action sheet container + list items - `MoneyAddMoneySheet` — bottom sheet background - `NetworkManager` — tab bar + sheet container - `NetworkMultiSelector` — list body + select-all cell - `NetworkListBottomSheet` — sheet background - `FundActionMenu` — sheet background - `ListItemMultiSelectButton` — unselected row background - ## **Changelog** CHANGELOG entry:null ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/TMCU-635 ## **Manual testing steps** ```gherkin Feature: Pure black dark mode surfaces Scenario: user opens action/bottom sheets with pure black flag enabled Given the app is in dark mode with MM_PURE_BLACK_PREVIEW=true When user opens Trade, Buy/Sell, Network, or Add Token sheets Then each sheet has a visible elevated dark surface (#1c1d1f) instead of blending into the black background ``` ## **Screenshots/Recordings** ### Buy/Sell #### Dark | Before | After | |--------|-------| |  |  | #### Light (Unaffected) | Before | After | |--------|-------| |  |  | ### Network Picker from Import Token #### Dark | Before | After | |--------|-------| |  |  | #### Light (Unaffected) | Before | After | |--------|-------| |  |  | ### Web #### Dark | Before | After | |--------|-------| |  |  | #### Light (Unaffected) | Before | After | |--------|-------| |  |  | ### Network Manager #### Dark | Before | After | |--------|-------| |  |  | #### Light (Unaffected) | Before | After | |--------|-------| |  |  | ### Money #### Dark | Before | After | |--------|-------| |  |  | #### Light (Unaffected) | Before | After | |--------|-------| |  |  | ### Main Trade Action #### Dark | Before | After | |--------|-------| |  |  | #### Light (Unaffected) | Before | After | |--------|-------| |  |  | ### **Before** `~` ### **After** `~` ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [x] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [x] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Primarily visual/theming changes gated behind `MM_PURE_BLACK_PREVIEW`; risk is limited to UI regressions in sheet backgrounds and pressed states across several screens. > > **Overview** > Introduces `themeUtils` helpers (`getElevatedSurfaceColor`, `useElevatedSurface`) to switch elevated surfaces to `background.section` in dark mode when `MM_PURE_BLACK_PREVIEW` is enabled. > > Updates multiple bottom sheets/action sheets and list items to use these helpers (via `twClassName`/Tailwind classes or theme-derived colors), preventing sheet surfaces from blending into pure black backgrounds; also adjusts `Tabs` to avoid using `background.alternative` when pure black is enabled in dark mode. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit ceb577c. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
… cp-7.79.0 (#30536) ## **Description** Fixes collapsed Predict market detail action buttons for single-outcome markets. The Yes/No footer actions were rendering as visible controls, but their parent action columns could measure too small, which made the footer border appear in the wrong place and left the buttons visually clipped. This change reserves the expected action button height in the Predict market details action columns while preserving the existing `showPayoutEstimate` layout behavior. It also adjusts the fee exemption label positioning so it remains anchored with the footer layout. ## **Changelog** CHANGELOG entry: Fixed a bug that caused Predict market action buttons to appear collapsed on single-outcome market details. ## **Related issues** Fixes: PRED-926 https://consensyssoftware.atlassian.net/browse/PRED-926?atlOrigin=eyJpIjoiOWEwZDE0N2ZhZTZlNGYwNzk5NGI3OTFkZGQyNDFkNjgiLCJwIjoiaiJ9 ## **Manual testing steps** ```gherkin Feature: Predict market details footer actions Scenario: single-outcome market details show Yes and No actions Given the user opens an open Predict market details screen for a single-outcome market And the market has Yes and No outcome tokens When the market details screen finishes loading Then the Yes and No footer action buttons are fully visible And the footer border is positioned above the full action area And existing position content remains visible above the footer ``` ## **Screenshots/Recordings** ### **Before** <img width="431" height="889" alt="Screenshot 2026-05-21 at 13 50 44" src="https://github.com/user-attachments/assets/31a1bce2-5342-447a-9722-ccb4f69ff1ee" /> Yes/No footer action buttons appeared collapsed, with only a thin strip visible and the footer border positioned through the action area. ### **After** <img width="439" height="907" alt="Screenshot 2026-05-21 at 13 49 29" src="https://github.com/user-attachments/assets/c1b63e86-2423-43b2-b48d-42685b65972b" /> Yes/No footer action buttons are fully visible at the bottom of the market details screen. ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the tic <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk UI/layout change that adds minimum height constraints to footer action columns/buttons and adjusts a label’s positioning; behavior changes are limited to Predict market details rendering. > > **Overview** > Fixes a Predict market details layout bug where the Yes/No footer actions could collapse/clipped in single-outcome markets by **reserving a minimum height** for both the action buttons and their containing columns. > > Also tweaks the fee exemption banner styling by moving absolute positioning into `twClassName` so it stays anchored correctly with the footer, and adds a test asserting the action columns maintain the expected minimum height. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 10a2c17. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: hunty <hunter.goodreau@consensys.net>
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.
In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->
## **Description**
> Adds a new component-view test suite for `CardHome` that validates key
rendering states, navigation targets (e.g., add funds, asset selection,
spending limit, cashback, metal card), and logout behavior using a
minimal navigation stack and real Redux fixtures.
>
> Refactors card-related test infrastructure by introducing a seeded
`cardStatePreset`, a `renderCardHomeView` helper, expanded
component-view Engine mocks, and selector-based `testID` constants for
`CardAuthentication` (plus new `SpendingLimit` selectors). Removes the
old card navbar smoke/e2e test and its associated analytics
expectations.
>
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry:
## **Related issues**
Fixes:
## **Manual testing steps**
```gherkin
Feature: my feature name
Scenario: user [verb for user action]
Given [describe expected initial app state]
When user [verb for user action]
Then [describe expected outcome]
```
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.
Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
#### Performance checks (if applicable)
- [ ] I've tested on Android
- Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example
For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).
## **Pre-merge reviewer checklist**
<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Low risk: changes are limited to test infrastructure, selectors
(`testID`) wiring, and removal of an e2e smoke test, with no production
logic changes beyond swapping hardcoded `testID` strings for constants.
>
> **Overview**
> Adds a new component-view test suite for `CardHome` that asserts key
navigation targets (Add Funds, asset selection, spending limit,
cashback, metal card), teaser-mode auth redirect, retry behavior, and
logout confirmation.
>
> Refactors card test scaffolding by introducing a seeded
`cardStatePreset`, a `renderCardHomeView` helper with lightweight
navigation route probes, and expanding component-view `Engine` mocks for
card flows.
>
> Standardizes `testID` usage by replacing inline IDs in
`CardAuthentication` and `SpendingLimit` with selector constants, and
removes the old card navbar smoke/e2e spec plus its analytics
expectations.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
63588a6. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )