[pull] main from MetaMask:main#784
Merged
Merged
Conversation
## **Description**
Updates Telegram OAuth client IDs for Flask builds in development, UAT,
and production so each environment points to the deployed Telegram app
configuration.
Adds a config test that pins the deployed Flask Telegram client IDs and
catches accidental drift.
## **Changelog**
CHANGELOG entry: Fixed Telegram login configuration for Flask builds
## **Related issues**
Refs: No linked issue. Configuration update for deployed Flask Telegram
client IDs.
## **Manual testing steps**
```gherkin
Feature: Telegram login client ID configuration
Scenario: Flask Telegram client IDs are pinned
Given the OAuth login handler config tests are run
When the Telegram Flask client ID assertions execute
Then the dev, UAT, and production Flask client IDs match the deployed Telegram app IDs
```
Test command:
```bash
yarn jest app/core/OAuthService/OAuthLoginHandlers/config.test.ts
```
## **Screenshots/Recordings**
N/A - configuration-only change with no UI surface.
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
#### Performance checks (if applicable)
N/A - configuration-only OAuth client ID update.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )