Add an update feature (previously only insert was allowed) but it add…#3
Open
Rebolon wants to merge 1 commit into
Open
Add an update feature (previously only insert was allowed) but it add…#3Rebolon wants to merge 1 commit into
Rebolon wants to merge 1 commit into
Conversation
…s more complexity: should i allow update of all nodes when an id is set or only root element of the json string ? what happens on associative entity (ParamConverter must not remove DB entries, so the controller will have to manage this) ? should i block this feature when this is an HTTP POST call ?
Owner
Author
|
Code smells in initFromRequest: the system to manage an update is correct for Item but falsy for List Don't forget that the aim is to get valid entities, and ParamConverter must not have domain logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s more complexity: should i allow update of all nodes when an id is set or only root element of the json string ? what happens on associative entity (ParamConverter must not remove DB entries, so the controller will have to manage this) ? should i block this feature when this is an HTTP POST call ?