Skip to content

Add an update feature (previously only insert was allowed) but it add…#3

Open
Rebolon wants to merge 1 commit into
masterfrom
feature/update-mode
Open

Add an update feature (previously only insert was allowed) but it add…#3
Rebolon wants to merge 1 commit into
masterfrom
feature/update-mode

Conversation

@Rebolon

@Rebolon Rebolon commented Mar 29, 2018

Copy link
Copy Markdown
Owner

…s more complexity: should i allow update of all nodes when an id is set or only root element of the json string ? what happens on associative entity (ParamConverter must not remove DB entries, so the controller will have to manage this) ? should i block this feature when this is an HTTP POST call ?

…s more complexity: should i allow update of all nodes when an id is set or only root element of the json string ? what happens on associative entity (ParamConverter must not remove DB entries, so the controller will have to manage this) ? should i block this feature when this is an HTTP POST call ?
@Rebolon Rebolon added the wip work in progress label Mar 29, 2018
@Rebolon

Rebolon commented Mar 29, 2018

Copy link
Copy Markdown
Owner Author

Code smells in initFromRequest: the system to manage an update is correct for Item but falsy for List
too much complexity for little bit of interest

Don't forget that the aim is to get valid entities, and ParamConverter must not have domain logic.
So i should not care about the fact that it's a POST or a PUT.
It's up to the Controller to decide if it must update evrything, or only root element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wip work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant