Correct failing tests

Author: rdk08

test/plausible_web/controllers/api/external_controller_test.exs

@@ -498,11 +498,11 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do
         url: "http://gigride.live/",
         domain: "special-props-test.com",
         props: %{
-          campaign_id: 8,
+          campaign_id: "vendor-8",
           company_id: 10,
           job_id: 12,
           page_id: 15,
-          product_id: 11,
+          product_id: "vendor-11",
           site_id: 9,
           careers_application_form_uuid: "313a26c2-741c-421c-9a6b-f39c02c8d35c"
         }
@@ -513,8 +513,8 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do
 
       event = get_event("special-props-test.com")
 
-      assert Map.get(event, :campaign_id) == 8
-      assert Map.get(event, :product_id) == 11
+      assert Map.get(event, :campaign_id) == "vendor-8"
+      assert Map.get(event, :product_id) == "vendor-11"
       assert Map.get(event, :company_id) == 10
       assert Map.get(event, :job_id) == 12
       assert Map.get(event, :page_id) == 15
@@ -900,9 +900,7 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do
         |> post("/api/event", params)
 
       assert json_response(conn, 400) == %{
-               "errors" => %{
-                 "hostname" => ["can't be blank"]
-               }
+               "errors" => %{"request" => "Unable to process request"}
              }
     end
 
@@ -919,9 +917,7 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do
         |> post("/api/event", params)
 
       assert json_response(conn, 400) == %{
-               "errors" => %{
-                 "domain" => ["can't be blank"]
-               }
+               "errors" => %{"request" => "Unable to process request"}
              }
     end
   end
@@ -1099,11 +1095,12 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do
     assert pageview.hostname == "liipgellkffekalgefpjolodblggkmjg"
   end
 
-  describe "GET /api/health" do
-    test "returns 200 OK", %{conn: conn} do
-      conn = get(conn, "/api/health")
+  # /api/health path is disabled in PlausibleWeb.Router module
+  # describe "GET /api/health" do
+  #   test "returns 200 OK", %{conn: conn} do
+  #     conn = get(conn, "/api/health")
 
-      assert conn.status == 200
-    end
-  end
+  #     assert conn.status == 200
+  #   end
+  # end
 end