Skip to content

Remove border in Help Panel active tab#349

Merged
CodyWMitchell merged 1 commit into
RedHatInsights:masterfrom
CodyWMitchell:rhcloud-49084
Jul 22, 2026
Merged

Remove border in Help Panel active tab#349
CodyWMitchell merged 1 commit into
RedHatInsights:masterfrom
CodyWMitchell:rhcloud-49084

Conversation

@CodyWMitchell

@CodyWMitchell CodyWMitchell commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

RHCLOUD-49084

  • Removes the border around Help Panel's active tab

Screenshots

Before:

image image

After:

image image

Anything reviewers should know?


Checklist

  • [x ] Accessibility: color contrast, keyboard nav, screen reader tested (or N/A)
  • All PR checks pass locally (build, lint, test)
  • No unrelated changes included
  • [] (Optional) QE: OUIA changed, test impact, no coverage
  • (Optional) UX: end-user UX modified, designs need sign-off

AI disclosure

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 7f11e814-ed90-4384-b0a6-02b0a9b70334

📥 Commits

Reviewing files that changed from the base of the PR and between ae23d30 and c12e579.

📒 Files selected for processing (1)
  • src/components/HelpPanel/HelpPanelCustomTabs.tsx

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting


Summary by CodeRabbit

  • Style
    • Updated the Help Panel tab appearance by removing boxed tab styling.
    • Tab selection and navigation behavior remain unchanged.

Walkthrough

The PatternFly Tabs component in HelpPanelCustomTabs.tsx no longer receives the isBox prop. Tab rendering and selection behavior remain unchanged.

Changes

Help panel tabs

Layer / File(s) Summary
Remove boxed tab styling
src/components/HelpPanel/HelpPanelCustomTabs.tsx
The Tabs component no longer passes isBox; existing tab selection logic remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Accurately describes the only visible change: removing the active tab border in Help Panel.
Description check ✅ Passed Includes the required Description and Screenshots sections with issue link and before/after images.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@jjaquish jjaquish left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodyWMitchell
CodyWMitchell enabled auto-merge (squash) July 21, 2026 13:15
@CodyWMitchell
CodyWMitchell merged commit b5596f4 into RedHatInsights:master Jul 22, 2026
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants