Skip to content

Commit 6d3c8de

Browse files
mkholjuraevmkholjuraev
authored
fix(RHINENG-9035): bulk select all icon fixed (#1182)
1 parent 934544f commit 6d3c8de

7 files changed

Lines changed: 157 additions & 77 deletions

File tree

‎package-lock.json‎

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"@patternfly/react-core": "^5.2.0",
1010
"@patternfly/react-icons": "^5.2.0",
1111
"@patternfly/react-table": "^5.2.0",
12-
"@redhat-cloud-services/frontend-components": "^4.2.4",
12+
"@redhat-cloud-services/frontend-components": "^4.2.8",
1313
"@redhat-cloud-services/frontend-components-notifications": "^4.1.0",
1414
"@redhat-cloud-services/frontend-components-remediations": "^3.2.11",
1515
"@redhat-cloud-services/frontend-components-translations": "^3.2.7",

‎src/PresentationalComponents/Header/__snapshots__/Header.test.js.snap‎

Lines changed: 120 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@ exports[`Header component should render with 1 breadcrumb item and last is activ
44
<DocumentFragment>
55
<section
66
class="pf-v5-l-page-header pf-v5-c-page-header pf-v5-l-page__main-section pf-v5-c-page__main-section pf-m-light"
7+
data-ouia-component-id="OUIA-Generated-RHI/Header-true-7"
78
data-ouia-component-type="undefined-page-header"
9+
data-ouia-safe="true"
810
widget-type="InsightsPageHeader"
911
>
1012
<nav
@@ -37,13 +39,21 @@ exports[`Header component should render with 1 breadcrumb item and last is activ
3739
<div
3840
class="pf-v5-l-split__item"
3941
>
40-
<h1
41-
class="pf-v5-c-title pf-m-2xl"
42-
data-ouia-component-id="OUIA-Generated-Title-4"
43-
data-ouia-component-type="PF5/Title"
44-
data-ouia-safe="true"
45-
widget-type="InsightsPageHeaderTitle"
46-
/>
42+
<div
43+
class="pf-v5-l-flex pf-m-justify-content-space-between"
44+
>
45+
<div
46+
class=""
47+
>
48+
<h1
49+
class="pf-v5-c-title pf-m-2xl"
50+
data-ouia-component-id="OUIA-Generated-RHI/Header-true-8"
51+
data-ouia-component-type="RHI/Header"
52+
data-ouia-safe="true"
53+
widget-type="InsightsPageHeaderTitle"
54+
/>
55+
</div>
56+
</div>
4757
</div>
4858
<div
4959
class="pf-v5-l-split__item pf-m-fill"
@@ -60,7 +70,9 @@ exports[`Header component should render with 2 breadcrumb items and last is acti
6070
<DocumentFragment>
6171
<section
6272
class="pf-v5-l-page-header pf-v5-c-page-header pf-v5-l-page__main-section pf-v5-c-page__main-section pf-m-light"
73+
data-ouia-component-id="OUIA-Generated-RHI/Header-true-11"
6374
data-ouia-component-type="undefined-page-header"
75+
data-ouia-safe="true"
6476
widget-type="InsightsPageHeader"
6577
>
6678
<nav
@@ -121,13 +133,21 @@ exports[`Header component should render with 2 breadcrumb items and last is acti
121133
<div
122134
class="pf-v5-l-split__item"
123135
>
124-
<h1
125-
class="pf-v5-c-title pf-m-2xl"
126-
data-ouia-component-id="OUIA-Generated-Title-6"
127-
data-ouia-component-type="PF5/Title"
128-
data-ouia-safe="true"
129-
widget-type="InsightsPageHeaderTitle"
130-
/>
136+
<div
137+
class="pf-v5-l-flex pf-m-justify-content-space-between"
138+
>
139+
<div
140+
class=""
141+
>
142+
<h1
143+
class="pf-v5-c-title pf-m-2xl"
144+
data-ouia-component-id="OUIA-Generated-RHI/Header-true-12"
145+
data-ouia-component-type="RHI/Header"
146+
data-ouia-safe="true"
147+
widget-type="InsightsPageHeaderTitle"
148+
/>
149+
</div>
150+
</div>
131151
</div>
132152
<div
133153
class="pf-v5-l-split__item pf-m-fill"
@@ -144,7 +164,9 @@ exports[`Header component should render with 3 breadcrumb items and last is acti
144164
<DocumentFragment>
145165
<section
146166
class="pf-v5-l-page-header pf-v5-c-page-header pf-v5-l-page__main-section pf-v5-c-page__main-section pf-m-light"
167+
data-ouia-component-id="OUIA-Generated-RHI/Header-true-13"
147168
data-ouia-component-type="undefined-page-header"
169+
data-ouia-safe="true"
148170
widget-type="InsightsPageHeader"
149171
>
150172
<nav
@@ -233,13 +255,21 @@ exports[`Header component should render with 3 breadcrumb items and last is acti
233255
<div
234256
class="pf-v5-l-split__item"
235257
>
236-
<h1
237-
class="pf-v5-c-title pf-m-2xl"
238-
data-ouia-component-id="OUIA-Generated-Title-7"
239-
data-ouia-component-type="PF5/Title"
240-
data-ouia-safe="true"
241-
widget-type="InsightsPageHeaderTitle"
242-
/>
258+
<div
259+
class="pf-v5-l-flex pf-m-justify-content-space-between"
260+
>
261+
<div
262+
class=""
263+
>
264+
<h1
265+
class="pf-v5-c-title pf-m-2xl"
266+
data-ouia-component-id="OUIA-Generated-RHI/Header-true-14"
267+
data-ouia-component-type="RHI/Header"
268+
data-ouia-safe="true"
269+
widget-type="InsightsPageHeaderTitle"
270+
/>
271+
</div>
272+
</div>
243273
</div>
244274
<div
245275
class="pf-v5-l-split__item pf-m-fill"
@@ -256,7 +286,9 @@ exports[`Header component should render with empty breadcrumb 1`] = `
256286
<DocumentFragment>
257287
<section
258288
class="pf-v5-l-page-header pf-v5-c-page-header pf-v5-l-page__main-section pf-v5-c-page__main-section pf-m-light"
289+
data-ouia-component-id="OUIA-Generated-RHI/Header-true-5"
259290
data-ouia-component-type="undefined-page-header"
291+
data-ouia-safe="true"
260292
widget-type="InsightsPageHeader"
261293
>
262294
<nav
@@ -277,13 +309,21 @@ exports[`Header component should render with empty breadcrumb 1`] = `
277309
<div
278310
class="pf-v5-l-split__item"
279311
>
280-
<h1
281-
class="pf-v5-c-title pf-m-2xl"
282-
data-ouia-component-id="OUIA-Generated-Title-3"
283-
data-ouia-component-type="PF5/Title"
284-
data-ouia-safe="true"
285-
widget-type="InsightsPageHeaderTitle"
286-
/>
312+
<div
313+
class="pf-v5-l-flex pf-m-justify-content-space-between"
314+
>
315+
<div
316+
class=""
317+
>
318+
<h1
319+
class="pf-v5-c-title pf-m-2xl"
320+
data-ouia-component-id="OUIA-Generated-RHI/Header-true-6"
321+
data-ouia-component-type="RHI/Header"
322+
data-ouia-safe="true"
323+
widget-type="InsightsPageHeaderTitle"
324+
/>
325+
</div>
326+
</div>
287327
</div>
288328
<div
289329
class="pf-v5-l-split__item pf-m-fill"
@@ -300,7 +340,9 @@ exports[`Header component should render with header Hello world 1`] = `
300340
<DocumentFragment>
301341
<section
302342
class="pf-v5-l-page-header pf-v5-c-page-header pf-v5-l-page__main-section pf-v5-c-page__main-section pf-m-light"
343+
data-ouia-component-id="OUIA-Generated-RHI/Header-true-3"
303344
data-ouia-component-type="undefined-page-header"
345+
data-ouia-safe="true"
304346
widget-type="InsightsPageHeader"
305347
>
306348
<div
@@ -309,15 +351,23 @@ exports[`Header component should render with header Hello world 1`] = `
309351
<div
310352
class="pf-v5-l-split__item"
311353
>
312-
<h1
313-
class="pf-v5-c-title pf-m-2xl"
314-
data-ouia-component-id="OUIA-Generated-Title-2"
315-
data-ouia-component-type="PF5/Title"
316-
data-ouia-safe="true"
317-
widget-type="InsightsPageHeaderTitle"
354+
<div
355+
class="pf-v5-l-flex pf-m-justify-content-space-between"
318356
>
319-
Hello world
320-
</h1>
357+
<div
358+
class=""
359+
>
360+
<h1
361+
class="pf-v5-c-title pf-m-2xl"
362+
data-ouia-component-id="OUIA-Generated-RHI/Header-true-4"
363+
data-ouia-component-type="RHI/Header"
364+
data-ouia-safe="true"
365+
widget-type="InsightsPageHeaderTitle"
366+
>
367+
Hello world
368+
</h1>
369+
</div>
370+
</div>
321371
</div>
322372
<div
323373
class="pf-v5-l-split__item pf-m-fill"
@@ -334,7 +384,9 @@ exports[`Header component should render with header as empty string 1`] = `
334384
<DocumentFragment>
335385
<section
336386
class="pf-v5-l-page-header pf-v5-c-page-header pf-v5-l-page__main-section pf-v5-c-page__main-section pf-m-light"
387+
data-ouia-component-id="OUIA-Generated-RHI/Header-true-1"
337388
data-ouia-component-type="undefined-page-header"
389+
data-ouia-safe="true"
338390
widget-type="InsightsPageHeader"
339391
>
340392
<div
@@ -343,13 +395,21 @@ exports[`Header component should render with header as empty string 1`] = `
343395
<div
344396
class="pf-v5-l-split__item"
345397
>
346-
<h1
347-
class="pf-v5-c-title pf-m-2xl"
348-
data-ouia-component-id="OUIA-Generated-Title-1"
349-
data-ouia-component-type="PF5/Title"
350-
data-ouia-safe="true"
351-
widget-type="InsightsPageHeaderTitle"
352-
/>
398+
<div
399+
class="pf-v5-l-flex pf-m-justify-content-space-between"
400+
>
401+
<div
402+
class=""
403+
>
404+
<h1
405+
class="pf-v5-c-title pf-m-2xl"
406+
data-ouia-component-id="OUIA-Generated-RHI/Header-true-2"
407+
data-ouia-component-type="RHI/Header"
408+
data-ouia-safe="true"
409+
widget-type="InsightsPageHeaderTitle"
410+
/>
411+
</div>
412+
</div>
353413
</div>
354414
<div
355415
class="pf-v5-l-split__item pf-m-fill"
@@ -366,7 +426,9 @@ exports[`Header component should render without to attribute 1`] = `
366426
<DocumentFragment>
367427
<section
368428
class="pf-v5-l-page-header pf-v5-c-page-header pf-v5-l-page__main-section pf-v5-c-page__main-section pf-m-light"
429+
data-ouia-component-id="OUIA-Generated-RHI/Header-true-9"
369430
data-ouia-component-type="undefined-page-header"
431+
data-ouia-safe="true"
370432
widget-type="InsightsPageHeader"
371433
>
372434
<nav
@@ -393,13 +455,21 @@ exports[`Header component should render without to attribute 1`] = `
393455
<div
394456
class="pf-v5-l-split__item"
395457
>
396-
<h1
397-
class="pf-v5-c-title pf-m-2xl"
398-
data-ouia-component-id="OUIA-Generated-Title-5"
399-
data-ouia-component-type="PF5/Title"
400-
data-ouia-safe="true"
401-
widget-type="InsightsPageHeaderTitle"
402-
/>
458+
<div
459+
class="pf-v5-l-flex pf-m-justify-content-space-between"
460+
>
461+
<div
462+
class=""
463+
>
464+
<h1
465+
class="pf-v5-c-title pf-m-2xl"
466+
data-ouia-component-id="OUIA-Generated-RHI/Header-true-10"
467+
data-ouia-component-type="RHI/Header"
468+
data-ouia-safe="true"
469+
widget-type="InsightsPageHeaderTitle"
470+
/>
471+
</div>
472+
</div>
403473
</div>
404474
<div
405475
class="pf-v5-l-split__item pf-m-fill"

‎src/SmartComponents/AdvisoryDetail/__snapshots__/AdvisoryDetail.test.js.snap‎

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@ exports[`AdvisoryDetail.js Should match the snapshots 1`] = `
44
<DocumentFragment>
55
<section
66
class="pf-v5-l-page-header pf-v5-c-page-header pf-v5-l-page__main-section pf-v5-c-page__main-section pf-m-light"
7+
data-ouia-component-id="OUIA-Generated-RHI/Header-true-1"
78
data-ouia-component-type="advisory-details-page-header"
9+
data-ouia-safe="true"
810
widget-type="InsightsPageHeader"
911
>
1012
<nav
@@ -58,13 +60,21 @@ exports[`AdvisoryDetail.js Should match the snapshots 1`] = `
5860
<div
5961
class="pf-v5-l-split__item"
6062
>
61-
<h1
62-
class="pf-v5-c-title pf-m-2xl"
63-
data-ouia-component-id="OUIA-Generated-Title-1"
64-
data-ouia-component-type="PF5/Title"
65-
data-ouia-safe="true"
66-
widget-type="InsightsPageHeaderTitle"
67-
/>
63+
<div
64+
class="pf-v5-l-flex pf-m-justify-content-space-between"
65+
>
66+
<div
67+
class=""
68+
>
69+
<h1
70+
class="pf-v5-c-title pf-m-2xl"
71+
data-ouia-component-id="OUIA-Generated-RHI/Header-true-2"
72+
data-ouia-component-type="RHI/Header"
73+
data-ouia-safe="true"
74+
widget-type="InsightsPageHeaderTitle"
75+
/>
76+
</div>
77+
</div>
6878
</div>
6979
<div
7080
class="pf-v5-l-split__item pf-m-fill"

‎src/SmartComponents/AdvisorySystems/AdvisorySystemsTable.test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,6 @@ describe('AdvisorySystemsTable.js', () => {
233233
],
234234
onSelect: expect.any(Function),
235235
toggleProps: {
236-
children: ' 1 selected',
237236
'aria-label': 'Select',
238237
'data-ouia-component-type': 'bulk-select-toggle-button'
239238
}

‎src/SmartComponents/Systems/SystemTable.test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,6 @@ describe('SystemsTable', () => {
262262
],
263263
onSelect: expect.any(Function),
264264
toggleProps: {
265-
children: ' 1 selected',
266265
'aria-label': 'Select',
267266
'data-ouia-component-type': 'bulk-select-toggle-button'
268267
}

0 commit comments

Comments
 (0)