Fix publish date filter all option not working (#1189)

Author: leSamo

src/PresentationalComponents/Filters/PublishDateFilter.js

@@ -7,7 +7,7 @@ const publishDateFilter = (apply, currentFilter = {}) => {
     let { public_date: currentValue } = currentFilter;
 
     const filterByPublicDate = value => {
-        apply({ filter: { public_date: (value !== 'all' && value) || '' } });
+        apply({ filter: { public_date: value === 'all' ? '' : value } });
     };
 
     return {
@@ -18,7 +18,7 @@ const publishDateFilter = (apply, currentFilter = {}) => {
                 filterByPublicDate(value);
             },
             items: publicDateOptions,
-            value: currentValue,
+            value: currentValue ?? 'all',
             placeholder: intl.formatMessage(messages.labelsFiltersPublishDatePlaceholder)
         }
     };

src/PresentationalComponents/Filters/PublishDateFilter.test.js

@@ -3,10 +3,10 @@ import publishDateFilter from './PublishDateFilter';
 const apply = jest.fn();
 const currentFilter = { public_date: 'filter' };
 
-describe('PublishDateFitler', () => {
-    it('Should set currentValue to zero and init', () => {
+describe('PublishDateFilter', () => {
+    it('Should set currentValue to "all" by default', () => {
         const response = publishDateFilter(apply);
-        expect(response.filterValues.value).toEqual(undefined);
+        expect(response.filterValues.value).toEqual('all');
         expect(response.label).toEqual('Publish date');
         expect(response.type).toEqual('radio');
     });
@@ -17,10 +17,10 @@ describe('PublishDateFitler', () => {
         expect(apply).toHaveBeenCalledWith({ filter: { public_date: 'testValue' } });
     });
 
-    it('Should call apply with empty string ', () => {
+    it('Should call apply with undefined', () => {
         const response = publishDateFilter(apply);
         response.filterValues.onChange();
-        expect(apply).toHaveBeenCalledWith({ filter: { public_date: '' } });
+        expect(apply).toHaveBeenCalledWith({ filter: { public_date: undefined } });
     });
 });
 /* eslint-enable */