RHINENG-25944: ensure correct encoding of tag filters#1641
Open
dominikvagner wants to merge 2 commits into
Open
RHINENG-25944: ensure correct encoding of tag filters#1641dominikvagner wants to merge 2 commits into
dominikvagner wants to merge 2 commits into
Conversation
dominikvagner
force-pushed
the
tags-filter-fixes
branch
from
034ee5b to
7607619
Compare
dominikvagner
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1641 +/- ##
==========================================
- Coverage 77.58% 77.57% -0.01%
==========================================
Files 103 103
Lines 3266 3278 +12
Branches 728 730 +2
==========================================
+ Hits 2534 2543 +9
- Misses 655 658 +3
Partials 77 77 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dominikvagner
force-pushed
the
tags-filter-fixes
branch
from
7607619 to
8658d0a
Compare
This sets the maxWorkers in the Jest config to prevent accidental computer lock-ups/freezes when running tests, because the default is using the maximum of available resources.
This makes sure the global tag filters are correctly URI encoded, only a single encode pass. Previously they could be double encoded which made the API always return no systems.
dominikvagner
force-pushed
the
tags-filter-fixes
branch
from
8658d0a to
48e84cc
Compare
Collaborator
|
FYI the "Advisories Tests › Create a new remediation plan" UI test will likely fail until culled systems can be deleted in patch again. this PR should fix that 🤞 |
xbhouse
reviewed
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes sure the global tag filters are correctly URI encoded, only a
single encode pass. Previously they could be double encoded which made
the API always return no systems.
Associated Jira ticket: #RHINENG-25944
Testing steps
Test out filtering with both the "local" tag filters (in the table toolbar) and with the global filters at the top.
Both of them should now work.