Skip to content

test: reduce filter test runtime#1645

Merged
xbhouse merged 1 commit into
RedHatInsights:masterfrom
xbhouse:reduce-test-time
May 28, 2026
Merged

test: reduce filter test runtime#1645
xbhouse merged 1 commit into
RedHatInsights:masterfrom
xbhouse:reduce-test-time

Conversation

@xbhouse
Copy link
Copy Markdown
Collaborator

@xbhouse xbhouse commented May 27, 2026

Description

Removes unnecessary waits from the filter test helpers. This should reduce the runtime of the "Patch Filters" > "Filter types on Advisories page" UI test.

How to test the PR

UI filter tests shouldn't time out

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.58%. Comparing base (1143e8b) to head (ae5ac1f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1645   +/-   ##
=======================================
  Coverage   77.58%   77.58%           
=======================================
  Files         103      103           
  Lines        3266     3266           
  Branches      734      729    -5     
=======================================
  Hits         2534     2534           
  Misses        655      655           
  Partials       77       77           
Flag Coverage Δ
combined 77.58% <ø> (?)
jest 77.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xbhouse xbhouse force-pushed the reduce-test-time branch from 9963613 to ae5ac1f Compare May 27, 2026 20:20
@xbhouse xbhouse marked this pull request as ready for review May 27, 2026 20:33
@xbhouse xbhouse requested a review from a team as a code owner May 27, 2026 20:33
Copy link
Copy Markdown
Collaborator

@swadeley swadeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@swadeley swadeley self-assigned this May 28, 2026
@swadeley
Copy link
Copy Markdown
Collaborator

Hi @xbhouse , " UI/FilterTypePatch" still fails but that is because the base system which is in the Workspace called "TestSpace" is not in the results, in the table. But it is there when the test is still at the filter by operating stage of the test.

@xbhouse
Copy link
Copy Markdown
Collaborator Author

xbhouse commented May 28, 2026

Hi @xbhouse , " UI/FilterTypePatch" still fails but that is because the base system which is in the Workspace called "TestSpace" is not in the results, in the table. But it is there when the test is still at the filter by operating stage of the test.

that's expected @swadeley, the workspace filtering should be fixed once Inventory reverts the breaking changes. this PR only affects the "Filter types on Advisories page" test (reduces the runtime of that test from about 4 minutes to 1.5 minutes) and we shouldn't see timeouts like this anymore

@xbhouse xbhouse merged commit 8fe875a into RedHatInsights:master May 28, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants