Skip to content

test: reduce filter test runtime #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xbhouse merged 1 commit into from
May 28, 2026
+1 −9
Merged

test: reduce filter test runtime #1645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions playwright/UI/FilterTypePatch.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,6 @@ test('Verify filter contents', async ({ page, systems }) => {

await navigateToSystems(page);
await closePopupsIfExist(page);
await openConditionalFilter(page);
await resetFilters(page);

await test.step('Verify "Operating system" filter contents', async () => {
await openConditionalFilter(page);
Expand Down
8 changes: 1 addition & 7 deletions playwright/test-utils/helpers/filters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,13 +169,7 @@ export const applyFilterSubtype = async (
'i',
),
});
let openedViaGroupFilter = false;
try {
await groupFilterBtn.waitFor({ state: 'visible', timeout: 10000 });
openedViaGroupFilter = true;
} catch {
// Group filter not visible; will try Menu toggle or Options menu
}
const openedViaGroupFilter = await groupFilterBtn.isVisible();
if (openedViaGroupFilter) {
await groupFilterBtn.click();
} else if (subtype.inputType !== 'search') {
Expand Down
Loading