fix(evaluator): send CVEs with Important severity instead of High

[jdobes]

High is not used in Red Hat severity ranking

Secure Coding Practices Checklist GitHub Link

• https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

• Input Validation
• Output Encoding
• Authentication and Password Management
• Session Management
• Access Control
• Cryptographic Practices
• Error Handling and Logging
• Data Protection
• Communication Security
• System Configuration
• Database Security
• File Management
• Memory Management
• General Coding Practices

Summary by Sourcery

Adjust vulnerability evaluation and reporting to use Red Hat "Important" severity instead of a non-existent "High" severity.

Bug Fixes:

• Count CVEs with impact_id 5 as Important rather than using impact_id 6 for a High severity that is not part of Red Hat rankings.
• Update inventory view payloads to report the number of Important CVEs instead of High severity CVEs.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts evaluator and inventory view reporting to treat Red Hat 'Important' CVEs (impact_id=5) as the second-highest severity instead of 'High', and renames related counters and payload fields accordingly.

Sequence diagram for updated CVE severity counting and reporting

sequenceDiagram
    participant EvaluatorProcessor
    participant CveCache
    participant Utils

    loop sys_vuln_rows
        EvaluatorProcessor->>CveCache: get(cve)
        alt impact_id == 7
            EvaluatorProcessor->>EvaluatorProcessor: critical_cves++
        else impact_id == 5
            EvaluatorProcessor->>EvaluatorProcessor: important_cves++
        end
    end

    EvaluatorProcessor->>Utils: send_inventory_views(rh_account_id, total_cves, critical_cves, important_cves, cves_with_security_rules, cves_with_known_exploits)

Loading

File-Level Changes

Change	Details	Files
Update system evaluation logic to count and forward Important-severity CVEs instead of High-severity CVEs.	Rename the local counter from high_severity_cves to important_cves in the system evaluation routine. Change the impact_id check from 6 to 5 when incrementing the Important-severity CVE counter. Pass the new important_cves value into the _mark_system_evaluated call and downstream metrics/event reporting.	evaluator/processor.py
Update inventory view sending utility to use Important-severity terminology and payload field name.	Rename the function parameter from high_severity_cves to important_cves in the inventory views sender. Adjust the emitted event payload to send important_cves instead of high_severity_cves in the data structure.	common/utils.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider replacing the hard-coded impact_id values (7 for critical, 5 for important) with named constants or an enum to make the severity mapping self-documenting and less error-prone if the ranking ever changes.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider replacing the hard-coded impact_id values (7 for critical, 5 for important) with named constants or an enum to make the severity mapping self-documenting and less error-prone if the ranking ever changes.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[pindo696]

/lgtm