[DO NOT MERGE] fix: prevent widget drawer from auto-opening, fix dashboard rename updating UI#346
Open
OlhaTmlk wants to merge 5 commits into
Open
[DO NOT MERGE] fix: prevent widget drawer from auto-opening, fix dashboard rename updating UI#346OlhaTmlk wants to merge 5 commits into
OlhaTmlk wants to merge 5 commits into
Conversation
Contributor
Author
|
/ok-to-test |
OlhaTmlk
changed the title
Contributor
Author
|
/retest |
justinorringer
left a comment
justinorringer
left a comment
Contributor
There was a problem hiding this comment.
Looking good, just one question.
| useEffect(() => { | ||
| setDrawerExpanded(true); | ||
| }, []); | ||
| if (isLoaded) { |
Contributor
There was a problem hiding this comment.
Why is this condition needed? Is there a better place to maintain this state than a deep child component?
Contributor
Author
There was a problem hiding this comment.
Agree, moved the auto-open logic up to GridLayout. Now it's handled in the useEffect for initial load and in handleTemplateChange when the last widget is removed
justinorringer
approved these changes
Jun 22, 2026
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
OlhaTmlk
force-pushed
the
hide-widgets
branch
3 times, most recently
from
05d2267 to
be1b15f
Compare
OlhaTmlk
force-pushed
the
hide-widgets
branch
3 times, most recently
from
09d84f9 to
6378061
Compare
Contributor
Author
|
/retest |
OlhaTmlk
force-pushed
the
hide-widgets
branch
2 times, most recently
from
80a2952 to
c578d74
Compare
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
|
All PipelineRuns for this commit have already succeeded. Use |
Contributor
Author
|
/test |
OlhaTmlk
force-pushed
the
hide-widgets
branch
3 times, most recently
from
51b533d to
4dd4238
Compare
OlhaTmlk
changed the title
Contributor
Author
|
PR is currently being debugged. DO NOT MERGE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exact: truefor link name matching and add explicit waits to avoid flaky assertionsRHCLOUD47876
Changes
Widget drawer auto-open fix (GridLayout.tsx)
LayoutEmptyStatenow accepts an isLoaded prop and only opens the drawer after the template has finished loadingDashboard rename fix
GenericDashboardPagewrapped with a Jotai Provider using the shared store so atoms resolve correctlyrenameDashboardTemplateto returnjsoninstead ofjson.datato match the actual API response shapeE2e tests
exact: truein link selectors to prevent partial name matches causing wrong navigation