feat(zola): move site to Zola#381
Conversation
Signed-off-by: Laura Santamaria <nimbinatus@users.noreply.github.com>
|
I'll be adding the GitHub Actions setup for publication next :) |
…stem Signed-off-by: Laura Santamaria <nimbinatus@users.noreply.github.com>
|
I'll add previews in a future PR (issue ref #382 ) This final commit adds the GitHub Actions build for the repository. You can review a preview at https://nimbinatus.com/RedHatOfficial.github.io/ from my fork. (Note that, to get it to preview correctly for my fork, I had to modify the build flags at https://github.com/nimbinatus/RedHatOfficial.github.io/blob/dev/.github/workflows/build.yml#L30 if you're reviewing the differences between the two CI pipelines; there's also a preview attempt at the bottom at https://github.com/nimbinatus/RedHatOfficial.github.io/blob/dev/.github/workflows/build.yml#L45-L50 that is not working and thus not in this PR). Also, note that, in this live preview from my fork, the fonts aren't loading. I think the Red Hat fonts are specifically scoped to only run on github.io pages (or perhaps specifically allowed RedHatOfficial.github.io?), so it should load when merged and built for this repo. |
… v1) with data patch Tera v1 does not allow an alphabetical sort of an array. There's an open PR, but it's not merged yet. Tera v2 will update with that, but that's not in Zola yet. This patch fixes it for now. Signed-off-by: Laura Santamaria <nimbinatus@users.noreply.github.com>
| {% else %} | ||
| <td></td> | ||
| {% endif %} | ||
| {% if project.twitterURL and project.twitterHandle %} |
There was a problem hiding this comment.
not blocking, but twitterURL can be deduced from twitterHandle, so this could be simplified later.
There was a problem hiding this comment.
Yeah, I'm going to leave it, but I'd like to completely take this out and have better logic allowing for more social platforms...
|
So i think that's mostly good to go. I didn't look at the CSS, but the rest look good. There is a few things later to improve (eg, plenty of folks have moved out of X/Twitter), but that is future improvement for future us. |
mscherer
left a comment
mscherer
left a comment
There was a problem hiding this comment.
Should be good minus some small fixes
…o on featured list Signed-off-by: Laura Santamaria <nimbinatus@users.noreply.github.com>
…l host Signed-off-by: Laura Santamaria <nimbinatus@users.noreply.github.com>
… review Signed-off-by: Laura Santamaria <nimbinatus@users.noreply.github.com>
Signed-off-by: Laura Santamaria <nimbinatus@users.noreply.github.com>
…eview Signed-off-by: Laura Santamaria <nimbinatus@users.noreply.github.com>
feat(zola): move site to Zola
3 participants
This PR moves the site to Zola, a static site generator, to fix the build issues and to allow the site to function without Javascript.
Related issue
Testing instructions
As noted in the new readme:
To build and run this project in your local dev environment, first install Rust and Zola. Then, run
cd site zola serveGo to the URL for the webserver (likely
localhost:1111) to explore the site.Browser requirements (for page updates)
Your updates should work in the following environments:
Note that some features, like the fade-in for the back to top button, may not function, but they should all have fallbacks.
Also, please note that the search and filter functions will disappear with a note if Javascript is disabled.
Ready-for-merge Checklist
Check off items as they are completed. Feel free to delete items if they are not applicable.
Merging
Please squash when merging and ensure your commit message uses conventional commit formatting.