Fix footer link conditional checks#399
Closed
nikhildixit-321 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect conditional checks for featured project footer links in templates/index.html.
bug:#396
The Twitter/X and GitHub footer links were incorrectly checking feature.website before rendering. This caused the links to be hidden when a project had a Twitter or GitHub URL but no website configured.
Changes
Replaced feature.website with feature.twitter for the X account link condition
Replaced feature.website with feature.github for the GitHub repo link condition
Result
Each footer link now renders based on its own corresponding field.