fix: use module constant for default disk serial command

josemacassan · claude · josemacassan · commit cbaa71392b1c · 2026-06-03T10:51:40.000+02:00
Fixes B008 ruff violation by using _DEFAULT_DISK_SERIAL_COMMAND
instead of calling shlex.split() in function argument default.

Co-Authored-By: Claude Sonnet 4.5 &lt;noreply@anthropic.com&gt;
Signed-off-by: Jose Manuel Castano &lt;joscasta@redhat.com&gt;
diff --git a/utilities/storage.py b/utilities/storage.py
@@ -687,7 +687,7 @@ def run_command_on_vm_and_check_output(
     )
 
 
-def assert_disk_serial(vm, command=shlex.split("sudo ls /dev/disk/by-id")):
+def assert_disk_serial(vm, command=_DEFAULT_DISK_SERIAL_COMMAND):
     assert (
         HOTPLUG_DISK_SERIAL
         in run_ssh_commands(host=vm.ssh_exec, commands=command, wait_timeout=TIMEOUT_2MIN, sleep=TIMEOUT_5SEC)[0]

Original file line number	Diff line number	Diff line change
`@@ -687,7 +687,7 @@ def run_command_on_vm_and_check_output(`
`687`	`687`	`)`
`688`	`688`
`689`	`689`
`690`		`-def assert_disk_serial(vm, command=shlex.split("sudo ls /dev/disk/by-id")):`
	`690`	`+def assert_disk_serial(vm, command=_DEFAULT_DISK_SERIAL_COMMAND):`
`691`	`691`	`assert (`
`692`	`692`	`HOTPLUG_DISK_SERIAL`
`693`	`693`	`in run_ssh_commands(host=vm.ssh_exec, commands=command, wait_timeout=TIMEOUT_2MIN, sleep=TIMEOUT_5SEC)[0]`