CherryPicked: [cnv-4.22] [Storage] Automate testing of predictable PVC/DV names after VM restore (#5187)

Cherry-pick from `main` branch, original PR:
#4780, PR
owner: acinko-rh

Signed-off-by: Adam Cinko <vsibirsk@redhat.com>
Co-authored-by: Adam Cinko <vsibirsk@redhat.com>
Co-authored-by: Meni Yakove <441263+myakove@users.noreply.github.com>

Author: 3 people

tests/storage/snapshots/conftest.py

@@ -8,6 +8,7 @@
 import pytest
 from ocp_resources.datavolume import DataVolume
 from ocp_resources.role_binding import RoleBinding
+from ocp_resources.virtual_machine_restore import VirtualMachineRestore
 from ocp_resources.virtual_machine_snapshot import VirtualMachineSnapshot
 from pyhelper_utils.shell import run_ssh_commands
 
@@ -104,3 +105,33 @@ def file_created_during_snapshot(windows_vm_for_snapshot, windows_snapshot):
     run_ssh_commands(host=windows_vm_for_snapshot.ssh_exec, commands=cmd, wait_timeout=TIMEOUT_2MIN, sleep=TIMEOUT_5SEC)
     windows_snapshot.wait_snapshot_done(timeout=TIMEOUT_10MIN)
     windows_vm_for_snapshot.stop(wait=True)
+
+
+@pytest.fixture()
+def source_volume_name_for_predictable_name_restore(rhel_vm_for_snapshot):
+    yield next(
+        volume.name
+        for volume in rhel_vm_for_snapshot.instance.spec.template.spec.volumes
+        if getattr(volume, "dataVolume", None) or getattr(volume, "persistentVolumeClaim", None)
+    )
+
+
+@pytest.fixture()
+def vm_restore_with_predictable_names(
+    admin_client,
+    rhel_vm_for_snapshot,
+    snapshot_with_content,
+):
+    if rhel_vm_for_snapshot.ready:
+        rhel_vm_for_snapshot.stop(wait=True)
+
+    with VirtualMachineRestore(
+        name=f"{rhel_vm_for_snapshot.name}-restored",
+        namespace=rhel_vm_for_snapshot.namespace,
+        vm_name=rhel_vm_for_snapshot.name,
+        snapshot_name=snapshot_with_content[0].name,
+        client=admin_client,
+        volume_restore_policy="PrefixTargetName",
+    ) as vm_restore:
+        vm_restore.wait_restore_done(timeout=TIMEOUT_10MIN)
+        yield vm_restore

tests/storage/snapshots/test_snapshots.py

@@ -264,6 +264,49 @@ def test_restore_same_snapshot_twice(
                     expected_result=expected_output_after_restore(1),
                 )
 
+    @pytest.mark.parametrize(
+        "rhel_vm_name, snapshot_with_content",
+        [
+            pytest.param(
+                {"vm_name": "vm-cnv-16212"},
+                {"number_of_snapshots": 1, "online_vm": False},
+                marks=pytest.mark.polarion("CNV-16212"),
+            ),
+        ],
+        indirect=True,
+    )
+    def test_restore_snapshot_with_predictable_names(
+        self,
+        vm_restore_with_predictable_names,
+        source_volume_name_for_predictable_name_restore,
+    ):
+        """
+        Test restore snapshot where the DV/PVC restored has a predictable name derived from the source vm name and
+        source volume name when `volumeRestorePolicy` is set to `PrefixTargetName`.
+
+        Preconditions:
+            - A VM snapshot (any).
+            - Volume restore policy is set to `PrefixTargetName`.
+
+        Steps:
+            1. Restore the snapshot.
+
+        Expected Results:
+            - The restored DV/PVC name matches the expected predictable name derived from the source vm name and source volume name.
+        """
+
+        restore_status = vm_restore_with_predictable_names.instance.status
+        expected_name = (
+            f"{vm_restore_with_predictable_names.vm_name}-{source_volume_name_for_predictable_name_restore}"[:63]
+        )
+
+        assert restore_status.restores[0].dataVolumeName == expected_name, (
+            f"Restored DV name is '{restore_status.restores[0].dataVolumeName}', expected '{expected_name}'"
+        )
+        assert restore_status.restores[0].persistentVolumeClaim == expected_name, (
+            f"Restored PVC name is '{restore_status.restores[0].persistentVolumeClaim}', expected '{expected_name}'"
+        )
+
 
 @pytest.mark.parametrize(
     "rhel_vm_name, snapshot_with_content",