Walkthrough

Replaces a parametrized HTTP-based Windows DV clone test with a new tier3 test that builds a VM from a registry-backed cloned DV (Windows 2022) including vTPM. Adds fixtures to provision source and cloned DataVolumes from a registry and introduces a Windows 2K22 preference constant.

Changes

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

❌ Failed checks (2 warnings)

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• X
• Mastodon
• Reddit
• LinkedIn

Approvers:

• jpeimer

Reviewers:

• Ahmad-Hafe
• acinko-rh
• dalia-frank
• ema-aka-young
• josemacassan
• jpeimer
• kgoldbla
• kshvaika

• hold
• verified
• wip
• lgtm
• approve

• Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6[1m])

CRITICAL: You MUST post an inline review comment on the first changed line of the first file.
The inline comment should contain the full Test Execution Plan (smoke decision, gating decision, and specific affected tests).
Do NOT submit a blocking review event (REQUEST_CHANGES/APPROVE).
Post a single inline PR comment on Files Changed (non-blocking COMMENT flow).

As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan.
You will post an inline review comment with the test execution plan on the first changed file.
If you fail to run or post a comment, retry.

Analysis Requirements:

1. Examine code changes in each modified file

2. Identify affected code paths, functions, and classes

3. Analyze pytest-specific elements: fixtures (scope, dependencies), parametrization, markers, conftest changes

4. Trace test dependencies through imports, shared utilities, fixture inheritance, fixture teardown, and yield from cleanup in conftest

5. Detect new tests introduced in the PR

6. Utilities and libs impact (when utilities/ or libs/ changes):
   You MUST use shell scripts (rg, git diff) to trace the full impact.
   Follow these sub-steps in order:

   6a. Identify modified symbols: For each changed file under utilities/ or libs/,
   list every modified function or method.
   Example: git diff HEAD~1 --unified=0 -- utilities/hco.py | grep '^[+-]def '

   6b. Find direct callers: Search tests and conftest for each symbol from 6a.
   Example: rg -l 'get_hco_version' tests/

   6c. Trace fixture teardown and cleanup: Find fixtures that reach
   the modified symbol through yield from or context-manager wrappers.
   Example: rg -l 'yield from.*enable_common_boot|def.*enable_common_boot' tests/

   6d. Trace same-file callers: In each changed file, find other functions
   whose body calls a modified symbol (including code after yield
   in @contextmanager helpers).
   Example: rg 'get_hco_version|enable_common_boot' utilities/hco.py

   6e. Expand transitively: If function A calls modified B, then
   tests/fixtures that call A are affected — even when the test body
   never imports B directly.

   Do NOT limit impact to tests that import the modified symbol only.

7. Smoke test impact: Intersect the affected set from step 6 with smoke-marked tests.
   Run: rg -l '@pytest.mark.smoke' tests/
   VERIFY the above command returned actual file paths before concluding False.
   Set True if either condition is met:

   • a smoke-marked file appears in the affected set from 6b-6e, OR
   • any conftest.py in the smoke test's parent-directory hierarchy (up to repo root)
     imports or calls a modified utilities/libs symbol — including autouse fixtures
     that depend on modified functions. ALL tests in that directory and below are affected.
     Example check: for each smoke_file, scan dirname(smoke_file)/conftest.py,
     dirname(dirname(smoke_file))/conftest.py, etc. for modified symbol imports
     and autouse fixtures that depend on modified symbols.

8. Gating test impact: Intersect the affected set from step 6 with gating-marked tests.
   Run: rg -l '@pytest.mark.gating' tests/
   Set True if a gating-marked file also appears in the affected set from 6b-6e.
   Utilities/libs changes often affect gating tests without affecting smoke tests.
   Do NOT stop analysis after concluding Run smoke tests: False.

Output rules:
Do NOT include analysis step numbers (1-8) in your visible output.

Your deliverable:
Your inline informational comment will be based on the following requirements:

Test Execution Plan

• Run smoke tests: True / False — If True, state the dependency path (test → fixture → changed symbol). True ONLY with a verified path.
• Run gating tests: True / False — If True, state the dependency path. True if any gating-marked test is in the affected set.
• Affected tests to run (required when utilities/, libs/, or shared conftest changes — list concrete paths even when smoke is False)

Use these formats:

• path/to/test_file.py - When the entire test file needs verification
• path/to/test_file.py::TestClass::test_method - When specific test(s) needed
• path/to/test_file.py::test_function - When specific test(s) needed
• -m marker - When a marker covers multiple affected tests (e.g. -m gating only if ALL gating tests in scope need run)
• Tag each listed test or group with its marker when not obvious, e.g. (gating) or (smoke)

Real test commands (MANDATORY when changes affect session/runtime code):

When the affected code runs at session/collection time (conftest fixtures, pytest plugins,
config hooks, session-scoped setup) or modifies runtime behavior that unit tests mock away,
you MUST include concrete pytest commands the PR author must run on a real cluster
to verify the change works end-to-end. Include:

• A command for the error/fix path (the scenario the PR fixes)
• A command for the happy path (regression: the normal case still works)
• Use lightweight tests (e.g., --collect-only for startup failures,
  a single small test for runtime behavior)
  If the PR only changes test logic (not utilities/libs/conftest), the affected test
  paths themselves serve as the real test commands — no separate section needed.

Example output for a session-startup fix:

**Real tests (cluster required)**
Error path (the fix):
`pytest tests/storage/.../test_foo.py --storage-class-matrix=nonexistent-sc --collect-only`
Expected: ValueError with clear message, not IndexError

Happy path (regression):
`pytest tests/storage/.../test_foo.py --storage-class-matrix=<valid-sc> -k test_bar`
Expected: session starts normally

Guidelines:

• Include tests affected directly OR via fixture setup/teardown, yield from cleanup, or transitive utility call chains (caller calls modified helper)
• Use a full file path only if ALL tests in that file require verification
• Use file path + test name when only specific tests use an affected fixture or utility wrapper (preferred for partial file impact)
• If a test marker can cover multiple files/tests, provide the marker
• Balance coverage vs over-testing - Keep descriptions minimal
• Example: if leaf helper foo() changes, include tests whose fixture teardown calls wrapper bar() where bar() calls foo(), even when the test body only imports an unrelated symbol from the same utilities module

Hardware-Related Checks (SR-IOV, GPU, DPDK):

When PR modifies fixtures for hardware-specific resources:

• Collection Safety: Fixtures MUST have existence checks (return None when hardware unavailable)
• Test Plan: MUST verify both WITH and WITHOUT hardware:
  • Run affected tests on cluster WITH hardware
  • Verify collection succeeds on cluster WITHOUT hardware

CRITICAL WORKFLOW COMPLETION RULES:

When responding to this test execution plan request, you MUST follow these rules EXACTLY:

1. YOUR ONLY DELIVERABLE: Post one non-blocking inline comment containing the test execution plan on the first changed line
2. THEN STOP IMMEDIATELY - Do NOT generate any additional response
3. FALLBACK ONLY: If inline comment API calls fail after retrying, post as a regular PR comment
4. SILENCE = SUCCESS: After successfully submitting the review, your task is complete. No confirmation needed.

ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):

• ❌ Do NOT post acknowledgment messages like "Test execution plan posted", "Review posted successfully", "I've successfully posted"
• ❌ Do NOT mention review IDs, URLs, or confirmation of posting in the PR thread
• ❌ Do NOT add any follow-up comments after submitting the review
• ❌ Do NOT reply to confirm task completion
• ❌ Do NOT explain what you did - just do it and stop

Remember: The pull request review is visible to users. Additional comments are redundant noise.

CRITICAL — Verification rules for smoke and gating decisions:
- For each True decision, you must have traced a concrete path: test file → fixture → utility function → modified symbol.
- Do NOT assume impact based on scope, file proximity, or infrastructure-sounding names.
Only set True when you trace a concrete path through steps 6a-6e, then 7 or 8.
WRONG: "utilities/hco.py changed → run smoke" (no traced dependency path)
WRONG: "Run smoke tests: False" with no affected-test list when gating tests use the changed utility
RIGHT: "Run smoke tests: False, Run gating tests: True" plus tests/.../test_foo.py::TestBar::test_baz (gating)
RIGHT: "Smoke test X uses fixture Y → wrapper Z → changed function W in utilities/hco.py"

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Check smoke/gating markers in tests/storage/cdi_clone/ ==="
rg '`@pytest.mark.smoke`|`@pytest.mark.gating`|`@pytest.mark.tier`' tests/storage/cdi_clone/ -n

echo ""
echo "=== Find all usages of WINDOWS_2K22_PREFERENCE ==="
rg 'WINDOWS_2K22_PREFERENCE' -n

echo ""
echo "=== Find smoke-marked test files ==="
rg -l '`@pytest.mark.smoke`' tests/ | head -30

echo ""
echo "=== Find gating-marked test files ==="
rg -l '`@pytest.mark.gating`' tests/ | head -30

echo ""
echo "=== Check if any gating tests import from utilities/constants.py or use WINDOWS_2K22_PREFERENCE ==="
rg -l '`@pytest.mark.gating`' tests/ | xargs -I{} grep -l 'WINDOWS_2K22_PREFERENCE' {} 2>/dev/null || echo "No gating test uses WINDOWS_2K22_PREFERENCE"

echo ""
echo "=== Check conftest hierarchy for smoke tests that import WINDOWS_2K22_PREFERENCE ==="
# Check conftest.py files in cdi_clone hierarchy
for f in tests/storage/cdi_clone/conftest.py tests/storage/conftest.py tests/conftest.py conftest.py; do
  if [ -f "$f" ]; then
    echo "--- $f ---"
    grep -n 'WINDOWS_2K22_PREFERENCE\|smoke\|gating' "$f" || echo "(no match)"
  fi
done

echo ""
echo "=== Check markers on the new test ==="
rg 'tier|smoke|gating|vtpm|cloned_dv' tests/storage/cdi_clone/test_clone.py -n -A2 -B2

Length of output: 6114

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Get the PR diff to find first changed line position in the first file
# First, get commits on the PR to find base/head SHAs
gh pr view 4571 --repo RedHatQE/openshift-virtualization-tests --json headRefOid,baseRefOid

echo ""
echo "=== Get diff to find first changed line ==="
gh api repos/RedHatQE/openshift-virtualization-tests/pulls/4571/files --jq '.[0] | {filename, patch: .patch[0:500]}'

Length of output: 1204

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Post inline PR review comment on first changed line of first file
gh api \
  --method POST \
  repos/RedHatQE/openshift-virtualization-tests/pulls/4571/comments \
  --field body='**Test Execution Plan**

- **Run smoke tests: False** — The smoke test in `tests/storage/cdi_clone/test_clone.py` (`test_clone_from_block_to_fs_using_dv_template`, s390x) does not use the new Windows fixtures (`source_dv_windows_registry_scope_function`, `cloned_windows_dv_from_registry_scope_function`) or the new `WINDOWS_2K22_PREFERENCE` constant. No conftest in the hierarchy imports these new symbols.

- **Run gating tests: False** — The gating tests in `test_clone.py` (`test_successful_vm_restart_with_cloned_dv`, CNV-3545 parametrized, CNV-5607) do not depend on the new Windows fixtures or the new constant. No other gating-marked file traces through `WINDOWS_2K22_PREFERENCE` → `create_windows2022_vm_with_vtpm`.

**Affected tests to run:**

- `tests/storage/cdi_clone/test_clone.py::test_successful_vm_from_cloned_dv_windows` (tier3) — new test exercising the new fixtures and `WINDOWS_2K22_PREFERENCE` constant end-to-end' \
  --field commit_id='b7faa5ca19fbf2ec9e3e29f151cc3c5d5072112a' \
  --field path='tests/storage/cdi_clone/conftest.py' \
  --field position=5

Length of output: 4997

tests/storage/test_hotplug.py

tests/storage/conftest.py