Skip to content

CherryPicked: [cnv-4.22] net, tests, stuntime: Add remaining l2bridge migration stuntime scenarios#5130

Merged
rnetser merged 1 commit into
cnv-4.22from
CherryPicked-stuntime_add_l2bridge_scenarios-mtQZR
Jun 8, 2026
Merged

CherryPicked: [cnv-4.22] net, tests, stuntime: Add remaining l2bridge migration stuntime scenarios#5130
rnetser merged 1 commit into
cnv-4.22from
CherryPicked-stuntime_add_l2bridge_scenarios-mtQZR

Conversation

@cnv-tests-github-webhook-dollierp

Copy link
Copy Markdown

Cherry-pick from main branch, original PR: #5026, PR owner: Anatw

…rios (#5026)

##### Short description:
Complete L2 bridge stuntime coverage for both IP families.

##### More details:

##### What this PR does / why we need it:
Add remaining stuntime measurement tests for Linux bridge with both IPv4
and IPv6 coverage, through different migration directions.

##### Which issue(s) this PR fixes:

##### Special notes for reviewer:
- Single parametrized class with class-level l2_bridge_ip_family
parametrize to group all scenarios per IP family. VMs depend on
l2_bridge_ip_family so they're recreated per group, giving each IP
family fresh VMs with clean network state (4 VMs total).
- The client VM's affinity towards the server (last client migration
scenario) is not cleared before server migration tests — server affinity
is set independently and the client's affinity has no effect on server
scheduling for this matter.
- Add disableContainerInterface=True to the Linux bridge NAD to match
the documented configuration and let kubevirt manage the interface
directly during migration.

##### jira-ticket:
https://redhat.atlassian.net/browse/CNV-80577

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Tests**
* Enhanced L2 bridge migration test coverage with parameterized IPv4 and
IPv6 scenarios.
  * Enabled all migration stuntime measurement tests to run by default.
* Improved test configuration with explicit VM placement control across
migration scenarios.
* Expanded stuntime measurement testing with multiple scenario
variations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: ‪Anat Wax <awax@redhat.com>
@openshift-virtualization-qe-bot-5

Copy link
Copy Markdown

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (approvers only)
  • /hold cancel - Unblock PR merging
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest verify-bugs-are-open - verify-bugs-are-open
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. LGTM Count: Minimum 2 /lgtm from reviewers
  3. Status Checks: All required status checks must pass
  4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
  5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

  • EdDev
  • rnetser

Reviewers:

  • Anatw
  • EdDev
  • azhivovk
  • frenzyfriday
  • nirdothan
  • orelmisan
  • rnetser
  • servolkov
  • yossisegev
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
AI Features
  • Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6[1m])

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

@Anatw

Anatw commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

/build-and-push-container

@openshift-virtualization-qe-bot-2

Copy link
Copy Markdown
Contributor

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5130 published

@Anatw

Anatw commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

/verified

Tested on bm03-tlv2
Openshift version: 4.22.0-rc.2
CNV version: 4.22.0
HCO image: brew.registry.redhat.io/rh-osbs/iib:1141649
openshift-virtualization-tests-runner/5568
PYTEST_PARAMS: -s -o log_cli=true -m tier3 --jira --cluster-sanity-skip-storage-check tests/network/l2_bridge/migration_stuntime/
==== 12 passed, 1 deselected, 85 warnings in 2326.54s (0:38:46) ====

@Anatw

Anatw commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

/retest verify-bugs-are-open

@Anatw

Anatw commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

/retest verify-bugs-are-open

@Anatw

Anatw commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

/check-can-merge

@rnetser

rnetser commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

/approve
/lgtm

@rnetser rnetser merged commit ea7342d into cnv-4.22 Jun 8, 2026
21 checks passed
@rnetser rnetser deleted the CherryPicked-stuntime_add_l2bridge_scenarios-mtQZR branch June 8, 2026 14:05
@openshift-virtualization-qe-bot-3

Copy link
Copy Markdown
Contributor

Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-5130.

@openshift-virtualization-qe-bot-3

Copy link
Copy Markdown
Contributor

New container for quay.io/openshift-cnv/openshift-virtualization-tests:cnv-4.22 published

josemacassan pushed a commit to josemacassan/openshift-virtualization-tests that referenced this pull request Jun 15, 2026
… migration stuntime scenarios (RedHatQE#5130)

Cherry-pick from `main` branch, original PR:
RedHatQE#5026, PR
owner: Anatw

Signed-off-by: ‪Anat Wax <awax@redhat.com>
Co-authored-by: ‪Anat Wax <awax@redhat.com>
Signed-off-by: Jose Manuel Castano <joscasta@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants