Skip to content

CherryPicked: [cnv-4.22] net: NAD live update VM localnet test#5137

Merged
rnetser merged 1 commit into
cnv-4.22from
CherryPicked-nad-ref-change-localnet-tests-bG9Da
Jun 11, 2026
Merged

CherryPicked: [cnv-4.22] net: NAD live update VM localnet test#5137
rnetser merged 1 commit into
cnv-4.22from
CherryPicked-nad-ref-change-localnet-tests-bG9Da

Conversation

@cnv-tests-github-webhook-dollierp

@cnv-tests-github-webhook-dollierp cnv-tests-github-webhook-dollierp Bot commented Jun 5, 2026

Copy link
Copy Markdown

Cherry-pick from main branch, original PR: #5039, PR owner: azhivovk

@azhivovk
net: NAD live update VM localnet test (#5039)
012019d 
##### What this PR does / why we need it:
Implements the NAD reference change test for localnet: verifies that a
running VM can switch its secondary localnet network from one VLAN to
another without rebooting, and that TCP connectivity is established on
the new VLAN.

##### Which issue(s) this PR fixes: -

##### Special notes for reviewer:
Usage of shared localnet setup: NNCP and localnet CUDN (as CUDN-VLAN-A)
Includes move of shared helpers to be used in several packages like
upcoming metrics nad ref change test.

##### jira-ticket: https://redhat.atlassian.net/browse/CNV-80573
<!-- full-ticket-url needs to be provided. This would add a link to the
pull request to the jira and close it when the pull request is merged
If the task is not tracked by a Jira ticket, just write "NONE".
-->

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Tests**
* Reorganized network connectivity test helpers for better code
organization and reusability.
* Added new test fixtures for localnet network configuration and
baseline connectivity validation.
* Enhanced test coverage with configurable runtime commands and improved
VM provisioning capabilities.

* **Refactoring**
* Consolidated network interface naming constants across test modules
for consistency.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Asia Khromov <azhivovk@redhat.com>
Merged
@openshift-virtualization-qe-bot-5

openshift-virtualization-qe-bot-5 commented Jun 5, 2026

Copy link
Copy Markdown

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (approvers only)
  • /hold cancel - Unblock PR merging
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest verify-bugs-are-open - verify-bugs-are-open
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. LGTM Count: Minimum 2 /lgtm from reviewers
  3. Status Checks: All required status checks must pass
  4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
  5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

  • EdDev
  • rnetser

Reviewers:

  • Anatw
  • EdDev
  • azhivovk
  • frenzyfriday
  • nirdothan
  • orelmisan
  • rnetser
  • servolkov
  • yossisegev
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
AI Features
  • Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6[1m])

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

@rnetser

rnetser commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

/approve
/lgtm

frenzyfriday
frenzyfriday approved these changes Jun 9, 2026
View reviewed changes

@frenzyfriday frenzyfriday left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yossisegev

yossisegev commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

/retest verify-bugs-are-open

@azhivovk

azhivovk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

/verified
Dual-stack BM with cnv-4.22:
uv run pytest --verbose -rs -s -o log_cli=true --leftovers-collector --tb=native --skip-deprecated-api-test --cluster-sanity-skip-storage-check tests/network/localnet/nad_ref_change
Result: 1 passed, 1 deselected, 52 warnings, 4 subtests passed in 666.32s (0:11:06)

@rnetser rnetser merged commit 7c0298c into cnv-4.22 Jun 11, 2026
22 checks passed
@rnetser rnetser deleted the CherryPicked-nad-ref-change-localnet-tests-bG9Da branch June 11, 2026 12:16
@openshift-virtualization-qe-bot-2

openshift-virtualization-qe-bot-2 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

New container for quay.io/openshift-cnv/openshift-virtualization-tests:cnv-4.22 published

josemacassan pushed a commit to josemacassan/openshift-virtualization-tests that referenced this pull request Jun 15, 2026
@cnv-tests-github-webhook-dollierp @azhivovk @josemacassan
CherryPicked: [cnv-4.22] net: NAD live update VM localnet test (RedHa…
516be6a 
…tQE#5137)

Cherry-pick from `main` branch, original PR:
RedHatQE#5039, PR
owner: azhivovk

Signed-off-by: Asia Khromov <azhivovk@redhat.com>
Co-authored-by: Asia Khromov <azhivovk@redhat.com>
Signed-off-by: Jose Manuel Castano <joscasta@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azhivovk azhivovk Awaiting requested review from azhivovk
@yossisegev yossisegev Awaiting requested review from yossisegev
@nirdothan nirdothan Awaiting requested review from nirdothan
@orelmisan orelmisan Awaiting requested review from orelmisan
@rnetser rnetser Awaiting requested review from rnetser
@EdDev EdDev Awaiting requested review from EdDev
@Anatw Anatw Awaiting requested review from Anatw
2 more reviewers
@frenzyfriday frenzyfriday frenzyfriday approved these changes
@servolkov servolkov servolkov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@cnv-tests-github-webhook-dollierp cnv-tests-github-webhook-dollierp[bot]

@azhivovk azhivovk

Labels

approved-rnetser branch-cnv-4.22 can-be-merged CherryPicked-from-main lgtm-frenzyfriday lgtm-rnetser lgtm-servolkov needs-rebase sig-network size/L tox:verify-tc-requirement-polarion:passed D/S Testing verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-virtualization-qe-bot-5 @rnetser @yossisegev @azhivovk @openshift-virtualization-qe-bot-2 @frenzyfriday @servolkov @openshift-virtualization-qe-bot