[Storage] DV stop status functions#5204
Open
acinko-rh wants to merge 3 commits into
Open
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughIntroduces ChangesDataVolume Stop-Status Helpers and Fixture Wiring
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsLinked repositories: Your configuration references 1 linked repositories, but your current plan allows 0. Analyzed ``, skipped Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
/wip |
openshift-virtualization-qe-bot-2
requested review from
ema-aka-young and
kshvaika
openshift-virtualization-qe-bot
added
the
tox:verify-tc-requirement-polarion:running
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-4
changed the title
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:passed
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/storage/utils.py`:
- Around line 550-584: The dv_stop_status_not_converging closure is missing a
Google-style docstring and uses a hardcoded 300-second timeout; update the
function dv_stop_status_not_converging to include a full Google-format docstring
with Args, Returns, and Side effects sections, and replace the literal 300 with
the existing TIMEOUT_5MIN constant (imported from utilities.constants) in the
inner function’s timeout check; keep the LOGGER.error f-string as-is (G004 is a
known false positive per project guidelines).
- Around line 533-547: Add a Google-style docstring to
dv_stop_status_after_three_restarts that documents its purpose, arguments,
return value, and side effect (it logs an error when restartCount > 3);
specifically include an Args section describing parameter dv (DataVolume) and
that it reads dv.instance.status.restartCount, a Returns section stating it
returns True to stop waiting when restartCount > 3 and False otherwise, and a
Notes or Raises line noting the logging side effect. Keep the existing f-string
logging (the G004 static analysis warning is a false positive) and reference the
function by name (dv_stop_status_after_three_restarts) and its usage in
DataVolume.wait_for_dv_success in the docstring or brief note.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: dd5f8ced-4e37-4a45-b126-be2e6a04cd18
📒 Files selected for processing (1)
tests/storage/utils.py
📜 Review details
🧰 Additional context used
📓 Path-based instructions (3)
**/*.py
📄 CodeRabbit inference engine (AGENTS.md)
**/*.py: Never add linter suppressions like# noqa,# type: ignore, or# pylint: disable. Fix the code instead. If you believe a rule is wrong, ask the user for explicit approval.
Search the codebase for existing implementations before writing new code. Checkutilities/,libs/,tests/, andpyproject.tomldependencies. Never duplicate logic—extract to shared modules. Usepyhelper_utils.shell.run_commandfor shell commands instead ofsubprocess.run, and useocp-resourcesclasses instead of raw YAML dicts.
Type hints are MANDATORY. Use mypy strict mode inlibs/and all new public functions under utilities. UseTYPE_CHECKINGfor type-only imports to avoid runtime overhead and circular imports.
Write Google-format docstrings for all public functions with non-obvious return values or side effects.
Always useuv runto execute commands. Never executepython,pip,pytest,tox, orpre-commitdirectly. Useuv run python,uv run pytest,uv run tox,uv run pre-commit, anduv addfor package installation.
Always use absolute imports. Never use relative imports.
Prefer specific imports usingfrom module import funcfor functions and constants. Usefrom package import module(thenmodule.Name) when retaining the module name meaningfully improves readability. Never use bareimport modulewithout afromclause.
Always use named arguments for function calls with more than one argument.
Never use single-letter variable names. Always use descriptive, meaningful names.
No dead code. Every function, variable, and fixture must be used or removed. Code marked with# skip-unused-codeis excluded from dead code analysis (enforced via custom ruff plugin).
Prefer direct attribute access usingfoo.attr. Save to variables only when reusing the same attribute multiple times improves readability or extracting clarifies intent.
Imports must always be at the top of the module. Do not import inside functions.
No defensive programming. Fail...
Files:
tests/storage/utils.py
tests/**/*.py
📄 CodeRabbit inference engine (AGENTS.md)
Use pytest assertions:
assert actual == expected. Never useself.assertEqual(). Include failure messages:assert condition, 'descriptive message explaining failure'.
Files:
tests/storage/utils.py
**
⚙️ CodeRabbit configuration file
**: ## PR Template Validation
Check the PR description for required sections from.github/pull_request_template.md.
Required sections (must be present, even if empty):
##### What this PR does / why we need it:— MUST be present AND have meaningful content.
Flag as HIGH if the section is missing, empty, whitespace-only, contains only HTML comments,
or contains only placeholder tokens such asTBD,TBA,N/A,-,—,none, or..##### Which issue(s) this PR fixes:— must be present (may be empty)##### Special notes for reviewer:— must be present (may be empty)##### jira-ticket:— must be present (may be empty)
If any required section is absent, orWhat this PR does / why we need it:has no content,
flag it as HIGH severity and ask the author to restore the missing template section(s).Approval Policy
You may approve the PR when ALL of the following are true:
- All your review comments have been addressed with either:
- a code/doc change that fixes the issue, or
- a substantive author response that justifies no code change.
Thread "resolved" state alone is not sufficient.
OR you had no review comments.- If you posted a test execution plan comment requesting tests, and the PR author replied
with a comment explaining why the requested tests are not needed or were already covered,
treat that as an acceptable response — do not block approval on the test plan alone.- The author's explanation must be reasonable and specific (not just "N/A" or "not needed").
Accept explanations like: "these tests were already run in CI", "this change is docs-only",
"the affected tests are quarantined", or "verified manually on cluster X".
Files:
tests/storage/utils.py
⚙️ CodeRabbit configuration file
**: # AI Review and Development StandardsAssisted-by: Claude noreply@anthropic.com
Coding standards, conventions, and review guidelines for openshift-virtualization-tests.
These rules apply to ALL contributors and review tools — human and AI alike.
Strict Rules (MANDATORY)
Linter Suppressions PROHIBITED
- ❌ NEVER add
# noqa,# type: ignore,# pylint: disable- ❌ NEVER disable linter/mypy rules to work around issues
- ✅ FIX THE CODE - If linter complains, the code is wrong
- If you think a rule is wrong: ASK the user for explicit approval
Code Reuse (Search-First Development)
Before writing ANY new code:
- SEARCH codebase for existing implementations
- CHECK
utilities/for shared functions- CHECK
libs/for shared libraries- CHECK
tests/for shared fixtures and helper functions- CHECK
pyproject.tomldependencies — project packages (e.g.,pyhelper-utils,ocp-resources,openshift-python-wrapper) may already provide the functionality- VERIFY no similar logic exists elsewhere
- NEVER duplicate logic - extract to shared module
- REUSE existing code and patterns — only write new when nothing exists
External package examples:
- Shell commands — use
pyhelper_utils.shell.run_command, NEVER usesubprocess.rundirectly in test/utility code- OpenShift resources — use
ocp-resourcesclasses, NEVER construct raw YAML dictsPython Requirements
- Type hints MANDATORY - mypy strict mode in
libs/, all new public functions under utilities MUST be typed- Use
TYPE_CHECKINGfor type-only imports - wrap imports needed solely for type hints inif TYPE_CHECKING:to avoid runtime overhead and circular imports- Google-format docstrings REQUIRED - for all public functions with non-obvious return values OR side effects
- No defensive programming - fail-fast, don't hide bugs with fake defaults (see exceptions below)
- ALWAYS use
uv run-...
Files:
tests/storage/utils.py
🧠 Learnings (67)
📚 Learning: 2025-12-15T12:33:06.686Z
Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 3024
File: tests/network/connectivity/utils.py:17-17
Timestamp: 2025-12-15T12:33:06.686Z
Learning: In the test suite, ensure the ipv6_network_data fixture returns a factory function (Callable) and that all call sites invoke it to obtain the actual data dict, i.e., use ipv6_network_data() at call sites. This enables future extensibility for configuring secondary interfaces' IP addresses without changing call sites. Apply this pattern to all Python test files under tests.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-01-14T04:08:23.032Z
Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 3404
File: tests/virt/upgrade/conftest.py:291-301
Timestamp: 2026-01-14T04:08:23.032Z
Learning: In the openshift-virtualization-tests repository, when using VirtualMachine objects from ocp-resources in tests, if vm.ready is True, vm.vmi is guaranteed to exist. Therefore, you can access vm.vmi.instance.status or vm.vmi attributes without additional defensive checks (e.g., if vm.vmi: ...). Do not rely on vm.vmi being present when vm.ready may be False; guard those code paths accordingly. This guideline applies to tests under tests/ (notably in virt/upgrade/conftest.py and related test modules) and should be followed for any code paths that assume vm.vmi exists only when vm.ready is True.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-01-18T09:44:17.044Z
Learnt from: Anatw
Repo: RedHatQE/openshift-virtualization-tests PR: 3376
File: tests/network/general/test_ip_family_services.py:96-96
Timestamp: 2026-01-18T09:44:17.044Z
Learning: In the openshift-virtualization-tests repository, function-scoped fixtures must use pytest.fixture() with empty parentheses (not pytest.fixture without parentheses). This repo follows this convention despite Ruff PT001. Apply this consistently to all Python test files under tests/ (not just this one) to maintain repository-wide consistency.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-01-27T17:18:49.973Z
Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 3619
File: tests/network/user_defined_network/test_user_defined_network.py:97-97
Timestamp: 2026-01-27T17:18:49.973Z
Learning: In tests that exercise lookup_iface_status_ip from libs.net.vmspec, rely on the function's built-in descriptive error messages for failures. Do not add extra assertion messages for IP presence checks using this function; instead, assert on the function behavior or catch its exceptions as appropriate. This reduces duplication and clarifies failures.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-02-23T16:31:34.505Z
Learnt from: vsibirsk
Repo: RedHatQE/openshift-virtualization-tests PR: 3883
File: utilities/unittests/test_os_utils.py:333-425
Timestamp: 2026-02-23T16:31:34.505Z
Learning: In integration/functional tests located under the tests/ directory, require assertion failure messages using the pattern: assert condition, "descriptive message". For unit tests under utilities/unittests/, rely on pytest's assertion introspection and descriptive test names; explicit failure messages are not required. This guidance helps maintain clear diagnostics for integration tests while keeping unit tests concise and leveraging pytest's built-in introspection.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-02-25T10:52:09.679Z
Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3873
File: tests/network/localnet/test_non_udn_localnet.py:7-9
Timestamp: 2026-02-25T10:52:09.679Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, networking infrastructure requirements (nmstate, localnet bridge mappings, NIC availability) are not automatically tier3; they are considered standard test environment capabilities. Only tests with truly platform-specific, time-consuming, or bare-metal requirements should be marked as tier3. Apply this guidance to all Python tests under tests/, including tests/network/localnet/test_non_udn_localnet.py, ensuring tier3 designation is reserved for genuine platform-specific or complex scenarios rather than general networking infra necessities.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-03-19T10:36:59.023Z
Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 4147
File: tests/network/upgrade/test_upgrade_network.py:166-177
Timestamp: 2026-03-19T10:36:59.023Z
Learning: In this repository’s pytest-based test files (under `tests/`), do not flag unused test method parameters/fixture arguments for removal when the parameters are intentionally kept only to enforce pytest fixture dependency ordering (e.g., an unused fixture like `bridge_on_one_node`). Treat this as an intentional convention consistent with other fixture definitions in the codebase, and do not open follow-up review issues for those unused parameters.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-03-25T11:24:07.687Z
Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 4267
File: tests/storage/cross_cluster_live_migration/conftest.py:530-531
Timestamp: 2026-03-25T11:24:07.687Z
Learning: In this repo’s OpenShift virtualization tests, it is a standard pattern to call `to_dict()` on `ocp-resources` objects (e.g., `DataVolume`) without using its return value. The call is used only to populate the object’s `res` attribute, which is then read or mutated (e.g., `dv.res[...] = ...`). Do not flag this as an unused return value and do not request adding an inline comment just to justify it, since maintainers treat this behavior as consistent and intentional across the codebase.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-03-31T08:35:22.802Z
Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 4318
File: tests/network/bandwidth/test_bandwidth.py:1-3
Timestamp: 2026-03-31T08:35:22.802Z
Learning: In this repository, when reviewing Python test modules under tests/, only require an STP link in the module docstring for STD (new-feature) tests. If the test module is a support-exception test tied to SUPPORTEX-* tickets (e.g., SUPPORTEX-29574) and therefore has no STP, do not flag missing STP links in the module docstring.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-03-31T10:39:33.409Z
Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 4318
File: tests/network/l2_bridge/bandwidth/test_bandwidth.py:5-27
Timestamp: 2026-03-31T10:39:33.409Z
Learning: In this repository’s pytest suite, some STD (Standard Definition) placeholder tests under the `tests/` directory are intentionally implemented as docstring-only functions. They must be marked with `__test__ = False` immediately after the function definition (e.g., `test_x.__test__ = False`) to prevent pytest from collecting/executing them until the real test body exists. During code review, do not flag these as missing executable coverage and do not recommend removing or changing the `__test__ = False` setting when the placeholder pattern matches this accepted STD approach.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-04-02T09:03:57.004Z
Learnt from: ema-aka-young
Repo: RedHatQE/openshift-virtualization-tests PR: 4342
File: tests/storage/cdi_config/test_cdi_config.py:195-205
Timestamp: 2026-04-02T09:03:57.004Z
Learning: When calling `utilities.storage.get_dv_size_from_datasource()` in this repo, do not require an extra `None` guard for its return value if the `datasource` argument originates from a fixture that uses `ensure_exists=True` (e.g., `fedora_data_source_scope_module`). Those fixtures guarantee the datasource exists and provides a valid size, and other repo usages follow the same pattern without additional fail-fast/`None` checks; therefore, reviewers should not flag missing `None` guarding in this specific fixture-driven scenario.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-04-14T13:00:57.514Z
Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 4328
File: tests/network/flat_overlay/test_multi_network_policy.py:32-32
Timestamp: 2026-04-14T13:00:57.514Z
Learning: In this repository’s pytest quarantine tests, do not flag or change `pytest.mark.jira(<id>, run=False)` as ineffective. `run=False` on `pytest.mark.jira()` is intentionally handled by the `pytest_jira` plugin, which conditionally skips the test when the referenced Jira issue is open. This is the correct behavior for **Category 1 (Product Bug)** quarantines; the `pytest.mark.xfail(run=False)` approach is reserved for **Category 2 (Automation Issue)** quarantines only (as documented in `docs/QUARANTINE_GUIDELINES.md`).
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-04-14T16:15:31.065Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 4328
File: tests/network/flat_overlay/test_multi_network_policy.py:0-0
Timestamp: 2026-04-14T16:15:31.065Z
Learning: When reviewing Python tests, avoid redundant parentheses around f-strings in `pytest.mark.xfail` decorators. Prefer `pytest.mark.xfail(reason=f"...", run=False)` over `pytest.mark.xfail(reason=(f"..."), run=False)`, and flag/suggest removing the extra wrapping parentheses where found.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-04-14T16:15:33.012Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 4328
File: tests/network/flat_overlay/test_multi_network_policy.py:32-32
Timestamp: 2026-04-14T16:15:33.012Z
Learning: For this repository (RedHatQE/openshift-virtualization-tests), when reviewing any PR with "Quarantine" in the title or a `quarantine` label, check compliance with `docs/QUARANTINE_GUIDELINES.md` in any affected pytest test code. Specifically: (1) For Category 1 (Product Bug), require `pytest.mark.jira("CNV-XXXXX", run=False)` and do not suggest replacing it with `xfail` (the `pytest_jira` plugin conditionally skips when the Jira issue is open). (2) For Category 2 (Automation Issue), require `pytest.mark.xfail(run=False, reason=...)` (pytest handles the skip). During review, flag quarantine PRs that use the wrong marker/category, omit a Jira ticket reference for Category 1, or use `run=False` in an incorrect context; raise these compliance questions even if later resolution confirms the marker was correct.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-04-21T19:08:39.771Z
Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 4542
File: tests/network/libs/bgp.py:333-354
Timestamp: 2026-04-21T19:08:39.771Z
Learning: In this codebase, when using `retry` imported from `timeout_sampler`, the decorated function must indicate success by returning a truthy value. The decorator retries until it encounters a truthy `sample` (i.e., it does `if sample: return sample`). Therefore, ensure `retry`-decorated functions include `return True` (or another truthy value) on success; avoid removing/altering it on the assumption that the caller ignores the return value. If the function returns `None` (or has no return statement), it will keep retrying and typically end in `TimeoutExpiredError`.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-04-26T11:44:20.150Z
Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 4578
File: tests/network/localnet/nad_ref_change/test_nad_ref_change.py:18-18
Timestamp: 2026-04-26T11:44:20.150Z
Learning: In this repository’s STD (Standard Test Definition) PRs under `tests/**`, it’s expected that Polarion IDs may be placeholders (e.g., `pytest.mark.polarion("CNV-00000")`) while the test scenarios are still being agreed upon. If the test scenario is disabled for the moment (e.g., the scenario/module sets `__test__ = False`), reviewers should not treat placeholder Polarion IDs as a blocking issue. Real Polarion IDs should be filled in before or during the implementation PR.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-04-27T15:40:31.167Z
Learnt from: dalia-frank
Repo: RedHatQE/openshift-virtualization-tests PR: 4603
File: tests/data_protection/oadp/test_velero.py:101-130
Timestamp: 2026-04-27T15:40:31.167Z
Learning: When reviewing tests in RedHatQE/openshift-virtualization-tests, do not require STD-first workflow and STP/RFE/Jira-epic module docstring/traceability for tests that are being re-enabled after previously being blocked by a product bug (e.g., after a CNV Jira bug fix). Only enforce these STD-first and STP/RFE/Jira-epic module docstring requirements for genuinely new feature tests; previously blocked tests that are now unblocked/re-enabled should not be flagged as missing traceability.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-03T14:47:13.096Z
Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 4569
File: tests/network/user_defined_network/rhel9_rhel10_cluster/test_connectivity.py:17-51
Timestamp: 2026-05-03T14:47:13.096Z
Learning: In this repository’s pytest suite (files under `tests/`), it is acceptable to have identically named `test_*` functions in different test modules (e.g., same function name in different `.../test_*.py` files). Do not request renaming solely to disambiguate function names across modules, since pytest node IDs remain unique and unambiguous due to the module path prefix. The team accepts the trade-off that `pytest -k <name>` will match tests in all modules containing that name.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-05T17:27:32.109Z
Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 4739
File: tests/virt/node/descheduler/conftest.py:145-145
Timestamp: 2026-05-05T17:27:32.109Z
Learning: In this repo’s Python tests, `pyhelper_utils.shell.run_command` defaults to `check=True` (so it raises `subprocess.CalledProcessError` on non-zero exit). Therefore, don’t flag missing return-code handling/rc checks for bare calls like `run_command(...)` (or calls where `check` is not explicitly provided). Only flag cases where `check=False` is explicitly passed and the exit code/return value is ignored or not otherwise handled.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-05T18:28:01.097Z
Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 4739
File: tests/virt/node/descheduler/conftest.py:142-146
Timestamp: 2026-05-05T18:28:01.097Z
Learning: In this repository, ignore Ruff rule PT022 in Python test files under `tests/`. If PT022 is triggered in a `pytest` fixture that uses `yield` but has no teardown code, treat it as an acceptable low-value nitpick and do not suggest changing the fixture to use `return` or otherwise flag the issue during code review.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-07T12:34:42.589Z
Learnt from: OhadRevah
Repo: RedHatQE/openshift-virtualization-tests PR: 4162
File: tests/install_upgrade_operators/crypto_policy/utils.py:320-323
Timestamp: 2026-05-07T12:34:42.589Z
Learning: When parsing the output of `openssl list -tls-groups`, remember it prints TLS group names on a single colon-separated line (e.g., `secp256r1:X25519:SecP256r1MLKEM768:...`). Parse individual TLS group names by splitting on `:` (e.g., `output.strip().split(':')`) rather than assuming one group per line. In code that specifically handles this `openssl list -tls-groups` output, do not flag `split(':')` as incorrect.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-08T12:31:26.895Z
Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 4772
File: tests/network/l2_bridge/rhel9_rhel10_cluster/test_connectivity.py:20-22
Timestamp: 2026-05-08T12:31:26.895Z
Learning: In RedHatQE/openshift-virtualization-tests, any pytest test already marked with `pytest.mark.mixed_os_nodes` must not also be marked with `pytest.mark.tier3`. The `mixed_os_nodes` marker is responsible for both environment filtering and selecting the dedicated execution lane for dual-stream (mixed RHCOS 9 + RHCOS 10) cluster scenarios. Apply this rule to all test modules under `tests/` that use the `mixed_os_nodes` marker (e.g., `tests/network/l2_bridge/rhel9_rhel10_cluster/test_connectivity.py`).
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-12T18:18:20.607Z
Learnt from: Anatw
Repo: RedHatQE/openshift-virtualization-tests PR: 4833
File: tests/network/localnet/migration_stuntime/test_migration_stuntime.py:51-51
Timestamp: 2026-05-12T18:18:20.607Z
Learning: In RedHatQE/openshift-virtualization-tests, do not flag or suggest removing Python linter suppressions `# noqa: PID001` in files under `tests/`. `PID001` is a custom flake8 rule enforced by the Polarion ID checker plugin (not a standard Ruff rule). Therefore Ruff’s `RUF102` (“Invalid rule code in `# noqa`: PID001”) is a false positive in this repo. These `# noqa: PID001` comments are intentional and effective, commonly used on base-class `test_*` methods where the Polarion markers are defined on subclass overrides.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-25T09:13:27.011Z
Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 4962
File: tests/network/l2_bridge/nad_ref_change/lib_helpers.py:80-81
Timestamp: 2026-05-25T09:13:27.011Z
Learning: When reviewing Python code in this repository, do NOT flag short loop variables like `i` (or other short names) as non-descriptive when they are used as the index in a simple `enumerate()` loop where the variable’s role is immediately obvious from context and the loop body is a single straightforward statement (e.g., `for i, addresses in enumerate(ip_addresses): ethernets[f"eth{i + 1}"] = ...`). In these cases, keep the short index variable and do not recommend renaming it to a longer form like `interface_index`.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-25T09:57:03.042Z
Learnt from: Anatw
Repo: RedHatQE/openshift-virtualization-tests PR: 4833
File: tests/network/localnet/migration_stuntime/test_migration_stuntime.py:57-57
Timestamp: 2026-05-25T09:57:03.042Z
Learning: In pytest test files under `tests/`, when using `pytest.mark.parametrize(..., indirect=True)`, ensure the parametrized `param_name` is present in the test function signature (pytest will fail at collection time if it’s missing). When reviewing lints such as `ARG002` (unused argument), do not flag that `param_name` as unused if it only exists to trigger indirect fixtures or to drive other fixtures via the fixture dependency chain— even if the test body never references the value directly.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-28T12:55:07.435Z
Learnt from: OhadRevah
Repo: RedHatQE/openshift-virtualization-tests PR: 5023
File: tests/install_upgrade_operators/crypto_policy/utils.py:299-314
Timestamp: 2026-05-28T12:55:07.435Z
Learning: In this repo’s test suite, the `hco_namespace` pytest fixture (defined in `tests/conftest.py`) returns an OpenShift `Namespace` Resource object created by `utilities.hco.get_hco_namespace(...)`. When a function receives `hco_namespace` as a fixture argument, it is valid to access `hco_namespace.name` and it will be the namespace name string. Code review should not flag `hco_namespace.name` as a potential `AttributeError` when the value originates from the `hco_namespace` fixture (i.e., passed in via the fixture parameter); only warn if the value was assigned/derived from something other than the fixture.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-29T07:28:31.170Z
Learnt from: josemacassan
Repo: RedHatQE/openshift-virtualization-tests PR: 5003
File: tests/storage/upgrade/constants.py:5-9
Timestamp: 2026-05-29T07:28:31.170Z
Learning: Do not require explicit type annotations for module-level string constants declared in test modules (e.g., `FOO = "bar"` in files under `tests/`). Treat this as an exception to any broader "Type hints are MANDATORY" guideline: only enforce type hints for public functions in `libs/` and `utilities/`, not for simple module-level constant assignments in `tests/`.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-06-01T13:36:34.844Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 4954
File: tests/network/bgp/evpn/libevpn.py:77-77
Timestamp: 2026-06-01T13:36:34.844Z
Learning: In this repository’s Python code (especially under tests/), for context-manager methods named `__enter__`, do not require `typing.Self` as the return type when the containing class name is already known/declared above the method. It is acceptable to annotate `__enter__` as returning the concrete class name (e.g., `def __enter__(self) -> EndpointTcpClient:`). `typing.Self` may be used, but it must not be mandated. Do not flag `__enter__` annotations of the form `-> ClassName` as needing to be changed to `-> Self`.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-06-01T14:00:39.271Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 4954
File: .flake8:4-4
Timestamp: 2026-06-01T14:00:39.271Z
Learning: When reviewing the “smoke-marked” tests in this repository (i.e., tests under the tests/ tree), don’t conclude that there is “no smoke dependency path” until you verify the full transitive import/fixture chain. Specifically, trace both direct imports and transitive imports through shared pytest fixtures like tests/storage/conftest.py, and through any modules those fixtures import, to confirm whether the smoke tests ultimately depend on utilities modules such as utilities/storage.py, utilities/hco.py (e.g., wait_for_hco_conditions), utilities/infra.py, and utilities/virt.py.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-06-02T21:16:58.118Z
Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 5039
File: tests/network/l2_bridge/nad_ref_change/lib_helpers.py:1-1
Timestamp: 2026-06-02T21:16:58.118Z
Learning: In RedHatQE/openshift-virtualization-tests, if a PR only relocates functions into shared/helper libraries and updates the corresponding import paths in test files—without any logic/behavior change in the moved functions—do not require full re-execution of the affected caller tests. Instead, at most run `pytest --collect-only` (for the relevant test modules) to confirm the updated imports resolve. Require full re-execution of caller tests only when the moved function’s implementation changes in a way that could affect behavior (e.g., different logic, side effects, return values, error handling, or fixture interaction).
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-06-11T11:56:02.760Z
Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 5090
File: tests/observability/metrics/conftest.py:0-0
Timestamp: 2026-06-11T11:56:02.760Z
Learning: When reviewing NAD swap tests (and any other test code) that calls `libs.net.vmspec.update_nad_references`, ensure the VM argument matches the helper’s intended type: it’s a module-level helper typed for `libs.vm.vm.BaseVirtualMachine`, not `utilities.virt.VirtualMachineForTests`. `BaseVirtualMachine` and `VirtualMachineForTests` are sibling subclasses of `ocp_resources.virtual_machine.VirtualMachine`, so don’t pass `VirtualMachineForTests` to `update_nad_references` unless the helper’s signature/API is intentionally widened. For NAD swap tests using this helper, prefer creating the VM via `libs.vm.factory.fedora_vm` so the returned object is a `BaseVirtualMachine`.
Applied to files:
tests/storage/utils.py
📚 Learning: 2025-12-22T16:27:40.244Z
Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3196
File: tests/network/upgrade/test_upgrade_network.py:4-4
Timestamp: 2025-12-22T16:27:40.244Z
Learning: For PRs that remove tests, rely on pytest --collect-only to verify the test discovery results (which tests are selected/deselected) and ensure the removal is clean and the test module remains functional. Full test execution is not required for test deletion PRs. This guideline applies to test files anywhere under the tests/ directory (e.g., tests/network/upgrade/test_upgrade_network.py) and should be used for similar test-deletion scenarios across the repository.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-01-07T09:52:12.342Z
Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3358
File: tests/network/sriov/test_sriov.py:21-21
Timestamp: 2026-01-07T09:52:12.342Z
Learning: When a PR only removes or modifies pytest markers in tests (e.g., removing pytest.mark.post_upgrade) and the test logic remains unchanged, prefer verifying with pytest --collect-only instead of running the full test suite. This validates that marker usage and test selection behavior are preserved. If the test logic changes, or markers affect behavior beyond collection, run the full test suite to confirm.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-01-18T13:18:48.808Z
Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 3273
File: tests/network/connectivity/test_ovs_linux_bridge.py:5-9
Timestamp: 2026-01-18T13:18:48.808Z
Learning: In tests/network/connectivity/test_ovs_linux_bridge.py and similar test files, prefer importing ipaddress as a module and using qualified calls like ipaddress.ip_interface(...) rather than from ipaddress import ip_interface. This preserves module context for readability, especially when chaining properties (e.g., ipaddress.ip_interface(...).ip). This is an intentional exception to the general rule favoring specific imports, and should apply to test files under the tests directory where module context aids understanding.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-01-18T14:51:50.846Z
Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3495
File: tests/network/third_part_ip_request/test_third_party_ip_request.py:4-12
Timestamp: 2026-01-18T14:51:50.846Z
Learning: In the openshift-virtualization-tests repository, tests consistently import pytest as a module (import pytest) and avoid from pytest import ...; this is the established pattern across 398+ test files. Do not flag or refactor imports to use specific pytest names in tests under tests/**. If a file already follows this pattern, leave it as is; this guideline applies broadly to Python test files under the tests directory.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-01-29T05:30:13.982Z
Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 3649
File: tests/network/user_defined_network/ip_specification/libipspec.py:1-4
Timestamp: 2026-01-29T05:30:13.982Z
Learning: In the openshift-virtualization-tests repository, Python imports should use module import style for the standard library 'json' (import json) rather than 'from json import ...'. This improves readability by making calls like json.loads and json.dumps explicit, and aligns with patterns used for modules like logging, ipaddress, cloudinit, and pytest. Apply this to all Python test files under tests/ (and similar test directories).
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-02-02T17:41:12.759Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3690
File: tests/after_cluster_deploy_sanity/test_after_cluster_deploy_sanity.py:65-65
Timestamp: 2026-02-02T17:41:12.759Z
Learning: In test files, keep test_* functions with simple one-line docstrings. For helper functions, utilities, and library code with non-obvious return values or side effects, use Google-style docstrings with Args, Returns, and Side effects sections. Do not require Google-style docstrings for pytest test functions themselves.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-02-03T07:34:34.184Z
Learnt from: RoniKishner
Repo: RedHatQE/openshift-virtualization-tests PR: 3697
File: tests/infrastructure/instance_types/test_common_vm_instancetype.py:53-98
Timestamp: 2026-02-03T07:34:34.184Z
Learning: In test files (Python, pytest), prefer using tier3 markers for categorization since tier2, tier1, and tier4 are not used in this repository. Do not rely on non-official markers; formalize and document the allowed markers in pytest.ini (or equivalent) to ensure consistent usage. When reviewing new tests, ensure markers align with this convention (only tier3, unless a project-wide decision defines additional tiers) and remove any unnecessary or undocumented markers.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-02-10T15:04:14.799Z
Learnt from: vsibirsk
Repo: RedHatQE/openshift-virtualization-tests PR: 3577
File: tests/virt/conftest.py:251-267
Timestamp: 2026-02-10T15:04:14.799Z
Learning: In Python tests, remove all bare time.sleep() calls. Replace with a waiting mechanism such as TimeoutSampler from the timeout_sampler package or a function decorated with retry (with appropriate timeout/conditions) to ensure determinism and avoid flakiness. This applies to all Python tests under the tests directory (not just this file) to maintain consistent waiting behavior across the suite.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-02-25T11:00:02.013Z
Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3873
File: tests/network/localnet/test_non_udn_localnet.py:19-27
Timestamp: 2026-02-25T11:00:02.013Z
Learning: In the test codebase, do not import from conftest.py files. This avoids import ambiguity in pytest. Do not import constants or helpers defined in conftest.py into tests. If a value is needed in both conftest.py and test files, duplicate it in both places or place it in a separate utility module that is importable by tests.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-03-29T13:51:25.599Z
Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 4267
File: tests/storage/cross_cluster_live_migration/test_cclm.py:96-106
Timestamp: 2026-03-29T13:51:25.599Z
Learning: In this repository, follow the existing pytest convention for `pytest.mark.parametrize` argument names: use a single comma-separated string for `argnames` (e.g., `"dv_wait_timeout, vms_for_cclm"`), not a tuple (e.g., `("dv_wait_timeout", "vms_for_cclm")`). Do not flag or suggest changing `argnames` to a tuple. Also note that PT006 is not enforced by Ruff in this repo, so reviewers should not treat PT006 as a reason to alter the `argnames` format.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-01-12T11:24:13.825Z
Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 3387
File: tests/network/provider_migration/libprovider.py:50-52
Timestamp: 2026-01-12T11:24:13.825Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, when catching exceptions in Python, use LOGGER.error before re-raising and do not replace it with LOGGER.exception in except blocks. This follows the established pattern across the codebase.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-01-12T14:25:05.723Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3366
File: tests/storage/cdi_clone/test_clone.py:5-9
Timestamp: 2026-01-12T14:25:05.723Z
Learning: In Python tests and utility code across the repository, bitmath.parse_string_unsafe correctly parses Kubernetes quantities (e.g., '4Gi', '512Mi', PVC storage requests) without supplying system=bitmath.NIST. There are 30+ usages indicating this is the standard behavior. Reviewers should verify that code that builds or compares quantity strings does not pass the NIST parameter, and if a new test relies on quantity parsing, assume no NIST parameter is required unless explicitly documented.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-01-20T01:03:13.139Z
Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 3387
File: tests/network/provider_migration/libprovider.py:1-8
Timestamp: 2026-01-20T01:03:13.139Z
Learning: In the openshift-virtualization-tests repository, Python imports should consistently use module-level imports for the logging module (i.e., import logging) rather than from logging import ... The established pattern spans 270+ files and should not be flagged for refactoring. Apply this guideline to Python files across the repo (e.g., tests/network/provider_migration/libprovider.py).
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-01-21T21:26:41.805Z
Learnt from: geetikakay
Repo: RedHatQE/openshift-virtualization-tests PR: 3559
File: utilities/infra.py:251-254
Timestamp: 2026-01-21T21:26:41.805Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, when reviewing Python code, recognize that with Python 3.14 the syntax 'except ValueError, TypeError:' is valid if there is no 'as' clause, and should not be flagged as Python 2 syntax. If you use an 'as' binding (e.g., 'except (ValueError, TypeError) as e:'), parentheses are required. Ensure this pattern is version-consistent and not flagged as Python 2 syntax when 'as' is absent.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-01-25T13:18:21.675Z
Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 3571
File: tests/storage/storage_migration/utils.py:158-167
Timestamp: 2026-01-25T13:18:21.675Z
Learning: In reviews of the openshift-virtualization-tests repo (and similar Python code), avoid suggesting minor stylistic changes that require extra verification (e.g., removing dict.keys() checks for membership) unless the change has clear correctness or maintainability impact. Focus on fixes with observable behavior, security, performance, or maintainability benefits; defer low-impact style tweaks that are costly to verify.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-02-18T06:35:39.536Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3847
File: utilities/virt.py:2449-2453
Timestamp: 2026-02-18T06:35:39.536Z
Learning: In Python code, a function named clearly and self-descriptively can be deemed not to require a docstring. However, treat this as a context-specific guideline and not a universal rule. For public APIs or functions with side effects, prefer concise docstrings explaining behavior, inputs, outputs, and side effects. This guidance is based on the example in utilities/virt.py from RedHatQE/openshift-virtualization-tests where validate_libvirt_persistent_domain(vm, admin_client) was considered self-documenting.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-02-23T16:33:22.070Z
Learnt from: vsibirsk
Repo: RedHatQE/openshift-virtualization-tests PR: 3883
File: utilities/pytest_utils.py:441-463
Timestamp: 2026-02-23T16:33:22.070Z
Learning: In Python code reviews, the guideline to always use named arguments for multi-argument calls does not apply to built-ins or methods that have positional-only parameters (those defined with a / in their signature). Do not flag or require named arguments for calls like dict.get(key, default=None, /), list.pop(), str.split(sep, maxsplit) and similar built-ins that cannot accept keyword arguments. Apply the named-argument rule only to functions/methods that explicitly accept keyword arguments.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-03-17T01:32:02.617Z
Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 4118
File: utilities/database.py:0-0
Timestamp: 2026-03-17T01:32:02.617Z
Learning: In RedHatQE/openshift-virtualization-tests, when reviewing Python files, post targeted inline comments on the Files changed tab at the exact location (file and line) of the issue rather than opening a single discussion thread for multiple issues. This should be done for each applicable location to improve traceability and clarity. If multiple issues exist in the same file, address them with separate inline comments pointing to the specific lines.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-03-17T01:32:02.617Z
Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 4118
File: utilities/database.py:0-0
Timestamp: 2026-03-17T01:32:02.617Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, CodeRabbit should post targeted inline comments at each applicable location in the Files Changed tab, rather than aggregating multiple issues into a single PR discussion thread reply. This guideline applies to all Python files (any file ending in .py) changed in a PR; for non-Python files, follow the same inline-comment-at-location principle if relevant.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-04T13:45:29.122Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 4725
File: utilities/console.py:54-59
Timestamp: 2026-05-04T13:45:29.122Z
Learning: During review of RedHatQE/openshift-virtualization-tests “lint-cleanup” PRs (e.g., changes targeting lint issues like stale noqa/utf-8 headers), do not flag existing `# type: ignore` directives that were already present before the PR and were not introduced or modified by the PR. Only raise findings for `# type: ignore` suppressions that the PR itself adds, changes, or otherwise makes newly effective (i.e., they appear in the diff as additions/edits).
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-04T13:45:33.892Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 4725
File: tests/virt/cluster/common_templates/centos/test_centos_os_support.py:78-83
Timestamp: 2026-05-04T13:45:33.892Z
Learning: When reviewing lint-cleanup or formatting-only pull requests in this repo (e.g., changes like removing/updating `# noqa` comments or UTF-8 headers), do not raise findings for code patterns that already existed before the PR. Specifically, if a problematic construct such as `.is_connective(tcp_timeout=120)` was present in the base branch, suppress that finding and only raise issues when the PR itself introduces or modifies that construct (i.e., the diff adds/changes the call or its arguments). Apply this rule across all Python files (`**/*.py`).
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-05T17:01:15.294Z
Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 4739
File: tests/virt/node/descheduler/conftest.py:2-2
Timestamp: 2026-05-05T17:01:15.294Z
Learning: In this repo’s Python code, it’s acceptable (and preferred by convention) to build `run_command` inputs using `shlex.split(f"<command> {arg}")` rather than converting to direct list literals like `['oc', 'adm', 'uncordon', name]`. During code review, generally don’t flag `shlex.split(...)` usage for `run_command` calls and don’t suggest replacing it with list literals; the string-form pattern is used to keep commands readable and consistent with how they’re typed in a terminal.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-08T12:49:20.694Z
Learnt from: geetikakay
Repo: RedHatQE/openshift-virtualization-tests PR: 4788
File: utilities/os_utils.py:257-262
Timestamp: 2026-05-08T12:49:20.694Z
Learning: In RedHatQE/openshift-virtualization-tests, the Ruff flake8-boolean-trap rules FBT001/FBT002 are intentionally not enabled (pyproject.toml does not select the FBT rules; confirmed via `ruff check --show-settings`). Therefore, do not flag boolean positional parameters as FBT001/FBT002 violations in this repository. If Ruff configuration changes and starts selecting FBT rules, this exception should be reconsidered.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-12T05:10:24.601Z
Learnt from: acinko-rh
Repo: RedHatQE/openshift-virtualization-tests PR: 4780
File: tests/storage/utils.py:568-572
Timestamp: 2026-05-12T05:10:24.601Z
Learning: In this repository, Ruff rule UP043 ("unnecessary default type arguments") is enforced. When annotating `collections.abc.Generator` return types, prefer the single-parameter form `Generator[YieldType]` rather than `Generator[YieldType, None, None]`. Explicit `None, None` for the SendType and ReturnType are unnecessary defaults (per PEP 696) and will trigger UP043. Apply this consistently across all Python files.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-13T19:23:09.603Z
Learnt from: Anatw
Repo: RedHatQE/openshift-virtualization-tests PR: 4833
File: tests/network/localnet/migration_stuntime/libstuntime.py:25-25
Timestamp: 2026-05-13T19:23:09.603Z
Learning: In this repository, do not recommend adding `from __future__ import annotations` to fix forward-reference type annotation issues (e.g., Ruff UP037). Follow the established convention: use quoted string type annotations for forward references when the referenced class/type is defined later in the same file (e.g., `"ContinuousPing"`), and prefer `typing.Self` for self-referential return types.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-18T06:30:56.781Z
Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 4819
File: utilities/unittests/test_bitwarden.py:207-207
Timestamp: 2026-05-18T06:30:56.781Z
Learning: During Ruff/lint rule-enablement PRs in this repository (e.g., when introducing a new rule like PLC0415), it’s acceptable to keep CI green by adding per-line, targeted suppressions for pre-existing violations: add only `# noqa: <single-ruff-rule-id>` at the end of the specific violating line. In this PR context, reviewers should NOT flag these targeted `# noqa: PLC0415` comments as policy violations, assuming the suppression is for a pre-existing issue and is documented in the PR description as a candidate for follow-up cleanup. Do not allow blanket `# noqa` (without a specific rule) or `per-file-ignores`; those remain disallowed.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-18T06:31:12.015Z
Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 4819
File: utilities/unittests/test_pytest_utils.py:270-270
Timestamp: 2026-05-18T06:31:12.015Z
Learning: In RedHatQE/openshift-virtualization-tests, if a PR is a Ruff rule-enforcement PR and its “Special notes for reviewer” documents that pre-existing Ruff violations are being temporarily handled via per-line suppressions (e.g., `# noqa: PLC0415`) to keep CI green, reviewers should treat those specific `# noqa: <rule>` comments as an agreed, temporary mechanism. Do not flag them as code-quality issues and do not recommend removing, consolidating, or refactoring those suppressions within the same PR; cleanup/remediation is expected to happen in dedicated follow-up PRs instead.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-18T06:31:15.083Z
Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 4819
File: utilities/unittests/test_data_collector.py:304-304
Timestamp: 2026-05-18T06:31:15.083Z
Learning: When reviewing Python code in this repository for Ruff/linter rule rollouts, do not treat temporary suppression comments as violations in the specific migration scenario where a PR enables a new Ruff rule (e.g., PLC0415) and the PR description explicitly documents that all *pre-existing* violations are being annotated with `# noqa: <RULE>` as a short-lived measure. In that case, only flag `# noqa: <RULE>` suppressions that are newly introduced on code that did not previously violate the rule—i.e., verify via the PR diff against the prior state (and/or prior Ruff findings) that the suppressed line was already violating before the rule was enabled. Ignore suppressions that are covering violations that existed before the new rule rollout and were intentionally bulk-added for cleanup in follow-up PRs.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-18T06:31:20.848Z
Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 4819
File: utilities/unittests/test_hco.py:501-501
Timestamp: 2026-05-18T06:31:20.848Z
Learning: When reviewing Python code in RedHatQE/openshift-virtualization-tests, avoid flagging Ruff `# noqa: <RULE>` suppressions as issues if they were intentionally added as a temporary measure to keep CI green after a PR enables a new Ruff/lint rule (e.g., PLC0415) and the PR description documents this under "Special notes for reviewer". Treat these suppressions as deferred technical debt. Only flag `# noqa: PLC0415` (and similar rule-specific suppressions) when they are newly introduced without an accompanying documented intent in the PR (and thus appear to be masking a new violation rather than a pre-existing one).
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-18T09:09:09.479Z
Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 4878
File: utilities/unittests/test_pytest_utils.py:2194-2197
Timestamp: 2026-05-18T09:09:09.479Z
Learning: In this repository (RedHatQE/openshift-virtualization-tests), do not flag missing return type annotations or missing argument type annotations as Ruff “ANN” rule violations (e.g., ANN001/ANN002/ANN201/ANN202). The repo’s Ruff configuration does not enable ANN rules and only uses `extend-select = ["PLC0415"]`, so missing type annotations should not be treated as ANN lint failures during code review.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-19T07:48:17.119Z
Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 4784
File: libs/vm/affinity.py:104-104
Timestamp: 2026-05-19T07:48:17.119Z
Learning: When using Kubernetes API models like `NodeSelectorRequirement` or `LabelSelectorRequirement` with operators `Exists` or `DoesNotExist`, the `values` field must not be non-empty. It is valid for `values` to be omitted / left as `None` (Python) / passed as `null`—Kubernetes rejects non-empty `values` for these operators, but does not require the field to be present or explicitly set to an empty list. In code reviews, do not treat missing `values=[]` for `Exists`/`DoesNotExist` as a validation issue; only flag cases where `values` is provided with actual elements.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-19T07:48:17.119Z
Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 4784
File: libs/vm/affinity.py:104-104
Timestamp: 2026-05-19T07:48:17.119Z
Learning: When constructing Kubernetes `NodeSelectorRequirement` (or `LabelSelectorRequirement`) objects in code, do not treat `values` being omitted, `None`, or an empty list as an API-validation problem when the requirement’s operator is `Exists` or `DoesNotExist`. Per the Kubernetes API spec, these operators only require that the `values` array is not non-empty (i.e., it must be empty); they do not require the field to be explicitly present as `[]`. Therefore, reviewers should not flag `values=None`/missing `values` for `Exists`/`DoesNotExist`.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-26T15:52:31.613Z
Learnt from: rlobillo
Repo: RedHatQE/openshift-virtualization-tests PR: 4983
File: utilities/hco.py:376-378
Timestamp: 2026-05-26T15:52:31.613Z
Learning: For Python files in this repo, don’t raise review findings for missing type hints or missing/Google-style docstrings on an existing function when the PR’s only functional change is adding one or more new parameters to that function and the PR does not otherwise refactor or substantially rewrite its body/signature. Treat type-annotation/docstring improvements as out of scope for focused parameter-add PRs and defer them to a follow-up. Only raise missing type-hint or docstring issues when the PR introduces an entirely new function or substantially rewrites an existing one.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-02-19T15:36:04.744Z
Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 3926
File: tests/storage/cross_cluster_live_migration/utils.py:137-156
Timestamp: 2026-02-19T15:36:04.744Z
Learning: In cross-cluster live migration (CCLM) tests vs storage-migration tests, boot-time verification uses different access methods: console-based (get_vm_boot_time_via_console) when SSH to VMs in the remote cluster is unavailable, and SSH-based (get_vm_boot_time) when VMs remain in the same cluster. Code reviews should enforce separate, clearly named verification functions for each scenario (e.g., verify_vms_boot_time_after_migration vs verify_vms_boot_time_after_storage_migration) and place them in the appropriate modules. This pattern applies to all Python test utilities under tests/storage.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-03T15:38:09.624Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 4701
File: tests/virt/node/general/test_windows_vtpm_bitlocker.py:50-52
Timestamp: 2026-05-03T15:38:09.624Z
Learning: During review of PRs that are lint cleanups or tooling/version bumps, do not flag code-quality issues for patterns that pre-existed before the PR. Specifically, if the diff does not introduce/modify constructs such as nested `if` blocks or unnecessary list comprehensions, treat them as known/deferred and leave them for dedicated follow-up cleanup PRs. Only raise issues when the PR itself adds, changes, or refactors the problematic code.
Applied to files:
tests/storage/utils.py
📚 Learning: 2026-05-20T08:46:30.219Z
Learnt from: acinko-rh
Repo: RedHatQE/openshift-virtualization-tests PR: 4780
File: tests/storage/snapshots/test_snapshots.py:267-299
Timestamp: 2026-05-20T08:46:30.219Z
Learning: For Python tests under tests/storage/, follow the existing traceability convention: use only `pytest.mark.polarion()` for test traceability. Do not treat missing STP/RFE/Jira-epic links (e.g., absent module-docstring links) as a HIGH-severity finding.
When reviewing changes that add new tests/fixtures, only flag missing STP/RFE/Jira-epic links as LOW/informational if the target file already has the established “STD” traceability pattern (i.e., that file already includes STP/RFE/Jira-epic links in its existing traceability mechanism such as the module docstring). Otherwise, leave these omissions unflagged and rely on `pytest.mark.polarion()` as the traceability mechanism.
Applied to files:
tests/storage/utils.py
🪛 Ruff (0.15.15)
tests/storage/utils.py
[warning] 545-545: Logging statement uses f-string
(G004)
[warning] 580-580: Logging statement uses f-string
(G004)
🔇 Additional comments (2)
tests/storage/utils.py (2)
4-5: LGTM!
587-602: Fix DV convergence stop-status predicate construction (state reset prevents “stuck” detection)
Intests/storage/utils.py,dv_stop_status_universal(dv)callsdv_stop_status_not_converging()each time it’s evaluated, which recreates the closure and resets itsnonlocallast_value/last_change_time; this prevents the “stuck for 5 minutes” timer from accumulating across polls. Refactor to create thedv_stop_status_not_converging()closure once and reuse it for the full wait (e.g., havedv_stop_status_universalreturn a predicate closure, or otherwise construct the closure outside the per-check evaluation). Minor: switchany([ ... ])toany(( ... ))and expanddv_stop_status_universalto a proper Google-style docstring withArgs/Returns.
openshift-virtualization-qe-bot
added
needs-rebase
tox:verify-tc-requirement-polarion:running
|
Clean rebase detected — no code changes compared to previous head ( |
Contributor
Author
|
/wip cancel |
Contributor
|
Clean rebase detected — no code changes compared to previous head ( |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/storage/conftest.py`:
- Around line 548-550: The fixture dv_stop_status_universal_scope_module
currently has module scope, but it returns a stateful stop function from
dv_stop_status_checker() that maintains mutable closure state through
dv_stop_status_not_converging(). This causes multiple DV waits in the same
module to share stale state from previous waits, leading to premature failures.
Change the scope parameter of the dv_stop_status_universal_scope_module fixture
from "module" to "function" so that each test receives a fresh instance with
clean state instead of reusing the same stateful object across multiple tests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: e47cd574-6c61-4a3c-b6ac-332026963d66
📒 Files selected for processing (5)
tests/storage/cdi_clone/conftest.pytests/storage/cdi_clone/test_clone.pytests/storage/conftest.pytests/storage/constants.pytests/storage/stop_status_utils.py
|
D/S test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5204 +/- ##
==========================================
- Coverage 98.67% 98.65% -0.02%
==========================================
Files 25 25
Lines 2487 2460 -27
==========================================
- Hits 2454 2427 -27
Misses 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
tested the functionality by setting the restart threshold to |
|
/build-and-push-container |
Contributor
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5204 published |
|
Verification failed for PR #5204. Execution details |
Introduce a closure-based stop status system for DataVolume operations: - Add stop_status_utils.py with memoized closure factories - Add dv_stop_status_after_three_restarts to detect excessive DV restarts - Wire stop status checker into CDI clone test fixtures and tests - Store universal stop status factory list in constants.py Signed-off-by: Adam Cinko <acinko@redhat.com>
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5204 published |
Contributor
|
Clean rebase detected — no code changes compared to previous head ( |
|
/verified All tests passed for PR #5204. Execution details |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Output rules: Your deliverable: Test Execution Plan
Use these formats:
Real test commands (MANDATORY when changes affect session/runtime code): When the affected code runs at session/collection time (conftest fixtures, pytest plugins,
Example output for a session-startup fix: Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL — Verification rules for smoke and gating decisions: |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Check smoke markers in storage tests
echo "=== Smoke-marked files in tests/ ==="
rg -l '`@pytest.mark.smoke`' tests/
echo ""
echo "=== Gating-marked files in tests/ ==="
rg -l '`@pytest.mark.gating`' tests/
echo ""
echo "=== Markers in tests/storage/cdi_clone/test_clone.py ==="
rg '`@pytest.mark`\.' tests/storage/cdi_clone/test_clone.py -n
echo ""
echo "=== Files importing STOP_STATUS_UTILS_UNIVERSAL_LIST ==="
rg -rn 'STOP_STATUS_UTILS_UNIVERSAL_LIST' tests/
echo ""
echo "=== Files importing stop_status_utils ==="
rg -rn 'stop_status_utils' tests/
echo ""
echo "=== Files using dv_stop_status_universal_scope ==="
rg -rn 'dv_stop_status_universal_scope' tests/
echo ""
echo "=== First changed line in tests/storage/constants.py ==="
git diff HEAD~1 --unified=0 -- tests/storage/constants.py | head -20
echo ""
echo "=== Which files import from tests/storage/constants.py ==="
rg -rn 'from.*storage.*constants import|from tests.storage.constants' tests/ | head -30
echo ""
echo "=== smoke/gating markers in cdi_clone ==="
rg -rn '`@pytest.mark`\.(smoke|gating)' tests/storage/cdi_clone/Length of output: 8697 🏁 Script executed: #!/bin/bash
# Get the first changed file and first changed line for the inline comment
gh pr view 5204 --repo RedHatQE/openshift-virtualization-tests --json files --jq '.files[0]'
echo ""
echo "=== PR diff first file ==="
gh pr diff 5204 --repo RedHatQE/openshift-virtualization-tests -- tests/storage/constants.py 2>/dev/null | head -40Length of output: 510 🏁 Script executed: #!/bin/bash
# Get specific test function names around the marker lines in test_clone.py
echo "=== Context around smoke/gating markers in test_clone.py ==="
rg -n 'def test_|`@pytest.mark`\.(smoke|gating)' tests/storage/cdi_clone/test_clone.py
echo ""
echo "=== First changed lines in tests/storage/cdi_clone/conftest.py ==="
gh pr diff 5204 --repo RedHatQE/openshift-virtualization-tests -- tests/storage/cdi_clone/conftest.py 2>/dev/null | head -60
echo ""
echo "=== Get line numbers of first diff hunk ==="
git diff HEAD~1 --unified=0 -- tests/storage/cdi_clone/conftest.py | head -20Length of output: 1177 🏁 Script executed: #!/bin/bash
# Get the diff directly using git
echo "=== Git diff for conftest.py ==="
git show HEAD -- tests/storage/cdi_clone/conftest.py | head -80
echo ""
echo "=== Full conftest.py content ==="
cat tests/storage/cdi_clone/conftest.pyLength of output: 2325 🏁 Script executed: #!/bin/bash
# Get the PR details needed for inline comment - commit SHA and diff position
echo "=== PR head commit ==="
gh pr view 5204 --repo RedHatQE/openshift-virtualization-tests --json headRefOid --jq '.headRefOid'
echo ""
echo "=== PR diff for conftest.py to find position ==="
gh api repos/RedHatQE/openshift-virtualization-tests/pulls/5204/files --jq '.[] | select(.filename == "tests/storage/cdi_clone/conftest.py") | {filename, patch}' 2>/dev/null | head -60Length of output: 1839 🏁 Script executed: #!/bin/bash
# Post inline review comment on the first changed line of tests/storage/cdi_clone/conftest.py
# Diff position 5 = first added line (dv_stop_status_universal_scope_module parameter) in the first hunk
COMMENT_BODY="## Test Execution Plan
**Run smoke tests: True**
Dependency path: \`test_clone_from_block_to_fs_using_dv_template\` → \`fedora_dv_with_block_volume_mode\` fixture (modified to accept \`dv_stop_status_universal_scope_module\`) → \`dv_stop_status_checker(STOP_STATUS_UTILS_UNIVERSAL_LIST)\` in \`tests/storage/stop_status_utils.py\`
**Run gating tests: True**
- Path 1: \`test_successful_vm_restart_with_cloned_dv\` → new \`dv_stop_status_universal_scope_function\` fixture → \`dv_stop_status_checker(STOP_STATUS_UTILS_UNIVERSAL_LIST)\`
- Path 2: \`test_clone_from_fs_to_block_using_dv_template\` → \`fedora_dv_with_filesystem_volume_mode\` fixture (modified) → \`dv_stop_status_universal_scope_module\` → \`dv_stop_status_checker(STOP_STATUS_UTILS_UNIVERSAL_LIST)\`
**Affected tests to run:**
- \`tests/storage/cdi_clone/test_clone.py::test_successful_clone_of_large_image\`
- \`tests/storage/cdi_clone/test_clone.py::test_successful_vm_restart_with_cloned_dv\` (gating)
- \`tests/storage/cdi_clone/test_clone.py::test_successful_vm_from_cloned_dv_windows\`
- \`tests/storage/cdi_clone/test_clone.py::test_successful_snapshot_clone\`
- \`tests/storage/cdi_clone/test_clone.py::test_clone_from_fs_to_block_using_dv_template\` (gating)
- \`tests/storage/cdi_clone/test_clone.py::test_clone_from_block_to_fs_using_dv_template\` (smoke)"
gh api repos/RedHatQE/openshift-virtualization-tests/pulls/5204/reviews \
--method POST \
--field commit_id="3bfaa71fba6f519dc9bd444293bfdb282e300f9b" \
--field event="COMMENT" \
--field body="" \
--field "comments[][path]=tests/storage/cdi_clone/conftest.py" \
--field "comments[][position]=5" \
--field "comments[][body]=$COMMENT_BODY"Length of output: 3700 |
|
Clean rebase detected — no code changes compared to previous head ( |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In
DataVolumeobject, you can passstop_status_funcandstop_status_func_kwargsinto.wait_for_dv_successmethod and make it fail sooner than the set timeout. Thestop_status_funcis passed in the sampler and checked every second so you can inject checking DV status or if the DV creation restarted 3 times, etc. and stop it preliminary based on real status, not timeout.This will reduce the time for some storage tests because the method won't have to solely wait for timeout to fail.
Which issue(s) this PR fixes:
https://redhat.atlassian.net/browse/CNV-28143
Special notes for reviewer:
jira-ticket:
Summary by CodeRabbit