CherryPicked: [cnv-4.22] net, evpn: add source provider migration test#5206
Merged
rnetser merged 1 commit intoJun 17, 2026
Merged
Conversation
Contributor
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-2
requested review from
Anatw,
RoniKishner and
yossisegev
openshift-virtualization-qe-bot-2
requested review from
azhivovk,
frenzyfriday and
nirdothan
openshift-virtualization-qe-bot
added
the
tox:verify-tc-requirement-polarion:running
openshift-virtualization-qe-bot-2
requested review from
EdDev,
orelmisan,
rnetser and
vsibirsk
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:passed
Contributor
|
NOTE: no need to merge before GA, can be merged after. |
Contributor
|
/verified automatic cherry-pick, code is clean |
Collaborator
|
@servolkov for this PR to be merged during code freeze, an exceptino request is required |
RoniKishner
approved these changes
Jun 14, 2026
Collaborator
missed your comment |
Collaborator
|
/rebase |
##### What this PR does / why we need it:
Add source provider migration test for EVPN.
- Add VNI-aware teardown for L2 endpoints: clean up VLAN/VNI bridge
mappings,
allowing re-deployment with different parameters in the same test
session.
- Add `macAddress` field to `Interface` dataclass for explicit MAC
assignment.
- Add explicit MAC support to `deploy_evpn_l2_endpoint`.
- Add `test_source_provider_migration`: emulates migration of an
external L2
workload into the cluster as a CUDN VM, preserving its IP and MAC
addresses.
The old endpoint is torn down, a VM takes over the original identity,
then a
new L2 endpoint is deployed with different IPs to verify connectivity.
##### Which issue(s) this PR fixes:
##### Special notes for reviewer:
- `test_source_provider_migration` uses `@pytest.mark.order("last")`
because it
tears down the shared L2 endpoint, which would break other tests if run
earlier.
- IPv6 static IP fix: `random_ipv6_address()` generates addresses with a
random 7th hextet,
but OVN IPAM caps /64 allocation to 65536 addresses.
Replaced with a low-offset hardcoded address. Only affects IPs requested
via
`network.kubevirt.io/addresses`; external netns endpoints are
unaffected.
The known bug: https://redhat.atlassian.net/browse/OCPBUGS-86810
- The new L2 endpoint is created as a test step rather than a fixture.
This is a
known limitation — currently only one L2 endpoint can exist at a time. A
follow-up
will reorganise fixtures to separate VLAN lifecycle from endpoints,
enabling
independent concurrent endpoints.
##### jira-ticket: https://redhat.atlassian.net/browse/CNV-89431
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **New Features**
* VM interfaces can include an explicit MAC address; L2 endpoints accept
and apply a provided MAC.
* **Tests**
* EVPN connectivity tests now perform a full source-provider migration
end-to-end and run last.
* IPv4/IPv6 endpoint addressing is deterministic for repeatable runs.
* Tests inject endpoint MACs into VM templates and add a fixture to
provision VMs attached to external L2 endpoints.
* **Bug Fixes**
* L2 endpoint teardown now fully cleans bridge/VNI state.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Signed-off-by: Sergei Volkov <sevolkov@redhat.com>
Contributor
|
Successfully rebased |
openshift-virtualization-qe-bot-2
force-pushed
the
CherryPicked-net/evpn-source-provider-migration-4F2js
branch
from
de2c6f0 to
16eee47
Compare
Contributor
|
Clean rebase detected — no code changes compared to previous head ( |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:running
Collaborator
|
/security-override |
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:passed
Contributor
|
Security checks overridden by @rnetser. Security check runs set to pass. |
Contributor
|
/retest tox |
Collaborator
|
/rebase |
|
Successfully rebased |
Collaborator
|
/approve |
rnetser
deleted the
CherryPicked-net/evpn-source-provider-migration-4F2js
branch
Contributor
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:cnv-4.22 published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from
mainbranch, original PR: #4817, PR owner: servolkov