Skip to content

CherryPicked: [cnv-4.22] Net multi arch regression#5267

Open
cnv-tests-github-webhook-dollierp[bot] wants to merge 1 commit into
cnv-4.22from
CherryPicked-net-multi-arch-regression-2yAkj
Open

CherryPicked: [cnv-4.22] Net multi arch regression#5267
cnv-tests-github-webhook-dollierp[bot] wants to merge 1 commit into
cnv-4.22from
CherryPicked-net-multi-arch-regression-2yAkj

Conversation

@cnv-tests-github-webhook-dollierp

Copy link
Copy Markdown

Cherry-pick from main branch, original PR: #4810, PR owner: yossisegev

##### Short description:
Adjust network tests to be able to run on specific arch on multi-arch
clusters, and also handle instabilities that was exposed while working
on multi-architecture support.
##### More details:
- Support the architecture label in VM's creation
This change includes accessing `constants.Images` rather than importing
   `Images` at module level to ensure the updated Images on run-time is
     referenced.
- Stability: Remove NetworkData (for setting IP) from VM configuration
when OVN-K8s DHCP is used.
- Stability: Retrieve interface name dynamically.
##### What this PR does / why we need it:
This is required for testing regression of network tests on multi-arch
clusters.

##### jira-ticket:
https://redhat.atlassian.net/browse/CNV-80548

Signed-off-by: Yossi Segev <ysegev@redhat.com>
@openshift-virtualization-qe-bot-5

Copy link
Copy Markdown

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (approvers only)
  • /hold cancel - Unblock PR merging
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message
  • /security-override - Set security check runs to pass (maintainers only)
  • /security-override cancel - Re-run security checks

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest verify-bugs-are-open - verify-bugs-are-open
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3
  • /cherry-pick-retry <branch> - Retry a failed cherry-pick (merged PRs only)

Branch Management

  • /rebase - Rebase this PR branch onto its base branch

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. LGTM Count: Minimum 2 /lgtm from reviewers
  3. Status Checks: All required status checks must pass
  4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
  5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

  • EdDev
  • dshchedr
  • myakove
  • rnetser
  • vsibirsk

Reviewers:

  • Anatw
  • EdDev
  • RoniKishner
  • azhivovk
  • dshchedr
  • frenzyfriday
  • nirdothan
  • orelmisan
  • rnetser
  • servolkov
  • vsibirsk
  • yossisegev
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
AI Features
  • Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6[1m])
Security Checks
  • Suspicious Path Detection: Monitors paths: .claude/, .vscode/, .cursor/, .devcontainer/, .pi/, .github/workflows/, .github/actions/
  • Committer Identity Check: Verifies last committer matches PR author
  • Mandatory: Security checks block merge (use /security-override to bypass — maintainers only)

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

@openshift-virtualization-qe-bot

Copy link
Copy Markdown

/build-and-push-container

@openshift-virtualization-qe-bot-4

Copy link
Copy Markdown

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5267 published

@openshift-virtualization-qe-bot

Copy link
Copy Markdown

Verification failed for PR #5267.
Result: FAILURE
Job: openshift-virtualization-tests-runner #5720

Execution details
pytest -s -o log_cli=true -m tier2 --jira --skip-deprecated-api-test --cluster-sanity-skip-storage-check -m 'single_nic --tc-file=tests/global_config_amd64.py --cpu-arch=amd64 tests/network/user_defined_network/ip_specification/test_ip_specification.py
(9 parameters hidden from public report)
Image: openshift-virtualization-tests:pr-5267

@openshift-virtualization-qe-bot

Copy link
Copy Markdown

/build-and-push-container

@openshift-virtualization-qe-bot

Copy link
Copy Markdown

Verification failed for PR #5267.
The pipeline did not reach the test execution stage.

Execution details
pytest -s -o log_cli=true -m tier2 --jira --skip-deprecated-api-test --cluster-sanity-skip-storage-check -m 'single_nic --tc-file=tests/global_config_arm64.py --cpu-arch=arm64 tests/network/user_defined_network/ip_specification/test_ip_specification.py
(9 parameters hidden from public report)

@openshift-virtualization-qe-bot-5

Copy link
Copy Markdown

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5267 published

@yossisegev

Copy link
Copy Markdown
Contributor

/verified

Verified the same way the parent PR was verified - by running the tests on 3 different setups, making sure the tests are passing and that the VM spec is created with the expected .architecture field.

  1. On multi arch-cluster: --tc-file=tests/global_config_arm64.py --cpu-arch=arm64: VM created with architecture: arm64
  2. On multi arch-cluster: --tc-file=tests/global_config_amd64.py --cpu-arch=amd64: VM created with architecture: amd64
  3. On homogeneous cluster: No arch argument sent -> VM spec created without .specarchitecture`

@rnetser

rnetser commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants