Fix outdated branded strings for oVirt and OpenStack and fix broken docs link#51
Conversation
Thorben-D
force-pushed
the
fixes/update_branded_strings
branch
from
10946db to
75aaf23
Compare
|
Another rebase needed, sorry! |
Thorben-D
force-pushed
the
fixes/update_branded_strings
branch
from
75aaf23 to
2fabc8d
Compare
ShimShtein
left a comment
ShimShtein
left a comment
There was a problem hiding this comment.
LGTM. Any additional concerns?
|
@Thorben-D Please make sure the tests are green |
Thorben-D
force-pushed
the
fixes/update_branded_strings
branch
from
2fabc8d to
712fcc6
Compare
| /\b[Pp]roxy [Hh][Tt][Tt][Pp]\b(?!-)/ => 'Proxy HTTP', # Workaround for French translation | ||
| /\b[Pp]roxies [Hh][Tt][Tt][Pp]\b(?!-)/ => 'Proxies HTTP', # Workaround for French translation |
There was a problem hiding this comment.
We still need those, otherwise in French Proxies HTTP will be branded as Capsules HTTP (which is wrong).
There was a problem hiding this comment.
Oh right, I forgot French does this...
While we're at it, what about "non-latin alphabet" languages? I noticed that in, for example, Russian, "Create Smart Proxy" is translated to "Создать Смарт Прокси", which will definitely not be branded correctly.
Are there any plans on covering these languages? Otherwise, I'd check it out myself.
There was a problem hiding this comment.
My assumption was (and I have actually outlined it in the redme) that we don't want to translate names.
Meaning that we should translate "Create Smart Proxy" to "Создать Smart Proxy".
I know that for Hebrew for example we do leave Latin names for such things. I have to admit I am not sure if it is considered an OK practice in other languages.
There was a problem hiding this comment.
I very much agree with the idea of not translating names. I checked the translation files and found the following:
Note: for most of these I had to rely on DeepL, so no promises...
| Language | Translation of "Smart Proxy" | Translation into English |
|---|---|---|
| Catalan | servidor intermediari intel·ligent | smart proxy server |
| Czech | none | none |
| German | none | none |
| English (US) | none | none |
| English (UK) | none | none |
| Spanish | proxy inteligente | smart proxy |
| Italian | none | none |
| Japanese | none | none |
| Georgian | ჭკვიანი პროქსი | smart proxy |
| Korean | 스마트 프록시 | smart proxy |
| Polish | smart proxy / inteligentnych proxy | smart proxy |
| Portuguese (BR) | smart proxy / proxy Inteligente | smart proxy |
| Russian | Смарт Прокси | smart proxy |
| Chinese (ZN) | 智能代机 | smart proxy |
| Chinese (TW) | 智慧型代理伺服器 | smart proxy server |
There was a problem hiding this comment.
Hmm.. Interesting. I see in Russian and Korean it's just a transliteration (It's the same text, just in Cyrillic/Korean letters) for other languages here it's actually a translation: (Smart -> Intelligent). And for Georgian it's a mix - "Proxy" is transliterated, but "Smart" is translated.
Specifically for our issue, Polish and Portuguese may become problematic, since they would be branded as "Capsule Inteligente" for Portuguese.
There was a problem hiding this comment.
I very much agree with the idea of not translating names. I checked the translation files and found the following:
I would expect all of them to be in the glossary:
https://app.transifex.com/foreman/foreman_2013-08-14/translate/#en/foreman_2013-08-14?q=text%3Asmart
Yet when I check some languages I don't see them.
Thorben-D
force-pushed
the
fixes/update_branded_strings
branch
from
712fcc6 to
e428bfc
Compare
ShimShtein
left a comment
ShimShtein
left a comment
There was a problem hiding this comment.
A couple of small changes please.
Thorben-D
force-pushed
the
fixes/update_branded_strings
branch
from
e428bfc to
df955d4
Compare
| /\bOpenStack\b(?!-)/ => 'RHEL OpenStack Platform', | ||
| /\bopenstack\b(?!-)/ => 'RHEL OpenStack Platform', | ||
| /\bOpenstack\b(?!-)/ => 'RHEL OpenStack Platform', | ||
| /\bProxy\b(?!-)/ => 'Capsule', |
There was a problem hiding this comment.
We still need those, while imprecise string are in the core.
There was a problem hiding this comment.
I re-added a check for proxy/proxies. OpenStack branding is already covered by line 35.
- Red Hat Virtualization: Change from "RHEV" to "RHV" - Red Hat Openstack Platform: Change from "RHEL Openstack Platform" to "Red Hat Openstack Platform" - Fix link to docs for registering hosts using bootstrap script - Simplify regular expressions - Add test based on documentation strings
Thorben-D
force-pushed
the
fixes/update_branded_strings
branch
from
df955d4 to
bea4169
Compare
4 participants
While investigating how this plugin handles downstream branding, I noticed that some branded words are out of date.