feature: minor code improves

Author: EmogurovAnton

panel-core/src/main/kotlin/com/redmadrobot/debug/core/DebugPanel.kt

@@ -14,6 +14,7 @@ import kotlinx.coroutines.flow.emptyFlow
 
 @OptIn(DebugPanelInternal::class)
 public object DebugPanel {
+    @Volatile
     private var instance: DebugPanelInstance? = null
     public val isInitialized: Boolean
         get() = instance != null
@@ -40,6 +41,8 @@ public object DebugPanel {
         }
     }
 
+    internal fun getInstance(): DebugPanelInstance? = instance
+
     private fun openDebugPanel(activity: Activity) {
         val intent = Intent(activity, DebugPanelActivity::class.java)
         activity.startActivity(intent)

panel-core/src/main/kotlin/com/redmadrobot/debug/core/DebugPanelInstance.kt

@@ -26,7 +26,6 @@ internal class DebugPanelInstance(
     init {
         initContainer(application.applicationContext)
         initPluginManager(plugins, requireNotNull(commonContainer))
-        instance = this
     }
 
     internal fun getEventLiveData(): LiveData<DebugEvent> {
@@ -42,7 +41,7 @@ internal class DebugPanelInstance(
         eventSharedFlow.tryEmit(debugEvent)
     }
 
-    internal fun getPluginManger(): PluginManager {
+    internal fun getPluginManager(): PluginManager {
         return pluginManager
             ?: error("PluginManager not initialised")
     }
@@ -59,8 +58,4 @@ internal class DebugPanelInstance(
             start(commonContainer)
         }
     }
-
-    companion object {
-        var instance: DebugPanelInstance? = null
-    }
 }

panel-core/src/main/kotlin/com/redmadrobot/debug/core/extension/PluginsExt.kt

@@ -1,17 +1,17 @@
 package com.redmadrobot.debug.core.extension
 
-import com.redmadrobot.debug.core.DebugPanelInstance
+import com.redmadrobot.debug.core.DebugPanel
 import com.redmadrobot.debug.core.annotation.DebugPanelInternal
 import com.redmadrobot.debug.core.plugin.Plugin
 
 @PublishedApi
 internal fun getPlugin(pluginName: String): Plugin {
-    val plugin = DebugPanelInstance.instance?.getPluginManger()?.findPluginByName(pluginName)
+    val plugin = DebugPanel.getInstance()?.getPluginManager()?.findPluginByName(pluginName)
     return requireNotNull(plugin)
 }
 
 internal fun getAllPlugins(): List<Plugin> {
-    return DebugPanelInstance.instance?.getPluginManger()?.plugins ?: emptyList()
+    return DebugPanel.getInstance()?.getPluginManager()?.plugins ?: emptyList()
 }
 
 @DebugPanelInternal

panel-core/src/main/kotlin/com/redmadrobot/debug/core/plugin/Plugin.kt

@@ -2,7 +2,7 @@ package com.redmadrobot.debug.core.plugin
 
 import androidx.compose.runtime.Composable
 import com.redmadrobot.debug.core.DebugEvent
-import com.redmadrobot.debug.core.DebugPanelInstance
+import com.redmadrobot.debug.core.DebugPanel
 import com.redmadrobot.debug.core.internal.CommonContainer
 import com.redmadrobot.debug.core.internal.PluginDependencyContainer
 
@@ -15,7 +15,7 @@ public abstract class Plugin {
     }
 
     public fun pushEvent(debugEvent: DebugEvent) {
-        DebugPanelInstance.instance?.pushEvent(debugEvent)
+        DebugPanel.getInstance()?.pushEvent(debugEvent)
     }
 
     public fun <T> getContainer(): T = pluginContainer as T

panel-core/src/main/kotlin/com/redmadrobot/debug/core/util/ApplicationLifecycleHandler.kt

@@ -7,12 +7,13 @@ import android.content.IntentFilter
 import androidx.activity.ComponentActivity
 import androidx.core.content.ContextCompat
 import timber.log.Timber
+import java.util.concurrent.atomic.AtomicInteger
 
 internal class ApplicationLifecycleHandler(
     private val application: Application,
 ) {
     // open Activity counter
-    private var openActivityCount = 0
+    private val openActivityCounter = AtomicInteger(0)
 
     private var debugPanelBroadcastReceiver: BroadcastReceiver? = null
     private val debugPanelNotification = DebugPanelNotification(application.applicationContext)
@@ -25,8 +26,7 @@ internal class ApplicationLifecycleHandler(
         application.registerActivityLifecycleCallbacks(
             object : ActivityLifecycleCallbacksAdapter() {
                 override fun onActivityResumed(activity: Activity) {
-                    if (openActivityCount == 0) onAppResumed()
-                    ++openActivityCount
+                    if (openActivityCounter.getAndIncrement() == 0) onAppResumed()
 
                     // register BroadcastReceiver for debug panel inner actions
                     debugPanelBroadcastReceiver = DebugPanelBroadcastReceiver(activity)
@@ -41,11 +41,10 @@ internal class ApplicationLifecycleHandler(
                 }
 
                 override fun onActivityPaused(activity: Activity) {
-                    --openActivityCount
                     (activity as? ComponentActivity)?.let {
                         activity.unregisterReceiver(debugPanelBroadcastReceiver)
                     }
-                    if (openActivityCount == 0) onAppPaused()
+                    if (openActivityCounter.decrementAndGet() == 0) onAppPaused()
                 }
             }
         )

panel-core/src/main/kotlin/com/redmadrobot/debug/core/util/DebugPanelNotification.kt

@@ -27,9 +27,9 @@ internal class DebugPanelNotification(private val context: Context) {
         }
 
     fun show() {
-        val isPermissionGranted = Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU &&
+        val isPermissionDenied = Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU &&
             ContextCompat.checkSelfPermission(context, POST_NOTIFICATIONS) != PERMISSION_GRANTED
-        if (isPermissionGranted) return
+        if (isPermissionDenied) return
 
         notificationManager = NotificationManagerCompat.from(context)
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {