refactor: clean up environment variables and update internal service URL handling

Author: aliyuldashev

.env.example

@@ -20,20 +20,3 @@ DEBUG=false
 # RT_EPOCH_LENGTH=1200
 RT_STORAGE_API_URL="https://storage-api.theredteam.io"
 
-
-## -- Challenge configs -- ##
-# CHALLENGE_API_KEY="changeme"
-# CHALLENGE_VERIFICATION_API_KEY="changeme"
-# RT_CHALLENGE_LOGS_DIR=volumes/storage/agent.miner/logs
-# CHALLENGE_VERIFICATION_ENDPOINT="http://localhost:8000/verify"
-# CHALLENGE_VERIFICATION_STARTUP_URL="http://localhost:8000/startup"
-
-## -- AAD Challenge configs -- ##
-# AAD_CHALLENGE_NSTBROWSER_API_KEY="changeme"
-# AAD_CHALLENGE_NSTBROWSER_HOST=localhost
-# AAD_CHALLENGE_NSTBROWSER_PORT=9222
-# AAD_CHALLENGE_NSTBROWSER_PROTOCOL=http
-
-## -- DFP Challenge configs -- ##
-# DFP_CHALLENGE_PROXY_INTER_BASE_URL=http://192.193.123.01:8000
-# DFP_API_DEVICES_PATH=/src/challenges/dev_fingerprinter/devices.json

src/challenges/dev_fingerprinter

@@ -371,7 +371,9 @@ def _validate_miner_submission(self, miner_commit: MinerChallengeCommit) -> bool
             payload = {
                 "miner_script": _miner_script,
             }
-            _internal_services_url = constants.INTERNAL_SERVICES.API_URL
+            _internal_services_url = str(constants.INTERNAL_SERVICES.API_URL).rstrip(
+                "/"
+            )
             _validator_endpoint = f"{_internal_services_url}/check/challenge/{self.challenge_info.get('challenge_type', 'default')}/"
             headers = {
                 "Content-Type": "application/json",
@@ -506,9 +508,9 @@ def _compare_with_baseline(self, miner_commit: MinerChallengeCommit):
                 "Content-Type": "application/json",
                 "X-API-KEY": constants.INTERNAL_SERVICES.API_KEY,
             }
-
+            _internal_service_url = str(constants.INTERNAL_SERVICES.API_URL).rstrip("/")
             response = requests.post(
-                f"{constants.INTERNAL_SERVICES.API_URL}/compare/baseline-scripts",
+                f"{_internal_service_url}/compare/baseline-scripts",
                 timeout=self.challenge_info.get("challenge_compare_timeout", 150),
                 verify=False,
                 json=payload,