[add] added jmh microbenchmark, changed addDocuments to make usage of…#75
Open
filipecosta90 wants to merge 3 commits intoRediSearch:masterfrom
Open
[add] added jmh microbenchmark, changed addDocuments to make usage of…#75filipecosta90 wants to merge 3 commits intoRediSearch:masterfrom
filipecosta90 wants to merge 3 commits intoRediSearch:masterfrom
Conversation
… pipelining, bumped jedis version from 3.01 to 3.1.0
gkorland
suggested changes
Sep 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 80.93% 80.93%
=======================================
Files 34 34
Lines 1385 1385
Branches 203 202 -1
=======================================
Hits 1121 1121
Misses 190 190
Partials 74 74
Continue to review full report at Codecov.
|
gkorland
reviewed
Sep 18, 2019
| <aggregate>true</aggregate> | ||
| <additionalparam>-Xdoclint:none</additionalparam> | ||
| <additionalOptions>-Xdoclint:none</additionalOptions> | ||
| <!-- <additionalOptions>-Xdoclint:none</additionalOptions>--> |
Contributor
There was a problem hiding this comment.
@filipecosta90 you can just remove this duplication
Contributor
|
@filipecosta90 notice the build issue |
gkorland
reviewed
Sep 18, 2019
| .forks(5) | ||
| .build(); | ||
|
|
||
| new Runner(opt).run(); |
Contributor
There was a problem hiding this comment.
is it a deamon thread? do you need to "join" on it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[add] added jmh microbenchmark for document ingestion
[upg] bumped jedis version from 3.01 to 3.1.0 ( to access sendCommand on Pipeline)
[add] changed addDocuments to make usage of pipelining ( see Client_addDocuments vs Client_addDocument microbenchmark ), leading to 16.4K OPS with Client_addDocument vs 18.3K OPS with Client_addDocuments
Client_addDocuments vs Client_addDocument microbenchmark
OSS redis-server + RediSearch ( current master ) runned with the following configs
Benchmark runned via:
output: