Skip to content

Attempt to log process outputs when stuck on termination #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuyAv46 merged 1 commit into from
Jul 2, 2025
Merged

Attempt to log process outputs when stuck on termination #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions RLTest/redis_std.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,11 +468,13 @@ def _stopProcess(self, role):
if self.terminateRetries is None:
# ask once, then wait for process to exit
process.terminate()
while True:
if process.poll() is None: # None returns if the processes is not finished yet, retry until redis exits
time.sleep(0.1)
else:
break
termination_start_time = time.time()
while process.poll() is None: # None returns if the processes is not finished yet, retry until redis exits
time.sleep(0.1)
if time.time() - termination_start_time > 30:
# if process is still running after 30 seconds, try reading its output
process_out, process_err = process.communicate()
print(Colors.Bred(f'\t[TERMINATING] out ({process_out}), error ({process_err})'))
else:
# keep asking every few seconds until process has exited, otherwise kill
if self.terminateRetrySecs is None:
Expand Down
Loading