fix: fixed an issue with oneOf and readOnly/writeOnly (#130)

Co-authored-by: Olivier Beaulieu <olivier@synctera.com>

Author: olivierbeaulieu

src/traverse.js

@@ -105,7 +105,16 @@ export function traverse(schema, options, spec, context) {
       if (!options.quiet) console.warn('oneOf and anyOf are not supported on the same level. Skipping anyOf');
     }
     popSchemaStack(seenSchemasStack, context);
-    return tryInferExample(schema) || traverse(schema.oneOf[0], options, spec, context);
+
+    // Make sure to pass down readOnly and writeOnly annotations from the parent
+    const firstOneOf = Object.assign({
+      readOnly: schema.readOnly,
+      writeOnly: schema.writeOnly
+    }, schema.oneOf[0]);
+
+    return (
+      tryInferExample(schema) || traverse(firstOneOf, options, spec, context)
+    );
   }
 
   if (schema.anyOf && schema.anyOf.length) {

test/unit/object.spec.js

@@ -44,6 +44,42 @@ describe('sampleObject', () => {
     });
   });
 
+  it('should skip readonly properties in oneOfs if skipReadOnly=true', () => {
+    res = sampleObject(
+      {
+        properties: {
+          a: { type: 'string' },
+          b: {
+            type: 'object',
+            oneOf: [
+              {
+                type: 'object',
+                properties: {
+                  c: {
+                    type: 'string',
+                  },
+                },
+              },
+              {
+                type: 'object',
+                properties: {
+                  d: {
+                    type: 'string',
+                  },
+                },
+              },
+            ],
+            readOnly: true,
+          },
+        },
+      },
+      { skipReadOnly: true }
+    );
+    expect(res).to.deep.equal({
+      a: 'string',
+    });
+  });
+
   it('should skip writeonly properties if writeonly=true', () => {
     res = sampleObject({properties: {
       a: {type: 'string'},
@@ -70,6 +106,42 @@ describe('sampleObject', () => {
     });
   });
 
+   it('should skip writeonly properties in oneOfs if skipReadOnly=true', () => {
+     res = sampleObject(
+       {
+         properties: {
+           a: { type: 'string' },
+           b: {
+             type: 'object',
+             oneOf: [
+               {
+                 type: 'object',
+                 properties: {
+                   c: {
+                     type: 'string',
+                   },
+                 },
+               },
+               {
+                 type: 'object',
+                 properties: {
+                   d: {
+                     type: 'string',
+                   },
+                 },
+               },
+             ],
+             writeOnly: true,
+           },
+         },
+       },
+       { skipWriteOnly: true }
+     );
+     expect(res).to.deep.equal({
+       a: 'string',
+     });
+   });
+
   it('should should instantiate 2 additionalProperties', () => {
     res = sampleObject({additionalProperties: {type: 'string'}});
     expect(res).to.deep.equal({