feat: implement new rule to check illogical usage of composition keywords

feat: add proper check for mutually exclusive schemas in oneOf

feat: add checks for object min/max props, required props and additionlProperties

feat: add rule to the oas3_2 spec

refactor: functions naming and returning type

refactor: change if statement

refactor: move areDuplicatedSchemas function to utility and change naming

feat: add new rule no-illogical-any-of-usage

chore: add new rule to type

fix: getEffectiveBounds functionality, pattern check and mutualExclusibity check

feat: add functionality to report more then 1 problem

chore: improve warning messages

feat: add proper checks, refactor and change error messages

fix: error message in areDuplicatedSchemas

refactor: move logic into main function, add helper function, rename utility function

refactor: change naming and functionality for duplicated shcemas function

refactor: nullable function and return statement

fix: nullable type detection

refactor: add utility functions

refactor: remove functions, clean code, refactor additionalProperties

refactor: functions naming, if statement

chore: remove oneOf/anyOf/allOf separate rules and add one to handle different behavior

feat: add proper handling for additionalProperties

chore: update type

feat: add functionality to handle anyOf and allOf checks

Author: AlbinaBlazhko17

packages/core/src/config/all.ts

@@ -118,6 +118,7 @@ const all: RawGovernanceConfig<'built-in'> = {
     'tags-alphabetical': 'error',
     'no-duplicated-tag-names': 'error',
     'spec-example-values': 'error',
+    'no-illogical-composition-keywords': 'error',
   },
   oas3_1Rules: {
     'array-parameter-serialization': 'error',
@@ -181,6 +182,7 @@ const all: RawGovernanceConfig<'built-in'> = {
     'tags-alphabetical': 'error',
     'no-duplicated-tag-names': 'error',
     'spec-example-values': 'error',
+    'no-illogical-composition-keywords': 'error',
   },
   oas3_2Rules: {
     'array-parameter-serialization': 'error',
@@ -246,6 +248,7 @@ const all: RawGovernanceConfig<'built-in'> = {
     'spec-no-invalid-encoding-combinations': 'error',
     'spec-discriminator-defaultMapping': 'error',
     'spec-example-values': 'error',
+    'no-illogical-composition-keywords': 'error',
   },
   async2Rules: {
     'channels-kebab-case': 'error',

packages/core/src/config/minimal.ts

@@ -109,6 +109,7 @@ const minimal: RawGovernanceConfig<'built-in'> = {
     'tags-alphabetical': 'off',
     'no-duplicated-tag-names': 'off',
     'spec-example-values': 'off',
+    'no-illogical-composition-keywords': 'off',
   },
   oas3_1Rules: {
     'array-parameter-serialization': 'off',
@@ -165,6 +166,7 @@ const minimal: RawGovernanceConfig<'built-in'> = {
     'tag-description': 'warn',
     'tags-alphabetical': 'off',
     'no-duplicated-tag-names': 'off',
+    'no-illogical-composition-keywords': 'off',
     'spec-example-values': 'off',
   },
   oas3_2Rules: {
@@ -221,6 +223,7 @@ const minimal: RawGovernanceConfig<'built-in'> = {
     'tag-description': 'warn',
     'tags-alphabetical': 'off',
     'no-duplicated-tag-names': 'off',
+    'no-illogical-composition-keywords': 'off',
     'spec-no-invalid-tag-parents': 'warn',
     'spec-no-invalid-encoding-combinations': 'warn',
     'spec-discriminator-defaultMapping': 'off',

packages/core/src/config/recommended-strict.ts

@@ -109,6 +109,7 @@ const recommendedStrict: RawGovernanceConfig<'built-in'> = {
     'tags-alphabetical': 'off',
     'no-duplicated-tag-names': 'error',
     'spec-example-values': 'off',
+    'no-illogical-composition-keywords': 'error',
   },
   oas3_1Rules: {
     'array-parameter-serialization': 'off',
@@ -165,6 +166,7 @@ const recommendedStrict: RawGovernanceConfig<'built-in'> = {
     'tag-description': 'error',
     'tags-alphabetical': 'off',
     'no-duplicated-tag-names': 'error',
+    'no-illogical-composition-keywords': 'error',
     'spec-example-values': 'off',
   },
   oas3_2Rules: {
@@ -221,6 +223,7 @@ const recommendedStrict: RawGovernanceConfig<'built-in'> = {
     'tag-description': 'error',
     'tags-alphabetical': 'off',
     'no-duplicated-tag-names': 'error',
+    'no-illogical-composition-keywords': 'error',
     'spec-no-invalid-tag-parents': 'error',
     'spec-no-invalid-encoding-combinations': 'error',
     'spec-discriminator-defaultMapping': 'error',

packages/core/src/config/recommended.ts

@@ -109,6 +109,7 @@ const recommended: RawGovernanceConfig<'built-in'> = {
     'tags-alphabetical': 'off',
     'no-duplicated-tag-names': 'warn',
     'spec-example-values': 'off',
+    'no-illogical-composition-keywords': 'warn',
   },
   oas3_1Rules: {
     'array-parameter-serialization': 'off',
@@ -166,6 +167,7 @@ const recommended: RawGovernanceConfig<'built-in'> = {
     'tags-alphabetical': 'off',
     'no-duplicated-tag-names': 'warn',
     'spec-example-values': 'off',
+    'no-illogical-composition-keywords': 'warn',
   },
   oas3_2Rules: {
     'array-parameter-serialization': 'off',
@@ -225,6 +227,7 @@ const recommended: RawGovernanceConfig<'built-in'> = {
     'spec-no-invalid-encoding-combinations': 'error',
     'spec-discriminator-defaultMapping': 'warn',
     'spec-example-values': 'error',
+    'no-illogical-composition-keywords': 'warn',
   },
   async2Rules: {
     'channels-kebab-case': 'off',

packages/core/src/config/spec.ts

@@ -109,6 +109,7 @@ const spec: RawGovernanceConfig<'built-in'> = {
     'tags-alphabetical': 'off',
     'nullable-type-sibling': 'error',
     'spec-example-values': 'off',
+    'no-illogical-composition-keywords': 'off',
   },
   oas3_1Rules: {
     'array-parameter-serialization': 'off',
@@ -166,6 +167,7 @@ const spec: RawGovernanceConfig<'built-in'> = {
     'tag-description': 'off',
     'tags-alphabetical': 'off',
     'spec-example-values': 'off',
+    'no-illogical-composition-keywords': 'error',
   },
   oas3_2Rules: {
     'array-parameter-serialization': 'off',
@@ -225,6 +227,7 @@ const spec: RawGovernanceConfig<'built-in'> = {
     'spec-no-invalid-encoding-combinations': 'error',
     'spec-discriminator-defaultMapping': 'error',
     'spec-example-values': 'error',
+    'no-illogical-composition-keywords': 'error',
   },
   async2Rules: {
     'channels-kebab-case': 'off',

packages/core/src/rules/oas3/index.ts

@@ -59,6 +59,7 @@ import { SpecNoInvalidTagParents } from './spec-no-invalid-tag-parents.js';
 import { SpecNoInvalidEncodingCombinations } from './spec-no-invalid-encoding-combinations.js';
 import { SpecDiscriminatorDefaultMapping } from './spec-discriminator-defaultMapping.js';
 import { SpecExampleValues } from './spec-example-values.js';
+import { NoIllogicalCompositionKeywords } from './no-illogical-composition-keywords.js';
 
 import type { Oas3RuleSet } from '../../oas-types.js';
 import type { Oas3Rule } from '../../visitors.js';
@@ -126,6 +127,7 @@ export const rules: Oas3RuleSet<'built-in'> = {
   'spec-no-invalid-encoding-combinations': SpecNoInvalidEncodingCombinations,
   'spec-discriminator-defaultMapping': SpecDiscriminatorDefaultMapping,
   'spec-example-values': SpecExampleValues,
+  'no-illogical-composition-keywords': NoIllogicalCompositionKeywords,
 };
 
 export const preprocessors = {};