chore: add support for entity files node types and validation#2377
Merged
Conversation
🦋 Changeset detectedLatest commit: 830ee3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
tatomyr
requested changes
Oct 22, 2025
kamil1094
marked this pull request as ready for review
October 24, 2025 13:01
JLekawa
approved these changes
Oct 24, 2025
vadyvas
reviewed
Oct 28, 2025
tatomyr
reviewed
Oct 28, 2025
tatomyr
left a comment
tatomyr
left a comment
Collaborator
There was a problem hiding this comment.
Looks much better. I left a couple of comments, will take another turn tomorrow.
vadyvas
reviewed
Oct 29, 2025
vadyvas
reviewed
Oct 29, 2025
tatomyr
reviewed
Oct 29, 2025
tatomyr
left a comment
tatomyr
left a comment
Collaborator
There was a problem hiding this comment.
Left a comment. Otherwise LGTM.
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
tatomyr
reviewed
Oct 29, 2025
tatomyr
reviewed
Oct 29, 2025
tatomyr
requested changes
Oct 29, 2025
tatomyr
left a comment
tatomyr
left a comment
Collaborator
There was a problem hiding this comment.
I took another look and found that you used config improperly. Left another portion of comments. Sorry, I didn't notice that in the previous run.
tatomyr
reviewed
Oct 29, 2025
tatomyr
left a comment
tatomyr
left a comment
Collaborator
There was a problem hiding this comment.
One more portion of comments, and I think it's fine.
Collaborator
|
Please confirm you've checked the changes in our internal products, and check other checkmarks if needed: 
|
tatomyr
approved these changes
Oct 29, 2025
tatomyr
left a comment
tatomyr
left a comment
Collaborator
There was a problem hiding this comment.
Left minor comments. Otherwise looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Added 2 new methods to support validation and autocompletion of catalog entities files:
createEntityTypes- method creating node types for entity files validation and autocompletionlintEntityFile- method for validating entity file, returning problems for single object files and for files containing arrays of entitiesReference
Testing
Screenshots (optional)
Check yourself
Security