feat: implement scorecard-classic command - #2433
Conversation
🦋 Changeset detectedLatest commit: c182102 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
031a5a1 to
80fc819
Compare
| ? await evaluatePluginsFromCode(pluginsCodeOrPlugins) | ||
| : pluginsCodeOrPlugins; | ||
|
|
||
| const config = await createConfig({ ...level, plugins } as RawUniversalConfig, { |
There was a problem hiding this comment.
Just an open question.
So are we going to ignore local config in case when scorecards defined?
There was a problem hiding this comment.
yes, if scorecard is defined -- use it instead of the local config (for scorecards).
| export async function handleLoginAndFetchToken(config: Config): Promise<string | undefined> { | ||
| const reuniteUrl = getReuniteUrl(config, config.resolvedConfig?.residency); | ||
|
|
||
| const oauthClient = new RedoclyOAuthClient(); |
There was a problem hiding this comment.
Cannot we just re-use the login handler if the user is not authenticated?
There was a problem hiding this comment.
No, we cannot, because login handler doesn't check if we already store the credentials and they are exist.
What/Why/How?
scorecard-classic.Reference
Related: https://github.com/Redocly/redocly/issues/8775
Testing
Ran tests.
Screenshots (optional)
Check yourself
Security