chore: add an alias for ajv - #2445
Conversation
|
834668e to
ada5b8d
Compare
|
The same issue also affects
Cannot find module 'ajv/dist/compile/codegen' Could you also apply the same fix to "ajv": "npm:@redocly/ajv@8.17.1"
This would ensure both respect-core and openapi-core properly provide ajv for their transitive dependencies. |
|
Sure thing I can do that, I can also add core-js as it seems to be a problem which I described in the issue |
524dfdb to
2cc9060
Compare
|
after applying the patch here is how everything looks like: ❯ npm ls ajv
@redocly/cli@2.0.0 /Users/aklkv/Projects/github/redocly-cli
└─┬ @redocly/cli@2.14.3 -> ./packages/cli
├─┬ @redocly/openapi-core@2.14.3 -> ./packages/core
│ └── ajv@npm:@redocly/ajv@8.17.1
├─┬ @redocly/respect-core@2.14.3 -> ./packages/respect-core
│ ├── ajv@npm:@redocly/ajv@8.17.1
│ └─┬ better-ajv-errors@1.2.0
│ └── ajv@6.12.6
└─┬ ajv-formats@3.0.1
└── ajv@8.17.1
❯ npm ls @redocly/ajv
@redocly/cli@2.0.0 /Users/aklkv/Projects/github/redocly-cli
└─┬ @redocly/cli@2.14.3 -> ./packages/cli
├─┬ @redocly/openapi-core@2.14.3 -> ./packages/core
│ └── @redocly/ajv@8.17.1
├─┬ @redocly/respect-core@2.14.3 -> ./packages/respect-core
│ └── @redocly/ajv@8.17.1 deduped
└─┬ redoc@2.5.1
└─┬ @redocly/openapi-core@1.34.6
└── @redocly/ajv@8.17.1 deduped
❯ npm ls core-js
@redocly/cli@2.0.0 /Users/aklkv/Projects/github/redocly-cli
└─┬ @redocly/cli@2.14.3 -> ./packages/cli
├── core-js@3.47.0
└─┬ redoc@2.5.1
└── core-js@3.47.0 deduped |
|
@aklkv thanks for the contribution Could you please update Also, please remove |
2cc9060 to
bb9826d
Compare
|
LGTM👍 |
Co-authored-by: aklkv <312210+aklkv@users.noreply.github.com>
bb9826d to
b12dccc
Compare
What/Why/How?
Added
ajvas a direct dependency to@redocly/respect-corepackage.Why: The package uses
better-ajv-errorswhich declaresajvas a peer dependency. Withoutajvas a direct dependency, users encounter peer dependency warnings and installation failures when installing@redocly/respect-core.How: Added
"ajv": "npm:@redocly/ajv@8.17.1"to the dependencies inpackages/respect-core/package.json, matching the version of@redocly/ajvalready in use.Reference
Fixes #2444
Testing
ajvis now listed in dependencies^8.17.1satisfiesbetter-ajv-errorspeer dependency requirement (4.11.8 - 8)ajvis already used transitively via@redocly/ajvScreenshots (optional)
N/A
Check yourself
Security