fix(core): fix bug loading of `.redocly.lint-ignore.yaml` in browser environments by kanoru3101 · Pull Request #2489 · Redocly/redocly-cli

kanoru3101 · 2026-01-07T15:54:31Z

What/Why/How?

Fixed loading of .redocly.lint-ignore.yaml in browser environments (Reunite).

Reference

#86
Related PR

Testing

Screenshots (optional)

Check yourself

Code changed? - Tested with Redoc/Realm/Reunite (internal)
All new/updated code is covered by tests
New package installed? - Tested in different environments (browser/node)
Documentation update considered

Security

The security impact of the change has been considered
Code follows company security practices and guidelines

changeset-bot · 2026-01-07T15:54:35Z

🦋 Changeset detected

Latest commit: 876d5ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@redocly/openapi-core	Patch
@redocly/cli	Patch
@redocly/respect-core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-01-07T15:56:44Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	78.6% (🎯 78%)	6203 / 7891
🔵	Statements	78.03% (🎯 78%)	6408 / 8212
🔵	Functions	81.98% (🎯 81%)	1265 / 1543
🔵	Branches	70.39% (🎯 70%)	4256 / 6046

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/core/src/ref-utils.ts	90%	97.72%	94.73%	91.66%	10, 51, 75-76
packages/core/src/config/config.ts	65.07%	65.94%	77.5%	65.68%	190-214, 240, 244, 248-266, 298, 316-336, 415-445
packages/core/src/config/load.ts	87.5%	69.56%	100%	90.32%	34, 59, 83, 126

Generated in workflow #8370 for commit 876d5ec by the Vitest Coverage Report Action

github-actions · 2026-01-07T15:56:50Z

CLI Version	Mean Time ± Std Dev (s)	Relative Performance (Lower is Faster)
cli-latest	3.415s ± 0.032s	▓ 1.00x (Fastest)
cli-next	3.450s ± 0.032s	▓ 1.01x

github-actions · 2026-01-07T16:50:24Z

📦 A new experimental 🧪 version v0.0.0-snapshot.1767804621 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/cli@0.0.0-snapshot.1767804621
# or
npm install @redocly/openapi-core@0.0.0-snapshot.1767804621
# or
npm install @redocly/respect-core@0.0.0-snapshot.1767804621

⚠️ Note: This is a development build and may contain unstable features.

github-actions · 2026-01-07T17:43:13Z

📦 A new experimental 🧪 version v0.0.0-snapshot.1767807792 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/cli@0.0.0-snapshot.1767807792
# or
npm install @redocly/openapi-core@0.0.0-snapshot.1767807792
# or
npm install @redocly/respect-core@0.0.0-snapshot.1767807792

⚠️ Note: This is a development build and may contain unstable features.

github-actions · 2026-01-08T09:54:11Z

📦 A new experimental 🧪 version v0.0.0-snapshot.1767866050 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/cli@0.0.0-snapshot.1767866050
# or
npm install @redocly/openapi-core@0.0.0-snapshot.1767866050
# or
npm install @redocly/respect-core@0.0.0-snapshot.1767866050

⚠️ Note: This is a development build and may contain unstable features.

github-actions · 2026-01-08T11:10:20Z

📦 A new experimental 🧪 version v0.0.0-snapshot.1767870619 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/cli@0.0.0-snapshot.1767870619
# or
npm install @redocly/openapi-core@0.0.0-snapshot.1767870619
# or
npm install @redocly/respect-core@0.0.0-snapshot.1767870619

⚠️ Note: This is a development build and may contain unstable features.

github-actions · 2026-01-08T11:21:23Z

📦 A new experimental 🧪 version v0.0.0-snapshot.1767871282 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/cli@0.0.0-snapshot.1767871282
# or
npm install @redocly/openapi-core@0.0.0-snapshot.1767871282
# or
npm install @redocly/respect-core@0.0.0-snapshot.1767871282

⚠️ Note: This is a development build and may contain unstable features.

github-actions · 2026-01-08T14:26:05Z

📦 A new experimental 🧪 version v0.0.0-snapshot.1767882364 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/cli@0.0.0-snapshot.1767882364
# or
npm install @redocly/openapi-core@0.0.0-snapshot.1767882364
# or
npm install @redocly/respect-core@0.0.0-snapshot.1767882364

⚠️ Note: This is a development build and may contain unstable features.

github-actions · 2026-01-19T18:13:22Z

📦 A new experimental 🧪 version v0.0.0-snapshot.1768846401 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/cli@0.0.0-snapshot.1768846401
# or
npm install @redocly/openapi-core@0.0.0-snapshot.1768846401
# or
npm install @redocly/respect-core@0.0.0-snapshot.1768846401

⚠️ Note: This is a development build and may contain unstable features.

tatomyr · 2026-01-20T10:42:26Z

 import { specVersions } from '../detect-spec.js';
 import { getResolveConfig } from './get-resolve-config.js';
-import { isAbsoluteUrl } from '../ref-utils.js';
+import { isAbsoluteUrl, isAbsoluteUrlOrFileUrl, resolvePath } from '../ref-utils.js';


Do we need both isAbsoluteUrl and isAbsoluteUrlOrFileUrl?
Could you check if one of them is redundant?

I moved the logic from isAbsoluteUrlOrFileUrl to isAbsoluteUrl, and it seems to work fine. Tested on Reunite, VSCE (also Windows), and ran tests on CLI

tatomyr · 2026-01-20T10:48:04Z

+    ignore: Record<string, Record<string, string[]>>,
+    ignorePath: string
+  ): Record<string, Record<string, Set<string>>> {
+    const adapted = Object.create(null) as Record<string, Record<string, Set<string>>>;


Why not just empty object literal?

github-advanced-security says that is Prototype-polluting assignment and better use for this case Object.create(null) instead {}

github-actions · 2026-01-20T17:41:26Z

📦 A new experimental 🧪 version v0.0.0-snapshot.1768930882 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/cli@0.0.0-snapshot.1768930882
# or
npm install @redocly/openapi-core@0.0.0-snapshot.1768930882
# or
npm install @redocly/respect-core@0.0.0-snapshot.1768930882

⚠️ Note: This is a development build and may contain unstable features.

tatomyr · 2026-01-21T07:29:51Z

 export { Stats } from './rules/other/stats.js';
 export {
  loadConfig,
+  loadIgnoreFile,


Do we reuse it somewhere else?

In the language server, it should be added that ignoring works when there is no redocly.yaml.

Strange, I thought it should just work automatically when using loadCogfig. Let's discuss that.

It is used in language-server to create a default configuration when we don't have redocly.yaml. There, we use createConfig and must send the result of loadIgnoreFile to createConfig; if we don't, the ignore file will not work.

github-actions · 2026-01-21T12:20:38Z

📦 A new experimental 🧪 version v0.0.0-snapshot.1768998038 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/cli@0.0.0-snapshot.1768998038
# or
npm install @redocly/openapi-core@0.0.0-snapshot.1768998038
# or
npm install @redocly/respect-core@0.0.0-snapshot.1768998038

⚠️ Note: This is a development build and may contain unstable features.

github-actions · 2026-01-21T13:13:21Z

📦 A new experimental 🧪 version v0.0.0-snapshot.1769001200 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/cli@0.0.0-snapshot.1769001200
# or
npm install @redocly/openapi-core@0.0.0-snapshot.1769001200
# or
npm install @redocly/respect-core@0.0.0-snapshot.1769001200

⚠️ Note: This is a development build and may contain unstable features.

tatomyr

Left a minor comment. Otherwise looks good.

github-actions · 2026-01-21T17:33:27Z

📦 A new experimental 🧪 version v0.0.0-snapshot.1769016804 of Redocly CLI has been published for testing.

Install with NPM:

npm install @redocly/cli@0.0.0-snapshot.1769016804
# or
npm install @redocly/openapi-core@0.0.0-snapshot.1769016804
# or
npm install @redocly/respect-core@0.0.0-snapshot.1769016804

⚠️ Note: This is a development build and may contain unstable features.

fix: update lint-ignore logic

53e4d61

kanoru3101 self-assigned this Jan 7, 2026

fix: update tests

323e239

kanoru3101 added the snapshot Create experimental release PR label Jan 7, 2026

fix: add logs

f0491ec

kanoru3101 added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Jan 7, 2026

fix: refactoring

04aff2e

kanoru3101 added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Jan 8, 2026

kanoru3101 added 2 commits January 8, 2026 12:07

fix: refactoring

80c55f0

fix: revert changes

b12cd36

kanoru3101 added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Jan 8, 2026

fix: update tests

25d06f0

kanoru3101 added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Jan 8, 2026

kanoru3101 changed the title ~~fix: update lint-ignore logic~~ fix(core): update lint-ignore logic for reunite Jan 8, 2026

kanoru3101 changed the title ~~fix(core): update lint-ignore logic for reunite~~ fix(core): update loading of .redocly.lint-ignore.yaml in browser environments Jan 8, 2026

fix(core): add logs

a4aeeef

kanoru3101 added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Jan 19, 2026

fix(core): remove logs

0908c72

tatomyr reviewed Jan 20, 2026

View reviewed changes

fix(core): remove isAbsoluteUrlOrFileUrl and update isAbsoluteUrl

aad5b73

kanoru3101 added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Jan 20, 2026

kanoru3101 requested a review from tatomyr January 20, 2026 19:41

tatomyr reviewed Jan 21, 2026

View reviewed changes

kanoru3101 added 2 commits January 21, 2026 14:11

fix(core): resolve comments and add log for ConfigDir

5a026f5

fix(core): update resolvedFileName

84c82cf

kanoru3101 added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Jan 21, 2026

fix(core): remove console.log and resolvedIgnoreDir

0ee91d4

kanoru3101 added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Jan 21, 2026

kanoru3101 requested a review from tatomyr January 21, 2026 13:38

tatomyr approved these changes Jan 21, 2026

View reviewed changes

Comment thread packages/core/src/config/config.ts Outdated

fix(core): add types

876d5ec

kanoru3101 added snapshot Create experimental release PR and removed snapshot Create experimental release PR labels Jan 21, 2026

kanoru3101 merged commit 3d3794a into main Jan 21, 2026
47 checks passed

kanoru3101 deleted the fix/ignore-file-for-browser branch January 21, 2026 18:33

vadyvas mentioned this pull request Jan 23, 2026

fix: issue with .redocly.lint-ignore.yaml #2512

Merged

6 tasks

Uh oh!

Conversation

kanoru3101 commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What/Why/How?

Reference

Testing

Screenshots (optional)

Check yourself

Security

Uh oh!

changeset-bot Bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

github-actions Bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 7, 2026

Uh oh!

github-actions Bot commented Jan 7, 2026

Uh oh!

github-actions Bot commented Jan 8, 2026

Uh oh!

github-actions Bot commented Jan 8, 2026

Uh oh!

github-actions Bot commented Jan 8, 2026

Uh oh!

github-actions Bot commented Jan 8, 2026

Uh oh!

github-actions Bot commented Jan 19, 2026

Uh oh!

Uh oh!

tatomyr Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

kanoru3101 Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

tatomyr Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

kanoru3101 Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jan 20, 2026

Uh oh!

tatomyr Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

kanoru3101 Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

tatomyr Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

kanoru3101 Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jan 21, 2026

Uh oh!

github-actions Bot commented Jan 21, 2026

Uh oh!

tatomyr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jan 21, 2026

Uh oh!

kanoru3101 commented Jan 7, 2026 •

edited

Loading

changeset-bot Bot commented Jan 7, 2026 •

edited

Loading

github-actions Bot commented Jan 7, 2026 •

edited

Loading

github-actions Bot commented Jan 7, 2026 •

edited

Loading

kanoru3101 Jan 21, 2026 •

edited

Loading