chore: fix flaky smoke tests on yarn #2764
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| #!/bin/bash | ||
|
|
||
| REDOCLY_CONFIG_VERSION=$(node -e "const fs = require('fs'); const p = JSON.parse(fs.readFileSync('./packages/core/package.json', 'utf8')); console.log(p.dependencies['@redocly/config'].replace(/\^/, ''));") | ||
|
Collaborator
There was a problem hiding this comment. We're emulating something that will not be the case in our users' setup, so the smokes become irrelevant. Let's try keeping them as much close to the reality as possible.
Contributor
Author
There was a problem hiding this comment. This bash script read the version of
Collaborator
There was a problem hiding this comment. Let's discuss this offine. |
||
|
|
||
| echo "Pinning @redocly/config to $REDOCLY_CONFIG_VERSION in smoke test overrides" | ||
|
|
||
| node -e " | ||
| const fs = require('fs'); | ||
| const path = './tests/smoke/basic/package.json'; | ||
| const pkg = JSON.parse(fs.readFileSync(path, 'utf8')); | ||
| (pkg.resolutions ??= {})['@redocly/config'] = '$REDOCLY_CONFIG_VERSION'; | ||
| (pkg.overrides ??= {})['@redocly/config'] = '$REDOCLY_CONFIG_VERSION'; | ||
| ((pkg.pnpm ??= {}).overrides ??= {})['@redocly/config'] = '$REDOCLY_CONFIG_VERSION'; | ||
|
|
||
| fs.writeFileSync(path, JSON.stringify(pkg, null, 2) + '\n'); | ||
| " | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't make any difference but the intention becomes less clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to use
yarn installinstead ofyarn addto fix the issue, so i added intopackage.jsondependency, which points to thetgzcli file. I changed all tests to use just install and be consistent across the tests.