Skip to content

fix: increase default fetch timeout for push command in v1#2777

Merged
DmitryAnansky merged 1 commit into
v1from
fix/push-command-improvements
Apr 27, 2026
Merged

fix: increase default fetch timeout for push command in v1#2777
DmitryAnansky merged 1 commit into
v1from
fix/push-command-improvements

Conversation

@DmitryAnansky
Copy link
Copy Markdown
Contributor

@DmitryAnansky DmitryAnansky commented Apr 27, 2026

What/Why/How?

Increased the default fetch timeout used by the push command to better support slower uploads.

Reference

Testing

Screenshots (optional)

Check yourself

  • This PR follows the contributing guide
  • All new/updated code is covered by tests
  • Core code changed? - Tested with other Redocly products (internal contributions only)
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update has been considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

Note

Low Risk
Low risk constant/tuning change that only affects how long the CLI waits before aborting HTTP requests. Potential impact is limited to slower failure detection for genuinely hung requests.

Overview
Improves reliability of push workflows on slow networks by increasing DEFAULT_FETCH_TIMEOUT from 3s to 6s.

Removes the separate SOURCE_FETCH_TIMEOUT and updates getDefaultBranch to use the shared default timeout. Adds a patch changeset documenting the timeout increase.

Reviewed by Cursor Bugbot for commit 573d8a0. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 27, 2026

🦋 Changeset detected

Latest commit: 573d8a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@redocly/cli Patch
@redocly/openapi-core Patch
@redocly/respect-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DmitryAnansky DmitryAnansky changed the title fix: increase default fetch timeout for push command fix: increase default fetch timeout for push command in v1 Apr 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 909.4 ± 15.8 889.4 933.0 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 923.0 ± 25.4 893.9 976.1 1.01 ± 0.03

@github-actions
Copy link
Copy Markdown
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.47% 7068/8894
🟡 Branches 68.51% 2946/4300
🟡 Functions 75.18% 1154/1535
🟡 Lines 79.86% 6743/8444
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / fetch-with-timeout.ts
90.91% 100% 50% 90.91%

Test suite run success

1344 tests passing in 194 suites.

Report generated by 🧪jest coverage report action from 573d8a0

@DmitryAnansky DmitryAnansky marked this pull request as ready for review April 27, 2026 11:14
@DmitryAnansky DmitryAnansky requested review from a team as code owners April 27, 2026 11:14
@DmitryAnansky DmitryAnansky merged commit c743b2e into v1 Apr 27, 2026
45 checks passed
@DmitryAnansky DmitryAnansky deleted the fix/push-command-improvements branch April 27, 2026 11:19
@DmitryAnansky DmitryAnansky self-assigned this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants