Skip to content

fix: increase default fetch timeout for push command#2778

Merged
DmitryAnansky merged 1 commit into
mainfrom
fix/push-command-timeout-increase
Apr 27, 2026
Merged

fix: increase default fetch timeout for push command#2778
DmitryAnansky merged 1 commit into
mainfrom
fix/push-command-timeout-increase

Conversation

@DmitryAnansky
Copy link
Copy Markdown
Contributor

@DmitryAnansky DmitryAnansky commented Apr 27, 2026

What/Why/How?

Increased the default fetch timeout used by the push command to better support slower uploads.

Reference

Testing

Screenshots (optional)

Check yourself

  • This PR follows the contributing guide
  • All new/updated code is covered by tests
  • Core code changed? - Tested with other Redocly products (internal contributions only)
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update has been considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

Note

Low Risk
Low risk: only adjusts client-side request timeouts, which may slightly delay failure detection but doesn’t change request payloads or auth logic.

Overview
Increases the CLI’s default HTTP fetch timeout from 3s to 6s to better accommodate slower push-related uploads.

Removes the separate SOURCE_FETCH_TIMEOUT constant and standardizes getDefaultBranch to use DEFAULT_FETCH_TIMEOUT, making timeout behavior consistent across these API calls.

Reviewed by Cursor Bugbot for commit 12d9317. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 27, 2026

🦋 Changeset detected

Latest commit: 12d9317

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@redocly/cli Patch
@redocly/openapi-core Patch
@redocly/respect-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 80.05% (🎯 80%) 7101 / 8870
🔵 Statements 79.46% (🎯 79%) 7380 / 9287
🔵 Functions 83.45% (🎯 83%) 1428 / 1711
🔵 Branches 71.52% (🎯 71%) 4806 / 6719
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/cli/src/reunite/api/api-client.ts 69.09% 50.84% 81.25% 68.8% 52-62, 96, 147, 186, 204, 207, 210, 213, 216, 227, 249-317, 396-400
packages/cli/src/utils/constants.ts 100% 100% 100% 100%
Generated in workflow #9639 for commit 12d9317 by the Vitest Coverage Report Action

@github-actions
Copy link
Copy Markdown
Contributor

CLI Version Mean Time ± Std Dev (s) Relative Performance (Lower is Faster)
cli-latest 3.131s ± 0.052s ▓ 1.00x
cli-next 3.131s ± 0.039s ▓ 1.00x (Fastest)

@DmitryAnansky DmitryAnansky marked this pull request as ready for review April 27, 2026 11:15
@DmitryAnansky DmitryAnansky requested review from a team as code owners April 27, 2026 11:15
@DmitryAnansky DmitryAnansky merged commit 5e5bced into main Apr 27, 2026
47 checks passed
@DmitryAnansky DmitryAnansky deleted the fix/push-command-timeout-increase branch April 27, 2026 11:34
@DmitryAnansky DmitryAnansky self-assigned this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants