chore: upgrade performance benchmark #2816
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,65 @@ | ||
| import fs from 'node:fs'; | ||
|
|
||
| const median = (xs) => { | ||
| const sorted = [...xs].sort((a, b) => a - b); | ||
| const mid = Math.floor(sorted.length / 2); | ||
| return sorted.length % 2 ? sorted[mid] : (sorted[mid - 1] + sorted[mid]) / 2; | ||
| }; | ||
|
|
||
| const medianAbsoluteDeviation = (xs, centre) => median(xs.map((x) => Math.abs(x - centre))); | ||
|
Collaborator
There was a problem hiding this comment. Doesn't hyperfine calculate the deviation already, does it?
Contributor
Author
There was a problem hiding this comment. Good point, i give it a try and found that |
||
|
|
||
| const constructBarForChart = (value, min) => { | ||
| if (min <= 0) return 'N/A'; | ||
| const slownessFactor = value / min - 1; | ||
| const maxBarLength = 30; | ||
| const length = Math.floor(Math.min(1, slownessFactor) * maxBarLength); | ||
| return '▓' + '▓'.repeat(length); | ||
| }; | ||
|
|
||
| const loadResults = (jsonPath) => { | ||
| const json = JSON.parse(fs.readFileSync(jsonPath, 'utf8')); | ||
| return new Map( | ||
| json.results.map((r) => { | ||
| const cliVersion = r.command.replace(/^node node_modules\/([^/]+)\/.*/, (_, v) => v); | ||
| return [cliVersion, { median: r.median, mad: medianAbsoluteDeviation(r.times, r.median) }]; | ||
| }) | ||
| ); | ||
| }; | ||
|
|
||
| const findFastest = (results) => | ||
| [...results.values()].reduce((best, r) => (r.median < best.median ? r : best)); | ||
|
|
||
| const renderCell = (entry, fastest) => { | ||
| const bar = constructBarForChart(entry.median, fastest.median); | ||
| const factor = entry.median / fastest.median; | ||
| if (entry === fastest) { | ||
| return `${bar} ${factor.toFixed(2)}x (Fastest)`; | ||
| } | ||
| const relativeUnc = | ||
| factor * Math.sqrt((entry.mad / entry.median) ** 2 + (fastest.mad / fastest.median) ** 2); | ||
| return `${bar} ${factor.toFixed(2)}x ± ${relativeUnc.toFixed(2)}`; | ||
| }; | ||
|
|
||
| const operations = [ | ||
| { name: 'Bundle', file: 'benchmark_bundle.json' }, | ||
| { name: 'Lint', file: 'benchmark_lint.json' }, | ||
| { name: 'Check Config', file: 'benchmark_check-config.json' }, | ||
| ]; | ||
|
|
||
| const columns = operations.map(({ name, file }) => { | ||
| const data = loadResults(file); | ||
| return { name, data, fastest: findFastest(data) }; | ||
| }); | ||
| const versions = [...columns[0].data.keys()]; | ||
|
|
||
| const output = [ | ||
| '## Performance Benchmark', | ||
| '', | ||
| `| CLI Version | ${columns.map((c) => c.name).join(' | ')} |`, | ||
| `|---|${columns.map(() => '---').join('|')}|`, | ||
| ...versions.map( | ||
| (v) => `| ${v} | ${columns.map((c) => renderCell(c.data.get(v), c.fastest)).join(' | ')} |` | ||
| ), | ||
| ].join('\n'); | ||
|
|
||
| process.stdout.write(output); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really think we need to rerun benchmarks too often. Most of the time the current flow is sufficient to see if there's a noticeable difference in perf. If you decide to leave the labeling though, please remove the comments as they explain a trivial case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in workflow was introduced only for testing purposes for this PR, i will remove this after PR will be approved. I left note in the description of PR regarding it.