Skip to content

fix: improve rule references output#2823

Merged
tatomyr merged 2 commits into
mainfrom
fix/reference-placement
May 19, 2026
Merged

fix: improve rule references output#2823
tatomyr merged 2 commits into
mainfrom
fix/reference-placement

Conversation

@tatomyr
Copy link
Copy Markdown
Collaborator

@tatomyr tatomyr commented May 19, 2026

What/Why/How?

  • Improved rule references output placement (see the snapshots)
  • Ran audit fix

Check yourself

  • This PR follows the contributing guide
  • All new/updated code is covered by tests
  • Core code changed? - Tested with other Redocly products (internal contributions only)
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update has been considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

Note

Low Risk
Low risk: changes are limited to CLI output string ordering and lockfile-only dependency patch bumps; main risk is snapshot/consumer expectations of exact output formatting.

Overview
Lint output formatting: Reorders formatCodeframe output so problem.reference is emitted after the “was generated by … rule” line, rather than before the codeframe/from block.

Tests/lockfile: Updates e2e snapshots to match the new reference placement, and bumps patched transitive deps in package-lock.json (notably ws to 8.20.1 and brace-expansion to 5.0.6).

Reviewed by Cursor Bugbot for commit 2722e15. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2026

⚠️ No Changeset found

Latest commit: 2722e15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tatomyr tatomyr marked this pull request as ready for review May 19, 2026 09:40
@tatomyr tatomyr requested a review from a team as a code owner May 19, 2026 09:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

CLI Version Mean Time ± Std Dev (s) Relative Performance (Lower is Faster)
cli-latest 2.015s ± 0.015s ▓ 1.00x (Fastest)
cli-next 2.039s ± 0.028s ▓ 1.01x

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 80.77% (🎯 80%) 7257 / 8984
🔵 Statements 80.13% (🎯 80%) 7541 / 9410
🔵 Functions 83.85% (🎯 83%) 1454 / 1734
🔵 Branches 72.42% (🎯 72%) 4924 / 6799
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/core/src/format/format.ts 51.59% 43.75% 58.06% 51.39% 25, 67-68, 113, 117-143, 161, 165, 173-191, 200-306, 311, 324-330, 355-361, 413-426, 440-441, 470
Generated in workflow #9879 for commit 2722e15 by the Vitest Coverage Report Action

@tatomyr tatomyr merged commit 6a3f29b into main May 19, 2026
57 of 64 checks passed
@tatomyr tatomyr deleted the fix/reference-placement branch May 19, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants