Fix CI: use log-based health check and handle pre-configured Microsoft apt repo

- Health check: grep errorlog instead of sqlcmd (works across all container versions)
- Install sqlcmd: skip repo setup if Microsoft repo already configured (Ubuntu 24.04)
- Increase health retries from 10 to 15 for slower container starts

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: erikdarlingdata

.github/workflows/sql-tests.yml

@@ -15,16 +15,12 @@ jobs:
         include:
           - version: '2017'
             image: mcr.microsoft.com/mssql/server:2017-latest
-            health_cmd: /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 'CI_Test#2026!' -Q 'SELECT 1' -b
           - version: '2019'
             image: mcr.microsoft.com/mssql/server:2019-latest
-            health_cmd: /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P 'CI_Test#2026!' -Q 'SELECT 1' -b
           - version: '2022'
             image: mcr.microsoft.com/mssql/server:2022-latest
-            health_cmd: /opt/mssql-tools18/bin/sqlcmd -S localhost -U sa -P 'CI_Test#2026!' -C -No -Q 'SELECT 1' -b
           - version: '2025'
             image: mcr.microsoft.com/mssql/server:2025-latest
-            health_cmd: /opt/mssql-tools18/bin/sqlcmd -S localhost -U sa -P 'CI_Test#2026!' -C -No -Q 'SELECT 1' -b
 
     name: SQL Server ${{ matrix.version }}
 
@@ -37,19 +33,22 @@ jobs:
         ports:
           - 1433:1433
         options: >-
-          --health-cmd "${{ matrix.health_cmd }}"
+          --health-cmd "grep -q 'SQL Server is now ready for client connections' /var/opt/mssql/log/errorlog || exit 1"
           --health-interval 10s
           --health-timeout 5s
-          --health-retries 10
+          --health-retries 15
 
     steps:
       - uses: actions/checkout@v4
 
       - name: Install sqlcmd
         run: |
-          curl -sSL https://packages.microsoft.com/keys/microsoft.asc | sudo tee /etc/apt/trusted.gpg.d/microsoft.asc > /dev/null
-          source /etc/os-release
-          echo "deb [arch=amd64] https://packages.microsoft.com/ubuntu/${VERSION_ID}/prod ${VERSION_CODENAME} main" | sudo tee /etc/apt/sources.list.d/mssql-release.list
+          # Ubuntu 24.04 runners have Microsoft repo pre-configured; avoid Signed-By conflicts
+          if ! grep -rql 'packages.microsoft.com' /etc/apt/sources.list.d/ 2>/dev/null; then
+            curl -sSL https://packages.microsoft.com/keys/microsoft.asc | sudo gpg --dearmor -o /usr/share/keyrings/microsoft-prod.gpg
+            source /etc/os-release
+            echo "deb [arch=amd64,signed-by=/usr/share/keyrings/microsoft-prod.gpg] https://packages.microsoft.com/ubuntu/${VERSION_ID}/prod ${VERSION_CODENAME} main" | sudo tee /etc/apt/sources.list.d/mssql-release.list
+          fi
           sudo apt-get update
           sudo ACCEPT_EULA=Y apt-get install -y mssql-tools18