Skip to content

SRC: use LSAME for UPLO checks in pttrs#1238

Open
nakatamaho wants to merge 3 commits intoReference-LAPACK:masterfrom
nakatamaho:cleanup/pttrs-lsame-uplo
Open

SRC: use LSAME for UPLO checks in pttrs#1238
nakatamaho wants to merge 3 commits intoReference-LAPACK:masterfrom
nakatamaho:cleanup/pttrs-lsame-uplo

Conversation

@nakatamaho
Copy link
Copy Markdown
Contributor

@nakatamaho nakatamaho commented Apr 13, 2026

This PR replaces direct case-sensitive UPLO character comparisons in the complex PTTRS routines with LSAME.

Files updated:

SRC/cpttrs.f
SRC/zpttrs.f

Summary:

  • Replace UPLO.EQ.'U' .OR. UPLO.EQ.'u' with LSAME( UPLO, 'U' ).
  • Replace the corresponding lower-triangular check with LSAME( UPLO, 'L' ).
  • Add LSAME as a logical external function.

Validation:

  • Compiled cpttrs.f and zpttrs.f with gfortran -O2 -c.
  • Ran git diff --check for the staged changes before commit.

@nakatamaho
cleanup: normalize ZERO/ONE declaration order in TESTING/EIG error-ex…
46604b2 
…it tests

Reorder ZERO and ONE declarations and PARAMETER definitions
for consistency in the TESTING/EIG error-exit test sources.

No functional change intended.
@nakatamaho
TESTING/EIG: use named constants in errgg and zerrhs tests
9def0ea 
Replace hard-coded floating-point constants with named constants in selected TESTING/EIG error-exit tests. This keeps the test setup code consistent with surrounding LAPACK test style.
@nakatamaho
SRC: use LSAME for UPLO checks in pttrs
6a1be42 
Replace direct case-sensitive UPLO character comparisons in CPTTRS and ZPTTRS with LSAME. This matches the surrounding LAPACK convention for case-insensitive option checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nakatamaho