Skip to content

SRC: use LSAME for TRANS checks in gttrs #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nakatamaho wants to merge 4 commits into
base: master
Choose a base branch
from
Open

SRC: use LSAME for TRANS checks in gttrs #1239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46604b2
cleanup: normalize ZERO/ONE declaration order in TESTING/EIG error-ex…
nakatamaho Apr 13, 2026
9def0ea
TESTING/EIG: use named constants in errgg and zerrhs tests
nakatamaho Apr 13, 2026
6a1be42
SRC: use LSAME for UPLO checks in pttrs
nakatamaho Apr 13, 2026
c1afcae
SRC: use LSAME for TRANS checks in gttrs
nakatamaho Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions SRC/cgttrs.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ SUBROUTINE CGTTRS( TRANS, N, NRHS, DL, D, DU, DU2, IPIV, B,
* ..
* .. External Functions ..
INTEGER ILAENV
EXTERNAL ILAENV
LOGICAL LSAME
EXTERNAL ILAENV, LSAME
* ..
* .. External Subroutines ..
EXTERNAL CGTTS2, XERBLA
Expand All @@ -168,9 +169,9 @@ SUBROUTINE CGTTRS( TRANS, N, NRHS, DL, D, DU, DU2, IPIV, B,
* .. Executable Statements ..
*
INFO = 0
NOTRAN = ( TRANS.EQ.'N' .OR. TRANS.EQ.'n' )
IF( .NOT.NOTRAN .AND. .NOT.( TRANS.EQ.'T' .OR. TRANS.EQ.
$ 't' ) .AND. .NOT.( TRANS.EQ.'C' .OR. TRANS.EQ.'c' ) ) THEN
NOTRAN = LSAME( TRANS, 'N' )
IF( .NOT.NOTRAN .AND. .NOT.LSAME( TRANS, 'T' ) .AND.
$ .NOT.LSAME( TRANS, 'C' ) ) THEN
INFO = -1
ELSE IF( N.LT.0 ) THEN
INFO = -2
Expand All @@ -193,7 +194,7 @@ SUBROUTINE CGTTRS( TRANS, N, NRHS, DL, D, DU, DU2, IPIV, B,
*
IF( NOTRAN ) THEN
ITRANS = 0
ELSE IF( TRANS.EQ.'T' .OR. TRANS.EQ.'t' ) THEN
ELSE IF( LSAME( TRANS, 'T' ) ) THEN
ITRANS = 1
ELSE
ITRANS = 2
Expand Down
7 changes: 4 additions & 3 deletions SRC/cpttrs.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ SUBROUTINE CPTTRS( UPLO, N, NRHS, D, E, B, LDB, INFO )
* ..
* .. External Functions ..
INTEGER ILAENV
EXTERNAL ILAENV
LOGICAL LSAME
EXTERNAL ILAENV, LSAME
* ..
* .. External Subroutines ..
EXTERNAL CPTTS2, XERBLA
Expand All @@ -152,8 +153,8 @@ SUBROUTINE CPTTRS( UPLO, N, NRHS, D, E, B, LDB, INFO )
* Test the input arguments.
*
INFO = 0
UPPER = ( UPLO.EQ.'U' .OR. UPLO.EQ.'u' )
IF( .NOT.UPPER .AND. .NOT.( UPLO.EQ.'L' .OR. UPLO.EQ.'l' ) ) THEN
UPPER = LSAME( UPLO, 'U' )
IF( .NOT.UPPER .AND. .NOT.LSAME( UPLO, 'L' ) ) THEN
INFO = -1
ELSE IF( N.LT.0 ) THEN
INFO = -2
Expand Down
9 changes: 5 additions & 4 deletions SRC/dgttrs.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ SUBROUTINE DGTTRS( TRANS, N, NRHS, DL, D, DU, DU2, IPIV, B,
* ..
* .. External Functions ..
INTEGER ILAENV
EXTERNAL ILAENV
LOGICAL LSAME
EXTERNAL ILAENV, LSAME
* ..
* .. External Subroutines ..
EXTERNAL DGTTS2, XERBLA
Expand All @@ -168,9 +169,9 @@ SUBROUTINE DGTTRS( TRANS, N, NRHS, DL, D, DU, DU2, IPIV, B,
* .. Executable Statements ..
*
INFO = 0
NOTRAN = ( TRANS.EQ.'N' .OR. TRANS.EQ.'n' )
IF( .NOT.NOTRAN .AND. .NOT.( TRANS.EQ.'T' .OR. TRANS.EQ.
$ 't' ) .AND. .NOT.( TRANS.EQ.'C' .OR. TRANS.EQ.'c' ) ) THEN
NOTRAN = LSAME( TRANS, 'N' )
IF( .NOT.NOTRAN .AND. .NOT.LSAME( TRANS, 'T' ) .AND.
$ .NOT.LSAME( TRANS, 'C' ) ) THEN
INFO = -1
ELSE IF( N.LT.0 ) THEN
INFO = -2
Expand Down
9 changes: 5 additions & 4 deletions SRC/sgttrs.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ SUBROUTINE SGTTRS( TRANS, N, NRHS, DL, D, DU, DU2, IPIV, B,
* ..
* .. External Functions ..
INTEGER ILAENV
EXTERNAL ILAENV
LOGICAL LSAME
EXTERNAL ILAENV, LSAME
* ..
* .. External Subroutines ..
EXTERNAL SGTTS2, XERBLA
Expand All @@ -168,9 +169,9 @@ SUBROUTINE SGTTRS( TRANS, N, NRHS, DL, D, DU, DU2, IPIV, B,
* .. Executable Statements ..
*
INFO = 0
NOTRAN = ( TRANS.EQ.'N' .OR. TRANS.EQ.'n' )
IF( .NOT.NOTRAN .AND. .NOT.( TRANS.EQ.'T' .OR. TRANS.EQ.
$ 't' ) .AND. .NOT.( TRANS.EQ.'C' .OR. TRANS.EQ.'c' ) ) THEN
NOTRAN = LSAME( TRANS, 'N' )
IF( .NOT.NOTRAN .AND. .NOT.LSAME( TRANS, 'T' ) .AND.
$ .NOT.LSAME( TRANS, 'C' ) ) THEN
INFO = -1
ELSE IF( N.LT.0 ) THEN
INFO = -2
Expand Down
11 changes: 6 additions & 5 deletions SRC/zgttrs.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@ SUBROUTINE ZGTTRS( TRANS, N, NRHS, DL, D, DU, DU2, IPIV, B,
* ..
* .. External Functions ..
INTEGER ILAENV
EXTERNAL ILAENV
LOGICAL LSAME
EXTERNAL ILAENV, LSAME
* ..
* .. External Subroutines ..
EXTERNAL XERBLA, ZGTTS2
Expand All @@ -168,9 +169,9 @@ SUBROUTINE ZGTTRS( TRANS, N, NRHS, DL, D, DU, DU2, IPIV, B,
* .. Executable Statements ..
*
INFO = 0
NOTRAN = ( TRANS.EQ.'N' .OR. TRANS.EQ.'n' )
IF( .NOT.NOTRAN .AND. .NOT.( TRANS.EQ.'T' .OR. TRANS.EQ.
$ 't' ) .AND. .NOT.( TRANS.EQ.'C' .OR. TRANS.EQ.'c' ) ) THEN
NOTRAN = LSAME( TRANS, 'N' )
IF( .NOT.NOTRAN .AND. .NOT.LSAME( TRANS, 'T' ) .AND.
$ .NOT.LSAME( TRANS, 'C' ) ) THEN
INFO = -1
ELSE IF( N.LT.0 ) THEN
INFO = -2
Expand All @@ -193,7 +194,7 @@ SUBROUTINE ZGTTRS( TRANS, N, NRHS, DL, D, DU, DU2, IPIV, B,
*
IF( NOTRAN ) THEN
ITRANS = 0
ELSE IF( TRANS.EQ.'T' .OR. TRANS.EQ.'t' ) THEN
ELSE IF( LSAME( TRANS, 'T' ) ) THEN
ITRANS = 1
ELSE
ITRANS = 2
Expand Down
7 changes: 4 additions & 3 deletions SRC/zpttrs.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ SUBROUTINE ZPTTRS( UPLO, N, NRHS, D, E, B, LDB, INFO )
* ..
* .. External Functions ..
INTEGER ILAENV
EXTERNAL ILAENV
LOGICAL LSAME
EXTERNAL ILAENV, LSAME
* ..
* .. External Subroutines ..
EXTERNAL XERBLA, ZPTTS2
Expand All @@ -152,8 +153,8 @@ SUBROUTINE ZPTTRS( UPLO, N, NRHS, D, E, B, LDB, INFO )
* Test the input arguments.
*
INFO = 0
UPPER = ( UPLO.EQ.'U' .OR. UPLO.EQ.'u' )
IF( .NOT.UPPER .AND. .NOT.( UPLO.EQ.'L' .OR. UPLO.EQ.'l' ) ) THEN
UPPER = LSAME( UPLO, 'U' )
IF( .NOT.UPPER .AND. .NOT.LSAME( UPLO, 'L' ) ) THEN
INFO = -1
ELSE IF( N.LT.0 ) THEN
INFO = -2
Expand Down
4 changes: 2 additions & 2 deletions TESTING/EIG/cerrec.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ SUBROUTINE CERREC( PATH, NUNIT )
* .. Parameters ..
INTEGER NMAX, LW
PARAMETER ( NMAX = 4, LW = NMAX*( NMAX+2 ) )
REAL ONE, ZERO
PARAMETER ( ONE = 1.0E0, ZERO = 0.0E0 )
REAL ZERO, ONE
PARAMETER ( ZERO = 0.0E0, ONE = 1.0E0 )
* ..
* .. Local Scalars ..
INTEGER I, IFST, ILST, INFO, J, M, NT
Expand Down
4 changes: 2 additions & 2 deletions TESTING/EIG/cerred.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ SUBROUTINE CERRED( PATH, NUNIT )
* .. Parameters ..
INTEGER NMAX, LW
PARAMETER ( NMAX = 4, LW = 5*NMAX )
REAL ONE, ZERO
PARAMETER ( ONE = 1.0E0, ZERO = 0.0E0 )
REAL ZERO, ONE
PARAMETER ( ZERO = 0.0E0, ONE = 1.0E0 )
* ..
* .. Local Scalars ..
CHARACTER*2 C2
Expand Down
8 changes: 4 additions & 4 deletions TESTING/EIG/cerrgg.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ SUBROUTINE CERRGG( PATH, NUNIT )
* .. Parameters ..
INTEGER NMAX, LW
PARAMETER ( NMAX = 3, LW = 6*NMAX )
REAL ONE, ZERO
PARAMETER ( ONE = 1.0E+0, ZERO = 0.0E+0 )
REAL ZERO, ONE
PARAMETER ( ZERO = 0.0E+0, ONE = 1.0E+0 )
* ..
* .. Local Scalars ..
CHARACTER*2 C2
Expand Down Expand Up @@ -129,8 +129,8 @@ SUBROUTINE CERRGG( PATH, NUNIT )
B( I, I ) = ONE
30 CONTINUE
OK = .TRUE.
TOLA = 1.0E0
TOLB = 1.0E0
TOLA = ONE
TOLB = ONE
IFST = 1
ILST = 1
NT = 0
Expand Down
4 changes: 2 additions & 2 deletions TESTING/EIG/derrec.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ SUBROUTINE DERREC( PATH, NUNIT )
*
* .. Parameters ..
INTEGER NMAX
DOUBLE PRECISION ONE, ZERO
PARAMETER ( NMAX = 4, ONE = 1.0D0, ZERO = 0.0D0 )
DOUBLE PRECISION ZERO, ONE
PARAMETER ( NMAX = 4, ZERO = 0.0D0, ONE = 1.0D0 )
* ..
* .. Local Scalars ..
INTEGER I, IFST, ILST, INFO, J, M, NT
Expand Down
4 changes: 2 additions & 2 deletions TESTING/EIG/derred.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ SUBROUTINE DERRED( PATH, NUNIT )
*
* .. Parameters ..
INTEGER NMAX
DOUBLE PRECISION ONE, ZERO
PARAMETER ( NMAX = 4, ONE = 1.0D0, ZERO = 0.0D0 )
DOUBLE PRECISION ZERO, ONE
PARAMETER ( NMAX = 4, ZERO = 0.0D0, ONE = 1.0D0 )
* ..
* .. Local Scalars ..
CHARACTER*2 C2
Expand Down
8 changes: 4 additions & 4 deletions TESTING/EIG/derrgg.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ SUBROUTINE DERRGG( PATH, NUNIT )
* .. Parameters ..
INTEGER NMAX, LW
PARAMETER ( NMAX = 3, LW = 6*NMAX )
DOUBLE PRECISION ONE, ZERO
PARAMETER ( ONE = 1.0D+0, ZERO = 0.0D+0 )
DOUBLE PRECISION ZERO, ONE
PARAMETER ( ZERO = 0.0D+0, ONE = 1.0D+0 )
* ..
* .. Local Scalars ..
CHARACTER*2 C2
Expand Down Expand Up @@ -128,8 +128,8 @@ SUBROUTINE DERRGG( PATH, NUNIT )
B( I, I ) = ONE
30 CONTINUE
OK = .TRUE.
TOLA = 1.0D0
TOLB = 1.0D0
TOLA = ONE
TOLB = ONE
IFST = 1
ILST = 1
NT = 0
Expand Down
4 changes: 2 additions & 2 deletions TESTING/EIG/serrec.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ SUBROUTINE SERREC( PATH, NUNIT )
*
* .. Parameters ..
INTEGER NMAX
REAL ONE, ZERO
PARAMETER ( NMAX = 4, ONE = 1.0E0, ZERO = 0.0E0 )
REAL ZERO, ONE
PARAMETER ( NMAX = 4, ZERO = 0.0E0, ONE = 1.0E0 )
* ..
* .. Local Scalars ..
INTEGER I, IFST, ILST, INFO, J, M, NT
Expand Down
4 changes: 2 additions & 2 deletions TESTING/EIG/serred.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ SUBROUTINE SERRED( PATH, NUNIT )
*
* .. Parameters ..
INTEGER NMAX
REAL ONE, ZERO
PARAMETER ( NMAX = 4, ONE = 1.0E0, ZERO = 0.0E0 )
REAL ZERO, ONE
PARAMETER ( NMAX = 4, ZERO = 0.0E0, ONE = 1.0E0 )
* ..
* .. Local Scalars ..
CHARACTER*2 C2
Expand Down
8 changes: 4 additions & 4 deletions TESTING/EIG/serrgg.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ SUBROUTINE SERRGG( PATH, NUNIT )
* .. Parameters ..
INTEGER NMAX, LW
PARAMETER ( NMAX = 3, LW = 6*NMAX )
REAL ONE, ZERO
PARAMETER ( ONE = 1.0E+0, ZERO = 0.0E+0 )
REAL ZERO, ONE
PARAMETER ( ZERO = 0.0E+0, ONE = 1.0E+0 )
* ..
* .. Local Scalars ..
CHARACTER*2 C2
Expand Down Expand Up @@ -128,8 +128,8 @@ SUBROUTINE SERRGG( PATH, NUNIT )
B( I, I ) = ONE
30 CONTINUE
OK = .TRUE.
TOLA = 1.0E0
TOLB = 1.0E0
TOLA = ONE
TOLB = ONE
IFST = 1
ILST = 1
NT = 0
Expand Down
4 changes: 2 additions & 2 deletions TESTING/EIG/zerrec.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ SUBROUTINE ZERREC( PATH, NUNIT )
* .. Parameters ..
INTEGER NMAX, LW
PARAMETER ( NMAX = 4, LW = NMAX*( NMAX+2 ) )
DOUBLE PRECISION ONE, ZERO
PARAMETER ( ONE = 1.0D0, ZERO = 0.0D0 )
DOUBLE PRECISION ZERO, ONE
PARAMETER ( ZERO = 0.0D0, ONE = 1.0D0 )
* ..
* .. Local Scalars ..
INTEGER I, IFST, ILST, INFO, J, M, NT
Expand Down
4 changes: 2 additions & 2 deletions TESTING/EIG/zerred.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ SUBROUTINE ZERRED( PATH, NUNIT )
* .. Parameters ..
INTEGER NMAX, LW
PARAMETER ( NMAX = 4, LW = 5*NMAX )
DOUBLE PRECISION ONE, ZERO
PARAMETER ( ONE = 1.0D0, ZERO = 0.0D0 )
DOUBLE PRECISION ZERO, ONE
PARAMETER ( ZERO = 0.0D0, ONE = 1.0D0 )
* ..
* .. Local Scalars ..
CHARACTER*2 C2
Expand Down
8 changes: 4 additions & 4 deletions TESTING/EIG/zerrgg.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ SUBROUTINE ZERRGG( PATH, NUNIT )
* .. Parameters ..
INTEGER NMAX, LW
PARAMETER ( NMAX = 3, LW = 6*NMAX )
DOUBLE PRECISION ONE, ZERO
PARAMETER ( ONE = 1.0D+0, ZERO = 0.0D+0 )
DOUBLE PRECISION ZERO, ONE
PARAMETER ( ZERO = 0.0D+0, ONE = 1.0D+0 )
* ..
* .. Local Scalars ..
CHARACTER*2 C2
Expand Down Expand Up @@ -129,8 +129,8 @@ SUBROUTINE ZERRGG( PATH, NUNIT )
B( I, I ) = ONE
30 CONTINUE
OK = .TRUE.
TOLA = 1.0D0
TOLB = 1.0D0
TOLA = ONE
TOLB = ONE
IFST = 1
ILST = 1
NT = 0
Expand Down
4 changes: 3 additions & 1 deletion TESTING/EIG/zerrhs.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ SUBROUTINE ZERRHS( PATH, NUNIT )
* .. Parameters ..
INTEGER NMAX, LW
PARAMETER ( NMAX = 3, LW = NMAX*NMAX )
DOUBLE PRECISION ONE
PARAMETER ( ONE = 1.0D+0 )
* ..
* .. Local Scalars ..
CHARACTER*2 C2
Expand Down Expand Up @@ -111,7 +113,7 @@ SUBROUTINE ZERRHS( PATH, NUNIT )
*
DO 20 J = 1, NMAX
DO 10 I = 1, NMAX
A( I, J ) = 1.D0 / DBLE( I+J )
A( I, J ) = ONE / DBLE( I+J )
10 CONTINUE
SEL( J ) = .TRUE.
20 CONTINUE
Expand Down
Loading