SRC: use LSAME for NORM checks in condition routines#1242
Open
nakatamaho wants to merge 7 commits intoReference-LAPACK:masterfrom
Open
SRC: use LSAME for NORM checks in condition routines#1242nakatamaho wants to merge 7 commits intoReference-LAPACK:masterfrom
nakatamaho wants to merge 7 commits intoReference-LAPACK:masterfrom
Conversation
…it tests Reorder ZERO and ONE declarations and PARAMETER definitions for consistency in the TESTING/EIG error-exit test sources. No functional change intended.
Replace hard-coded floating-point constants with named constants in selected TESTING/EIG error-exit tests. This keeps the test setup code consistent with surrounding LAPACK test style.
Replace direct case-sensitive UPLO character comparisons in CPTTRS and ZPTTRS with LSAME. This matches the surrounding LAPACK convention for case-insensitive option checks.
Replace direct case-sensitive TRANS character comparisons in the GTTRS routines with LSAME. This keeps option handling consistent with the surrounding LAPACK convention for case-insensitive checks.
Replace direct UPLO character comparisons in the LALSD routines with LSAME. This keeps option handling consistent with the surrounding LAPACK convention for case-insensitive checks.
Replace direct UPLO character comparisons in the LATSP and LATSY test helpers with LSAME. This keeps option handling consistent with the LAPACK convention for case-insensitive checks.
Replace direct NORM character comparisons for the one-norm option with LSAME in the condition estimation routines. This keeps the '1' checks consistent with the existing LSAME handling for the equivalent 'O' option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the condition estimation routines to use LSAME for checking
the one-norm NORM option.
The affected routines already use LSAME to accept the equivalent 'O' option:
This PR makes the handling consistent by replacing the direct character
comparison with LSAME:
This is a cleanup-only change. It does not change the accepted NORM options
or the numerical behavior of the routines.