Skip to content

Commit b7b60a2

Browse files
committed
refactoring
1 parent e057653 commit b7b60a2

File tree

16 files changed

+140
-148
lines changed

16 files changed

+140
-148
lines changed

CxxTestProps/inc/StringConst.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// 'StrConst' - String-Const, all methods are const.
66
struct StrConst
77
{
8-
constexpr static const char* struct_ = "StrConst";
8+
constexpr static std::string_view struct_ = "StrConst";
99

1010
std::string reverseString() const;
1111

CxxTestProps/inc/StringConstOverload.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
struct StrConstOverload
66
{
7-
constexpr static const char* struct_ = "StrConstOverload";
7+
constexpr static std::string_view struct_ = "StrConstOverload";
88

99
std::string reverseString();
1010

CxxTestProps/inc/StringMute.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// 'StrMute' - String-Mutable, all methods are non-const.
66
struct StrMute
77
{
8-
constexpr static const char* struct_ = "StrMute";
8+
constexpr static std::string_view struct_ = "StrMute";
99

1010
std::string reverseString();
1111

CxxTestProps/inc/StringStatic.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// 'StrStatic' - String-Static, all methods are static.
66
struct StrStatic
77
{
8-
constexpr static const char* struct_ = "StrStatic";
8+
constexpr static std::string_view struct_ = "StrStatic";
99

1010
static std::string reverseString();
1111

CxxTestProps/inc/StringWrap.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ struct StrWrap
1313
// 'StrWrapA' - String-Wrapper, only constructors for testing.
1414
struct StrWrapA : public StrWrap
1515
{
16-
constexpr static const char* struct_ = "StrWrapA";
16+
constexpr static std::string_view struct_ = "StrWrapA";
1717

1818
StrWrapA();
1919

@@ -32,7 +32,7 @@ struct StrWrapA : public StrWrap
3232
// 'StrWrapB' - String-Wrapper, only constructors for testing.
3333
struct StrWrapB : public StrWrap
3434
{
35-
constexpr static const char* struct_ = "StrWrapB";
35+
constexpr static std::string_view struct_ = "StrWrapB";
3636
StrWrapB(std::string& pStr);
3737
StrWrapB(const std::string& pStr);
3838
};
@@ -41,14 +41,14 @@ struct StrWrapB : public StrWrap
4141
// 'StrWrapC' - String-Wrapper, only constructors for testing.
4242
struct StrWrapC : public StrWrap
4343
{
44-
constexpr static const char* struct_ = "StrWrapC";
44+
constexpr static std::string_view struct_ = "StrWrapC";
4545
StrWrapC(std::string& pStr);
4646
};
4747

4848

4949
// 'StrWrapD' - String-Wrapper, only constructors for testing.
5050
struct StrWrapD : public StrWrap
5151
{
52-
constexpr static const char* struct_ = "StrWrapD";
52+
constexpr static std::string_view struct_ = "StrWrapD";
5353
StrWrapD(const std::string& pStr);
5454
};

CxxTestProps/src/StringConst.cpp

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,133 +10,133 @@ using namespace test_utils;
1010

1111
std::string StrConst::reverseString() const
1212
{
13-
return std::string(struct_) + REV_STR_VOID_RET + SUFFIX_void + SUFFIX_const;
13+
return std::string(struct_).append(REV_STR_VOID_RET).append(SUFFIX_void).append(SUFFIX_const);
1414
}
1515

1616

1717
std::string StrConst::reverseString(const char* pStr) const
1818
{
1919
std::string retStr = pStr;
2020
std::reverse(retStr.begin(), retStr.end());
21-
return std::string(struct_) + retStr + SUFFIX_const_char_ptr + SUFFIX_const;
21+
return std::string(struct_).append(retStr).append(SUFFIX_const_char_ptr).append(SUFFIX_const);
2222
}
2323

2424

2525
std::string StrConst::reverseString(std::string pStr) const
2626
{
2727
std::string retStr = pStr;
2828
std::reverse(retStr.begin(), retStr.end());
29-
return std::string(struct_) + retStr + SUFFIX_std_string + SUFFIX_const;
29+
return std::string(struct_).append(retStr).append(SUFFIX_std_string).append(SUFFIX_const);
3030
}
3131

3232

3333
std::string StrConst::reverseString(std::string& pStr) const
3434
{
3535
std::string retStr = pStr;
3636
std::reverse(retStr.begin(), retStr.end());
37-
return std::string(struct_) + retStr + SUFFIX_std_string_lvref + SUFFIX_const;
37+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_lvref).append(SUFFIX_const);
3838
}
3939

4040

4141
std::string StrConst::reverseString(std::string&& pStr) const
4242
{
4343
std::string retStr = pStr;
4444
std::reverse(retStr.begin(), retStr.end());
45-
return std::string(struct_) + retStr + SUFFIX_std_string_rvref + SUFFIX_const;
45+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_rvref).append(SUFFIX_const);
4646
}
4747

4848

4949
std::string StrConst::reverseString(const std::string& pStr) const
5050
{
5151
std::string retStr = pStr;
5252
std::reverse(retStr.begin(), retStr.end());
53-
return std::string(struct_) + retStr + SUFFIX_std_string_clvref + SUFFIX_const;
53+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_clvref).append(SUFFIX_const);
5454
}
5555

5656

5757
std::string StrConst::reverseString(std::string* pStr) const
5858
{
5959
std::string retStr = *pStr;
6060
std::reverse(retStr.begin(), retStr.end());
61-
return std::string(struct_) + retStr + SUFFIX_std_string_ptr + SUFFIX_const;
61+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_ptr).append(SUFFIX_const);
6262
}
6363

6464

6565
std::string StrConst::reverseString(const std::string* pStr) const
6666
{
6767
std::string retStr = *pStr;
6868
std::reverse(retStr.begin(), retStr.end());
69-
return std::string(struct_) + retStr + SUFFIX_std_string_cptr + SUFFIX_const;
69+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_cptr).append(SUFFIX_const);
7070
}
7171

7272

7373
std::string StrConst::revStrConstRefArg(const std::string_view& pStr) const
7474
{
7575
std::string retStr(pStr);
7676
std::reverse(retStr.begin(), retStr.end());
77-
return std::string(struct_) + retStr + SUFFIX_std_string_view_clvref + SUFFIX_const;
77+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view_clvref).append(SUFFIX_const);
7878
}
7979

8080

8181
std::string StrConst::revStrRValueRefArg(std::string_view&& pStr) const
8282
{
8383
std::string retStr(pStr);
8484
std::reverse(retStr.begin(), retStr.end());
85-
return std::string(struct_) + retStr + SUFFIX_std_string_view_rvref + SUFFIX_const;
85+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view_rvref).append(SUFFIX_const);
8686
}
8787

8888

8989
std::string StrConst::revStrNonConstRefArg(std::string_view& pStr) const
9090
{
9191
std::string retStr(pStr);
9292
std::reverse(retStr.begin(), retStr.end());
93-
return std::string(struct_) + retStr + SUFFIX_std_string_view_lvref + SUFFIX_const;
93+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view_lvref).append(SUFFIX_const);
9494
}
9595

9696

9797
std::string StrConst::revStrOverloadValCRef(std::string_view pStr) const
9898
{
9999
std::string retStr(pStr);
100100
std::reverse(retStr.begin(), retStr.end());
101-
return std::string(struct_) + retStr + SUFFIX_std_string_view + SUFFIX_const;
101+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view).append(SUFFIX_const);
102102
}
103103

104104

105105
std::string StrConst::revStrOverloadValCRef(const std::string_view& pStr) const
106106
{
107107
std::string retStr(pStr);
108108
std::reverse(retStr.begin(), retStr.end());
109-
return std::string(struct_) + retStr + SUFFIX_std_string_view_clvref + SUFFIX_const;
109+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view_clvref).append(SUFFIX_const);
110110
}
111111

112112

113113
std::string StrConst::revStrOverloadValRef(std::string_view pStr) const
114114
{
115115
std::string retStr(pStr);
116116
std::reverse(retStr.begin(), retStr.end());
117-
return std::string(struct_) + retStr + SUFFIX_std_string_view + SUFFIX_const;
117+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view).append(SUFFIX_const);
118118
}
119119

120120

121121
std::string StrConst::revStrOverloadValRef(std::string_view& pStr) const
122122
{
123123
std::string retStr(pStr);
124124
std::reverse(retStr.begin(), retStr.end());
125-
return std::string(struct_) + retStr + SUFFIX_std_string_view_lvref + SUFFIX_const;
125+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view_lvref).append(SUFFIX_const);
126126
}
127127

128128

129129
std::string StrConst::revStrOverloadRefAndCRef(std::string_view& pStr) const
130130
{
131131
std::string retStr(pStr);
132132
std::reverse(retStr.begin(), retStr.end());
133-
return std::string(struct_) + retStr + SUFFIX_std_string_view_lvref + SUFFIX_const;
133+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view_lvref).append(SUFFIX_const);
134134
}
135135

136136

137137
std::string StrConst::revStrOverloadRefAndCRef(const std::string_view& pStr) const
138138
{
139139
std::string retStr(pStr);
140140
std::reverse(retStr.begin(), retStr.end());
141-
return std::string(struct_) + retStr + SUFFIX_std_string_view_clvref + SUFFIX_const;
141+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view_clvref).append(SUFFIX_const);
142142
}

CxxTestProps/src/StringConstOverload.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ using namespace test_utils;
1010

1111
std::string StrConstOverload::reverseString()
1212
{
13-
return std::string(struct_) + REV_STR_VOID_RET + SUFFIX_void;
13+
return std::string(struct_).append(REV_STR_VOID_RET).append(SUFFIX_void);
1414
}
1515

1616

1717
std::string StrConstOverload::reverseString() const
1818
{
19-
return std::string(struct_) + REV_STR_VOID_RET + SUFFIX_void + SUFFIX_const;
19+
return std::string(struct_).append(REV_STR_VOID_RET).append(SUFFIX_void).append(SUFFIX_const);
2020
}

CxxTestProps/src/StringMute.cpp

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,133 +10,133 @@ using namespace test_utils;
1010

1111
std::string StrMute::reverseString()
1212
{
13-
return std::string(struct_) + REV_STR_VOID_RET + SUFFIX_void;
13+
return std::string(struct_).append(REV_STR_VOID_RET).append(SUFFIX_void);
1414
}
1515

1616

1717
std::string StrMute::reverseString(const char* pStr)
1818
{
1919
std::string retStr = pStr;
2020
std::reverse(retStr.begin(), retStr.end());
21-
return std::string(struct_) + retStr + SUFFIX_const_char_ptr;
21+
return std::string(struct_).append(retStr).append(SUFFIX_const_char_ptr);
2222
}
2323

2424

2525
std::string StrMute::reverseString(std::string pStr)
2626
{
2727
std::string retStr = pStr;
2828
std::reverse(retStr.begin(), retStr.end());
29-
return std::string(struct_) + retStr + SUFFIX_std_string;
29+
return std::string(struct_).append(retStr).append(SUFFIX_std_string);
3030
}
3131

3232

3333
std::string StrMute::reverseString(std::string& pStr)
3434
{
3535
std::string retStr = pStr;
3636
std::reverse(retStr.begin(), retStr.end());
37-
return std::string(struct_) + retStr + SUFFIX_std_string_lvref;
37+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_lvref);
3838
}
3939

4040

4141
std::string StrMute::reverseString(std::string&& pStr)
4242
{
4343
std::string retStr = pStr;
4444
std::reverse(retStr.begin(), retStr.end());
45-
return std::string(struct_) + retStr + SUFFIX_std_string_rvref;
45+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_rvref);
4646
}
4747

4848

4949
std::string StrMute::reverseString(const std::string& pStr)
5050
{
5151
std::string retStr = pStr;
5252
std::reverse(retStr.begin(), retStr.end());
53-
return std::string(struct_) + retStr + SUFFIX_std_string_clvref;
53+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_clvref);
5454
}
5555

5656

5757
std::string StrMute::reverseString(std::string* pStr)
5858
{
5959
std::string retStr = *pStr;
6060
std::reverse(retStr.begin(), retStr.end());
61-
return std::string(struct_) + retStr + SUFFIX_std_string_ptr;
61+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_ptr);
6262
}
6363

6464

6565
std::string StrMute::reverseString(const std::string* pStr)
6666
{
6767
std::string retStr = *pStr;
6868
std::reverse(retStr.begin(), retStr.end());
69-
return std::string(struct_) + retStr + SUFFIX_std_string_cptr;
69+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_cptr);
7070
}
7171

7272

7373
std::string StrMute::revStrConstRefArg(const std::string_view& pStr)
7474
{
7575
std::string retStr(pStr);
7676
std::reverse(retStr.begin(), retStr.end());
77-
return std::string(struct_) + retStr + SUFFIX_std_string_view_clvref;
77+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view_clvref);
7878
}
7979

8080

8181
std::string StrMute::revStrRValueRefArg(std::string_view&& pStr)
8282
{
8383
std::string retStr(pStr);
8484
std::reverse(retStr.begin(), retStr.end());
85-
return std::string(struct_) + retStr + SUFFIX_std_string_view_rvref;
85+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view_rvref);
8686
}
8787

8888

8989
std::string StrMute::revStrNonConstRefArg(std::string_view& pStr)
9090
{
9191
std::string retStr(pStr);
9292
std::reverse(retStr.begin(), retStr.end());
93-
return std::string(struct_) + retStr + SUFFIX_std_string_view_lvref;
93+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view_lvref);
9494
}
9595

9696

9797
std::string StrMute::revStrOverloadValCRef(std::string_view pStr)
9898
{
9999
std::string retStr(pStr);
100100
std::reverse(retStr.begin(), retStr.end());
101-
return std::string(struct_) + retStr + SUFFIX_std_string_view;
101+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view);
102102
}
103103

104104

105105
std::string StrMute::revStrOverloadValCRef(const std::string_view& pStr)
106106
{
107107
std::string retStr(pStr);
108108
std::reverse(retStr.begin(), retStr.end());
109-
return std::string(struct_) + retStr + SUFFIX_std_string_view_clvref;
109+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view_clvref);
110110
}
111111

112112

113113
std::string StrMute::revStrOverloadValRef(std::string_view pStr)
114114
{
115115
std::string retStr(pStr);
116116
std::reverse(retStr.begin(), retStr.end());
117-
return std::string(struct_) + retStr + SUFFIX_std_string_view;
117+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view);
118118
}
119119

120120

121121
std::string StrMute::revStrOverloadValRef(std::string_view& pStr)
122122
{
123123
std::string retStr(pStr);
124124
std::reverse(retStr.begin(), retStr.end());
125-
return std::string(struct_) + retStr + SUFFIX_std_string_view_lvref;
125+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view_lvref);
126126
}
127127

128128

129129
std::string StrMute::revStrOverloadRefAndCRef(std::string_view& pStr)
130130
{
131131
std::string retStr(pStr);
132132
std::reverse(retStr.begin(), retStr.end());
133-
return std::string(struct_) + retStr + SUFFIX_std_string_view_lvref;
133+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view_lvref);
134134
}
135135

136136

137137
std::string StrMute::revStrOverloadRefAndCRef(const std::string_view& pStr)
138138
{
139139
std::string retStr(pStr);
140140
std::reverse(retStr.begin(), retStr.end());
141-
return std::string(struct_) + retStr + SUFFIX_std_string_view_clvref;
141+
return std::string(struct_).append(retStr).append(SUFFIX_std_string_view_clvref);
142142
}

0 commit comments

Comments
 (0)