fix: tighten verified learning references

Author: wenchanghan

plugin/dashboard/app/dashboard/page.tsx

@@ -11,6 +11,7 @@ import {
   Users,
 } from "lucide-react";
 import { LearningsBadge } from "@/components/common/learnings-badge";
+import { LearningApplicationBadge } from "@/components/common/learning-application-badge";
 import { HostBadge } from "@/components/common/host-badge";
 import { PageHeader } from "@/components/common/page-header";
 import { StatCard } from "@/components/common/stat-card";
@@ -96,7 +97,7 @@ export default function DashboardPage() {
   const approvedSharedSkills = (sharedSkills ?? []).filter(
     (p) => agentPlaybookStatusLabel(p) === "APPROVED",
   );
- const currentPreferences = (preferences ?? []).filter((p) => p.status == null);
+  const currentPreferences = (preferences ?? []).filter((p) => p.status == null);
   const statsByRule = useMemo(() => {
     const map = new Map<string, PlaybookApplicationStat>();
     for (const s of topApplied ?? []) {
@@ -285,7 +286,7 @@ export default function DashboardPage() {
                             <span className="text-[11px] text-muted-foreground">
                               {learningScope(item.kind)}
                             </span>
-                            <LearningCitationStatBadge stat={stat} />
+                            <LearningApplicationBadge stat={stat} />
                           </div>
                         </div>
                       </div>
@@ -404,17 +405,3 @@ function learningIcon(kind: RecentLearningKind) {
 function learningKindLabel(kind: RecentLearningKind): string {
   return kind === "preference" ? "preference" : "skill";
 }
-
-function LearningCitationStatBadge({
-  stat,
-}: {
-  stat: PlaybookApplicationStat | undefined;
-}) {
-  if (!stat || stat.applied_count === 0) return null;
-  const last = formatRelative(stat.last_applied_at);
-  return (
-    <Badge variant="secondary" className="h-5 text-[10px]">
-      Referenced {stat.applied_count}×{stat.last_applied_at ? ` · ${last}` : ""}
-    </Badge>
-  );
-}

plugin/dashboard/lib/types.ts

@@ -99,6 +99,7 @@ export interface SessionTurn {
 export interface SessionSummary {
   session_id: string;
   turn_count: number;
+  /** Assistant turns with at least one verified reference. Legacy field name. */
   learning_interaction_count: number;
   /** Unique learning identities recorded in the session injection registry. */
   injected_learning_count: number;
@@ -116,6 +117,7 @@ export interface SessionSummary {
 export interface SessionDetail {
   session_id: string;
   turns: SessionTurn[];
+  /** Assistant turns with at least one verified reference. Legacy field name. */
   learning_interaction_count: number;
   /** Unique learning identities recorded in the session injection registry. */
   injected_learning_count: number;

plugin/src/claude_smart/cs_cite.py

@@ -282,17 +282,19 @@ def parse_text_citations(text: str) -> list[str]:
     instruction requires the citation marker to be final.
     """
     old_matches = [
-        (m.start(), "ids", m.group("ids"))
+        (m.start(), m.end(), "ids", m.group("ids"))
         for m in _TEXT_CITATION_LINE_RE.finditer(text or "")
     ]
     new_matches = [
-        (m.start(), "links", m.group("body"))
+        (m.start(), m.end(), "links", m.group("body"))
         for m in _CITED_LINK_LINE_RE.finditer(text or "")
     ]
     matches = old_matches + new_matches
     if not matches:
         return []
-    _, kind, value = max(matches, key=lambda item: item[0])
+    _, end, kind, value = max(matches, key=lambda item: item[0])
+    if (text or "")[end:].strip():
+        return []
     if kind == "ids":
         return _parse_id_tokens(value)
     return _parse_dashboard_link_tokens(value)

plugin/src/claude_smart/events/stop.py

@@ -287,21 +287,17 @@ def _resolve_cited_items(session_id: str, cited_ids: list[str]) -> list[dict[str
     if not cited_ids:
         return []
     registry = state.read_injected(session_id)
-    registry_by_casefold = {
-        key.casefold(): value for key, value in registry.items()
-    }
     seen_citations: set[str] = set()
     seen_entries: set[str] = set()
     resolved: list[dict[str, Any]] = []
     for cid in cited_ids:
-        normalized_cid = cid.casefold()
-        if normalized_cid in seen_citations:
+        if cid in seen_citations:
             continue
-        seen_citations.add(normalized_cid)
-        entry = _registry_entry_for_citation(registry, registry_by_casefold, cid)
+        seen_citations.add(cid)
+        entry = _registry_entry_for_citation(registry, cid)
         if not entry:
             continue
-        canonical_id = _canonical_registry_entry_id(entry, normalized_cid)
+        canonical_id = _canonical_registry_entry_id(entry, cid)
         if canonical_id in seen_entries:
             continue
         seen_entries.add(canonical_id)
@@ -333,16 +329,15 @@ def _canonical_registry_entry_id(entry: dict[str, Any], fallback: str) -> str:
         source_kind = "profile" if kind == "profile" else str(
             entry.get("source_kind") or ""
         )
-        return f"{kind}:{source_kind}:{real_id}".casefold()
+        return f"{kind}:{source_kind}:{real_id}"
     entry_id = entry.get("id")
     if isinstance(entry_id, str) and entry_id:
-        return entry_id.casefold()
+        return entry_id
     return fallback
 
 
 def _registry_entry_for_citation(
     registry: dict[str, dict[str, Any]],
-    registry_by_casefold: dict[str, dict[str, Any]],
     citation: str,
 ) -> dict[str, Any] | None:
     """Resolve an exact rank id or a stable dashboard-route citation token.
@@ -353,10 +348,7 @@ def _registry_entry_for_citation(
     id (the compatibility path for entries without a real id).
     """
     if not citation.startswith("route:"):
-        entry = registry.get(citation)
-        if entry is not None:
-            return entry
-        return registry_by_casefold.get(citation.casefold())
+        return registry.get(citation)
     try:
         _, kind, source_kind, real_id = citation.split(":", 3)
     except ValueError:

tests/test_cs_cite.py

@@ -168,6 +168,15 @@ def test_parse_text_citations_uses_last_marker_line() -> None:
     assert cs_cite.parse_text_citations(text) == ["p2-2222"]
 
 
+def test_parse_text_citations_requires_marker_to_be_final() -> None:
+    text = (
+        "✨ Learning referenced: "
+        "[git safety](http://localhost:3001/rules/s1-1111)\n"
+        "The answer continues after the marker."
+    )
+    assert cs_cite.parse_text_citations(text) == []
+
+
 def test_parse_text_citations_accepts_uppercase_and_cs_prefixes() -> None:
     text = "Done.\n\n✨ 2 claude-smart learnings applied [cs:CS:P1-AB12,Cs:S2-CD34]"
     assert cs_cite.parse_text_citations(text) == ["p1-ab12", "s2-cd34"]

tests/test_events.py

@@ -1472,6 +1472,39 @@ def test_stop_deduplicates_learning_aliases(session_dir) -> None:
     ]
 
 
+def test_stop_keeps_case_distinct_learning_ids(session_dir) -> None:
+    """Stable real ids remain exact even when they differ only by case."""
+    state.append_injected(
+        "s1",
+        [
+            {
+                "id": "p1-abcd",
+                "kind": "profile",
+                "title": "uppercase",
+                "content": "uppercase",
+                "real_id": "AbCd",
+                "source_kind": "profile",
+                "ts": 0,
+            },
+            {
+                "id": "p2-abcd",
+                "kind": "profile",
+                "title": "lowercase",
+                "content": "lowercase",
+                "real_id": "abcd",
+                "source_kind": "profile",
+                "ts": 0,
+            },
+        ],
+    )
+
+    cited = stop._resolve_cited_items(
+        "s1", ["route:profile:profile:AbCd", "route:profile:profile:abcd"]
+    )
+
+    assert [item["real_id"] for item in cited] == ["AbCd", "abcd"]
+
+
 def test_stop_handles_missing_transcript_file(session_dir, monkeypatch) -> None:
     """``transcript_path`` points at a nonexistent file → no crash, empty record."""
     monkeypatch.setattr(