Implement new error handling via error_types.hxx

Author: Reim-developer

src/front_end/main_window_preload.cxx

@@ -20,6 +20,7 @@ using std::cout;
 #endif
 
 #include "../front_end_utils/include/error_types.hxx"
+#include "../front_end_utils/include/utils.hxx"
 
 using Lazyboard::front_end::MainWindowPreload;
 using Self = MainWindowPreload;
@@ -28,74 +29,67 @@ using std::make_unique;
 using std::string;
 using std::stringstream;
 using namespace Lazyboard::ffi;
-using Lazyboard::front_end_utils::error_types_map;
+using Lazyboard::front_end_utils::error_dialog_show;
+using Lazyboard::front_end_utils::ErrorTypes;
 
 void Self::on_gen_default_cfg_error(WriteConfigStatus status,
 									QMainWindow *main_window) {
 	switch (status) {
+		using E = ErrorTypes;
+
 		case WriteConfigStatus::OK:
 			break;
 
 		case WriteConfigStatus::CREATE_DIR_FAILED:
-			QMessageBox::critical(main_window, "Error",
-								  "Could not create config directory");
+			error_dialog_show(main_window, E::CREATE_DIR_FAILED);
 
 			break;
 
 		case WriteConfigStatus::GET_CONFIG_DIR_FAILED:
-			QMessageBox::critical(main_window, "Error",
-								  "Could not get application local data");
+			error_dialog_show(main_window, E::GET_CONFIG_DIR_FAILED);
 			break;
 
 		case WriteConfigStatus::CREATE_FILE_FAILED:
-			QMessageBox::critical(main_window, "Error",
-								  "Could not create configuration file");
+			error_dialog_show(main_window, E::CREATE_FILE_FAILED);
 			break;
 
 		case WriteConfigStatus::WRITE_FILE_FAILED:
-			QMessageBox::critical(main_window, "Error",
-								  "Could not write configuration");
+			error_dialog_show(main_window, E::WRITE_FILE_FAILED);
 			break;
 
 		case WriteConfigStatus::TOML_TO_STRING_FAILED:
-			QMessageBox::critical(main_window, "Error",
-								  "Could not convert TOML data to string");
+			error_dialog_show(main_window, E::TOML_TO_STRING_FAILED);
 			break;
 	}
 }
 
 void Self::on_read_exists_cfg_error(RawReadAppConfigStatus status,
 									QMainWindow *main_window) {
 	using Status = RawReadAppConfigStatus;
+	using E = ErrorTypes;
 
 	switch (status) {
 		case Status::READ_OK:
 			break;
 
 		case Status::CONVERT_TO_MUT_FAILED:
-			QMessageBox::critical(main_window, "Error",
-								  "Could not convert to *mut c_char");
+			error_dialog_show(main_window, E::CONVERT_TO_MUT_FAILED);
 			break;
 
 		case Status::PARSE_TOML_FAILED:
-			QMessageBox::critical(main_window, "Error",
-								  "Parse TOML configuration failed");
+			error_dialog_show(main_window, E::PARSE_TOML_FAILED);
 			break;
 
 		case Status::READ_FILE_FAILED:
-			QMessageBox::critical(main_window, "Error",
-								  "Could not read configuration file");
+			error_dialog_show(main_window, E::READ_FILE_FAILED);
 			break;
 
 		case Status::UTF_8_ERROR:
-			QMessageBox::critical(main_window, "Error",
-								  "UTF-8 error in configuration file");
+			error_dialog_show(main_window, E::UTF_8_ERROR);
 			break;
 
 		case Status::CONVERT_TO_C_STR_FAILED:
-			QMessageBox::critical(
-				main_window, "Error",
-				"Could not convert value configuration to C string");
+			error_dialog_show(main_window, E::CONVERT_TO_C_STR_FAILED);
 			break;
 	}
 }
@@ -122,9 +116,8 @@ void Self::create_default_config(QMainWindow *main_window) {
 
 		// clang-format off
 		#if defined(LAZY_DEBUG)
-				cout << "[DEBUG] " << "Config path not found, generate at: " << config_path
-					<< "\n";
-		#endif
+			cout << "[DEBUG] " << "Config path not found, generate at: " << config_path << "\n";
+		#endif 
 
 		return;
 	}
@@ -137,8 +130,8 @@ void Self::create_default_config(QMainWindow *main_window) {
 void Self::read_if_exists_config(QMainWindow *main_window) {
 	raw_app_config = make_unique<RawAppConfig>();
 	theme_manager = make_unique<ThemeManager>();
-	auto config_path = this->application_config();
 
+	auto config_path = this->application_config();
 	auto status = exists_config(config_path.data(), raw_app_config.get());
 	this->on_read_exists_cfg_error(status, main_window);
 

src/front_end/theme_manager.cxx

@@ -54,8 +54,7 @@ auto Self::gui_settings(RawAppConfig *raw_app_config) noexcept -> GuiSettings {
 void Self::on_invalid_hex_color_error(QMainWindow *main_window) {
 	using E = ErrorTypes;
 
-	const auto message = "Invalid HEX Color in your TOML configuration";
-	error_dialog_show(main_window, message, E::INVALID_HEX_COLOR);
+	error_dialog_show(main_window, E::INVALID_HEX_COLOR);
 }
 
 void Self::set_main_window_theme(QMainWindow *main_window,

src/front_end_utils/include/error_types.hxx

@@ -23,18 +23,35 @@ enum class ErrorTypes : uint8_t {
 	GET_CONFIG_DIR_FAILED,
 	CREATE_FILE_FAILED,
 	TOML_TO_STRING_FAILED,
+	WRITE_FILE_FAILED,
+	CONVERT_TO_MUT_FAILED,
+	CONVERT_TO_C_STR_FAILED,
+	PARSE_TOML_FAILED,
+	READ_FILE_FAILED,
+	UTF_8_ERROR,
 };
 
 using Types = initializer_list<pair<ErrorTypes, string_view>>;
 inline constexpr Types error_types_map() noexcept {
 	using E = ErrorTypes;
 
 	const Types error_types = {
-		pair{E::INVALID_HEX_COLOR, "INVALID_HEX_COLOR"},
-		pair{E::CREATE_DIR_FAILED, "CREATE_DIR_FAILED"},
-		pair{E::GET_CONFIG_DIR_FAILED, "GET_CONFIG_DIR_FAILED"},
-		pair{E::CREATE_FILE_FAILED, "CREATE_FILE_FAILED"},
-		pair{E::TOML_TO_STRING_FAILED, "TOML_TO_STRING_FAILED"},
+		{E::INVALID_HEX_COLOR,
+		 "Invalid HEX color, please check your TOML configuration and try "
+		 "again"},
+		{E::CREATE_DIR_FAILED, "Create directory failed"},
+		{E::GET_CONFIG_DIR_FAILED, "Get configuration directory failed"},
+		{E::CREATE_FILE_FAILED, "Create file faled"},
+		{E::TOML_TO_STRING_FAILED, "Could not convert TOML to string"},
+		{E::WRITE_FILE_FAILED, "Could not write file"},
+		{E::CONVERT_TO_MUT_FAILED, "Could not convert value to '*mut c_char'"},
+		{E::CONVERT_TO_C_STR_FAILED, "Could not convert value to 'c_str'"},
+		{E::PARSE_TOML_FAILED,
+		 "Could not parse TOML, please check your configuration and try "
+		 "again"},
+		{E::READ_FILE_FAILED, "Could not read file"},
+		{E::UTF_8_ERROR, "UTF-8 error"},
+
 	};
 
 	return error_types;

src/front_end_utils/include/utils.hxx

@@ -15,6 +15,7 @@
 
 #include "error_types.hxx"
 
+using std::abort;
 using std::initializer_list;
 using std::is_same_v;
 using std::stringstream;
@@ -56,12 +57,12 @@ inline QIcon image_from_bytes(const initializer_list<uint8_t>& data) noexcept {
 	return QIcon();
 }
 
-inline void error_dialog_show(QWidget* parent, const QString& message,
+inline void error_dialog_show(QWidget* parent,
 							  ErrorTypes error_types) noexcept {
 	auto error_string = error_to_string(error_types).data();
-	auto fmt_msg = QString("%1\nError name: %2").arg(message).arg(error_string);
 
-	QMessageBox::critical(parent, "Error", fmt_msg);
+	QMessageBox::critical(parent, "Error", error_string);
+	abort();
 }
 
 }  // namespace Lazyboard::front_end_utils