Make hash compatible with pyrel

Author: nystrom

meta/src/meta/templates/parser.go.template

@@ -364,8 +364,9 @@ func (p *Parser) startFragment(fragmentID *pb.FragmentId) *pb.FragmentId {{
 
 func (p *Parser) relationIdFromString(name string) *pb.RelationId {{
 	hash := sha256.Sum256([]byte(name))
-	low := binary.LittleEndian.Uint64(hash[:8])
-	high := binary.LittleEndian.Uint64(hash[8:16])
+	// Use big-endian and the lower 128 bits of the hash, consistent with pyrel.
+	high := binary.BigEndian.Uint64(hash[16:24])
+	low := binary.BigEndian.Uint64(hash[24:32])
 	relationId := &pb.RelationId{{IdLow: low, IdHigh: high}}
 
 	// Store the mapping for the current fragment if we're inside one

meta/src/meta/templates/parser.jl.template

@@ -228,9 +228,9 @@ end
 function relation_id_from_string(parser::ParserState, name::String)
     # Create RelationId from string and track mapping for debug info
     hash_bytes = sha256(name)
-    # Use little-endian to match the Go and Python SDKs.
-    id_low = htol(reinterpret(UInt64, hash_bytes[1:8])[1])
-    id_high = htol(reinterpret(UInt64, hash_bytes[9:16])[1])
+    # Use big-endian and the lower 128 bits of the hash, consistent with pyrel.
+    id_high = ntoh(reinterpret(UInt64, hash_bytes[17:24])[1])
+    id_low = ntoh(reinterpret(UInt64, hash_bytes[25:32])[1])
     relation_id = Proto.RelationId(id_low, id_high)
 
     # Store the mapping for the current fragment if we're inside one

meta/src/meta/templates/parser.py.template

@@ -214,8 +214,9 @@ class Parser:
     def relation_id_from_string(self, name: str) -> Any:
         """Create RelationId from string and track mapping for debug info."""
         hash_bytes = hashlib.sha256(name.encode()).digest()
-        id_low = int.from_bytes(hash_bytes[:8], byteorder='little')
-        id_high = int.from_bytes(hash_bytes[8:16], byteorder='little')
+        # Use big-endian and the lower 128 bits of the hash, consistent with pyrel.
+        id_high = int.from_bytes(hash_bytes[16:24], byteorder='big')
+        id_low = int.from_bytes(hash_bytes[24:32], byteorder='big')
         relation_id = logic_pb2.RelationId(id_low=id_low, id_high=id_high)
 
         # Store the mapping for the current fragment if we're inside one

sdks/go/src/hash_test.go

@@ -7,10 +7,10 @@ import "testing"
 func TestRelationIdFromString(t *testing.T) {
 	p := NewParser([]Token{})
 	rid := p.relationIdFromString("my_relation")
-	if rid.IdLow != 0x5d33996702404f85 {
-		t.Errorf("id_low: got 0x%016x, want 0x5d33996702404f85", rid.IdLow)
+	if rid.IdLow != 0xf2fc83ec57cf8fbc {
+		t.Errorf("id_low: got 0x%016x, want 0xf2fc83ec57cf8fbc", rid.IdLow)
 	}
-	if rid.IdHigh != 0x3b9af8e72af633f8 {
-		t.Errorf("id_high: got 0x%016x, want 0x3b9af8e72af633f8", rid.IdHigh)
+	if rid.IdHigh != 0x503f7dc862f367b7 {
+		t.Errorf("id_high: got 0x%016x, want 0x503f7dc862f367b7", rid.IdHigh)
 	}
 }

sdks/go/src/parser.go

@@ -390,8 +390,9 @@ func (p *Parser) startFragment(fragmentID *pb.FragmentId) *pb.FragmentId {
 
 func (p *Parser) relationIdFromString(name string) *pb.RelationId {
 	hash := sha256.Sum256([]byte(name))
-	low := binary.LittleEndian.Uint64(hash[:8])
-	high := binary.LittleEndian.Uint64(hash[8:16])
+	// Use big-endian and the lower 128 bits of the hash, consistent with pyrel.
+	high := binary.BigEndian.Uint64(hash[16:24])
+	low := binary.BigEndian.Uint64(hash[24:32])
 	relationId := &pb.RelationId{IdLow: low, IdHigh: high}
 
 	// Store the mapping for the current fragment if we're inside one

sdks/julia/LogicalQueryProtocol.jl/src/parser.jl

@@ -254,9 +254,9 @@ end
 function relation_id_from_string(parser::ParserState, name::String)
     # Create RelationId from string and track mapping for debug info
     hash_bytes = sha256(name)
-    # Use little-endian to match the Go and Python SDKs.
-    id_low = htol(reinterpret(UInt64, hash_bytes[1:8])[1])
-    id_high = htol(reinterpret(UInt64, hash_bytes[9:16])[1])
+    # Use big-endian and the lower 128 bits of the hash, consistent with pyrel.
+    id_high = ntoh(reinterpret(UInt64, hash_bytes[17:24])[1])
+    id_low = ntoh(reinterpret(UInt64, hash_bytes[25:32])[1])
     relation_id = Proto.RelationId(id_low, id_high)
 
     # Store the mapping for the current fragment if we're inside one

sdks/julia/LogicalQueryProtocol.jl/test/parser_tests.jl

@@ -118,8 +118,8 @@ end
     # All SDKs must produce the same id for the same string.
     parser = ParserState(Token[])
     rid = relation_id_from_string(parser, "my_relation")
-    @test rid.id_low == 0x5d33996702404f85
-    @test rid.id_high == 0x3b9af8e72af633f8
+    @test rid.id_low == 0xf2fc83ec57cf8fbc
+    @test rid.id_high == 0x503f7dc862f367b7
 end
 
 @testitem "Parser - Lexer tokenization" setup=[ParserSetup] begin

sdks/python/src/lqp/gen/parser.py

@@ -242,8 +242,9 @@ def start_fragment(
     def relation_id_from_string(self, name: str) -> Any:
         """Create RelationId from string and track mapping for debug info."""
         hash_bytes = hashlib.sha256(name.encode()).digest()
-        id_low = int.from_bytes(hash_bytes[:8], byteorder='little')
-        id_high = int.from_bytes(hash_bytes[8:16], byteorder='little')
+        # Use big-endian and the lower 128 bits of the hash, consistent with pyrel.
+        id_high = int.from_bytes(hash_bytes[16:24], byteorder='big')
+        id_low = int.from_bytes(hash_bytes[24:32], byteorder='big')
         relation_id = logic_pb2.RelationId(id_low=id_low, id_high=id_high)
 
         # Store the mapping for the current fragment if we're inside one

sdks/python/tests/test_parser.py

@@ -12,8 +12,8 @@ def test_relation_id_from_string():
     """All SDKs must produce the same id for the same string."""
     parser = Parser([])
     rid = parser.relation_id_from_string("my_relation")
-    assert rid.id_low == 0x5D33996702404F85
-    assert rid.id_high == 0x3B9AF8E72AF633F8
+    assert rid.id_low == 0xF2FC83EC57CF8FBC
+    assert rid.id_high == 0x503F7DC862F367B7
 
 
 @pytest.mark.parametrize("input_file", get_lqp_input_files())